Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp849599lqd; Wed, 24 Apr 2024 20:52:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOPLggQ0d1eptvKBrPJMo9uN83kvTXOHH+DdWS8ROdcujqElQ8kzxd/dA9Bg4znxsOxZB2ob38jiE1B7VdBS3s/nUsZIEoTw9AHoly2Q== X-Google-Smtp-Source: AGHT+IEJZoUgO/hOT2yuTWK+/nx/e13+nv36gTGN8fXub4QdAdnPFsx/Rb8exLZQNDiUdXFO/kQ5 X-Received: by 2002:a17:902:da88:b0:1e4:17e4:3a1f with SMTP id j8-20020a170902da8800b001e417e43a1fmr5664901plx.4.1714017152827; Wed, 24 Apr 2024 20:52:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714017152; cv=pass; d=google.com; s=arc-20160816; b=sh7JPJLYQlZngW4h/IEed5hivnn+PWoItOAJsk/DE0QhmFAz3/lNuHUULFc0EcTg7W UuME5xe0BuIIbmCygvdIjEpcPO8q2O3yZYoe9fkwmGt8P4ywoDOP15DXHqzAPxYCTt+4 tpp67MHqQ/cFT+57zd3Dtw4hnc3GwDrZnp6cV4/WU6g9PY4LQMCUWVLv5aLWjk4PAHOS 3yzlWl61EtS12jvr+yXBjVmEOu2FwMYyuXzPwZZ+lk4s3Fw/FIYqKtMjAD42uNxq4t5f k8yHldNcaXZuWZj364wJFi3Ez+95zRuUmFOzz2o3CNs8Cku/uYKO/wjatv2CB5mceiXZ Odig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=bnw6YuOjdt9i/9Rb/x2XGCKaXMMyz7OLNYXwxU3I9Oc=; fh=c1dFFm7P5DnGlxoIcqtQ1zIpAKQkg3ZQZ7vjqDdk7sg=; b=Ikitj2vU1Bspf7/IumoXJYXh4I5u0/P4L1FiM8+4MGpuCOmKCvVD+KxCJQALFjRGIR Sc3qr6BSKea3aE+O8Lusu0Zkoyk7maKBy6AmvOnjXXrXGVpRXnsMQrIX9zoEU4qRtU+G 1PySped85CssqowL/rigMrMPyyzkOcmkS9t9s71mBPGLQimu+XxYeANnkxCOTWoD41gW HO8UDrcTNhCGFNCe/Lqyi/ZiXALfafDO1CrevL7EQG2etRRcKHsVha5W+UPiZPmRSZnq 1Wic01LjLgKUdFiBUSShV5wep2UyV/lcnh0juimJLhe06Y01ysJJAC+Rkx5KntCrKz4Z o6+g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cLcZBRSX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-157979-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157979-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i13-20020a170902c94d00b001e51158e3f4si12628146pla.67.2024.04.24.20.52.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 20:52:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157979-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cLcZBRSX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-157979-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157979-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ADE5C286969 for ; Thu, 25 Apr 2024 03:47:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72F5E2C69B; Thu, 25 Apr 2024 03:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cLcZBRSX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C8F122F0D; Thu, 25 Apr 2024 03:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714016817; cv=none; b=eYhz2cKp4Nx77aF31/ZN30zXl5mBk/ln+bTqpA1YAevRf9iXVI9lWYBodnvuDH9GPArBKQmcPYYfqMgbpohe+gM0zE6W28Bme5Ko26nOW3Cikvuvx5AMaQBK3H1MDYn5VIAjloB4jAkd/LNrJ1BsA2vADu38ryczdbzKCyPn4SE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714016817; c=relaxed/simple; bh=fSWVkSsgoRD6SMlmpNYA6oLa7Vc1xeL3oLQj477NoBM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bc23nTR3Qdjf/KujadRf/c33/pk+Ly9nDQWXOxP7hZ8VI2XfF2kLB/Px53gghw7gN2ohx1pSZpTCi68lI2c70BUyLnOyeBDnSrAsl+Q2MsZ+oARr/21Jtbhu733B6mh4nkJBxWtfVOmtcAIPajb0sK/kh+qhT5ffCoR4tyYtB5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cLcZBRSX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D81BC113CC; Thu, 25 Apr 2024 03:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714016817; bh=fSWVkSsgoRD6SMlmpNYA6oLa7Vc1xeL3oLQj477NoBM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cLcZBRSXoRYHOTIYGK1XZF+WlxxKrgNCW8WexdZEsK80Le7fbZrWaeVL5FTWrRhsD fJFoDmC3FbjOwiILawqmeytWemyq5obxleRDfauRSCY6Qs8BUVLrSdkqFAGqBiNw8d pzGR1Q8mMYndOoOhBPnWD/3gW29HgBAcwJkhB1ckbKXPDoTUx/qZAgz/YtuN0gzv8e tCAm8snXKoAORd3+UzqEXnpTPOsnDp2nv/V1hkt6v24T0MpgByyBm8vxTxHLKZddZ/ lKPpZMAwFRcxZjqtJJkj9SGC9oMD4jYLARcpwW8lLcHfG+75J5QWkLMEpJQd3BP1s3 XLvI9608h8/mw== Date: Wed, 24 Apr 2024 20:46:55 -0700 From: Jakub Kicinski To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tariqt@nvidia.com, saeedm@nvidia.com, mkarsten@uwaterloo.ca, gal@nvidia.com, nalramli@fastly.com, "David S. Miller" , Eric Dumazet , Paolo Abeni , "open list:MELLANOX MLX4 core VPI driver" Subject: Re: [PATCH net-next 3/3] net/mlx4: support per-queue statistics via netlink Message-ID: <20240424204655.7042c614@kernel.org> In-Reply-To: References: <20240423194931.97013-1-jdamato@fastly.com> <20240423194931.97013-4-jdamato@fastly.com> <20240423175718.4ad4dc5a@kernel.org> <20240424072818.2c68a1ab@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Apr 2024 09:39:40 -0700 Joe Damato wrote: > FWIW, I also attempted to implement this API for i40e (hardware I also > have): > > https://lore.kernel.org/lkml/20240410043936.206169-1-jdamato@fastly.com/ Ah, missed the second patch on that thread initially! > But there are some complications I haven't resolved, so I'm focusing on > mlx4 and mlx5, first, and will have to come back to i40e later. FWIW I hope this series will get ironed out soon and we'll have far more qstats defined: https://lore.kernel.org/all/20240423113141.1752-1-xuanzhuo@linux.alibaba.com/ The drop counts in particular could be useful in production, not so sure about the rest :)