Received-SPF: pass (google.com: domain of linux-kernel+bounces-157997-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3135e3c2-9d29-427b-8e6b-c0b627c7890f@intel.com>
Date: Wed, 24 Apr 2024 21:37:26 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 07/16] selftests/resctrl: Cleanup bm_pid and ppid usage
 & limit scope
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, <linux-kernel@vger.kernel.org>
References: <20240408163247.3224-1-ilpo.jarvinen@linux.intel.com>
 <20240408163247.3224-8-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240408163247.3224-8-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckc5Si8xR0R0VlVyek9GN0xUbmwxSHg4eWJZTlJxQncxTEorQ0NqeCtnTEJC?=
 =?utf-8?B?dG5NVmljMU05VWk1UkEvcU1neXdSQWNzejB5VDlHMUs2WUcrNXcweDhUS2d4?=
 =?utf-8?B?WCtUTHAzN1N0Wm1sZXRFWUcyemN4RHk4blRjZzNsK3cvdVc1RVBqN0ltdUk1?=
 =?utf-8?B?UjZJRmszdEljUjBrZ0syNG51R2Y1bXdBM0JUSjRxYm1ueEdGRnI4NnNPRVN6?=
 =?utf-8?B?SVpnTDJsNTBwN2FPWkFiTUg0S1JmZWV3aEY4YTNPK01lTFU1bFIwVmprRlpv?=
 =?utf-8?B?RDB5anBtdUFyK0VUTW5kMzFtUlRkMkJGb1hzSEdheGRhS29FZU0wc3NRU202?=
 =?utf-8?B?RW1qS0s1SmswZnlsSDRlTmhFMCs2ZzhTZ3ZDa0xaeDR0MXJJcUtuZUNNVFpj?=
 =?utf-8?B?M3R3bjZCL2NCd3BJU3ZwWmFxOU5Ed3crQTQycjlVSVBVWW13MGtjZlFvNlJE?=
 =?utf-8?B?WSt6bnQzNmJKelBFVzlKQ1NnK1RERldiZnVhaHl2d1RycXIxYkpFOFJ5djcy?=
 =?utf-8?B?d1RMYmJObEFwOUVhRzRMckpjWm5jbWN1LzZ6SkFieU1aRXZaKzk3Uk54d2wr?=
 =?utf-8?B?Z001dVRCamZ3RG1mR1J0bFlhN2t6WFRpNVZrY3N5Q3VRYU1jemtjbDF0QWNt?=
 =?utf-8?B?eUZLWHIwYXYyMTk0QXBXUDB5aEE0YjZ4Q09MUW1Jbmw3NFlPWG9HWW82NnVB?=
 =?utf-8?B?VWtMNXlTK1dtN0tjdVcraGRGN2lvWVRGQzRqV1RiWForMktja1pVRkR2Y3A5?=
 =?utf-8?B?aUFyOUdjVnljYnhDTnR5bnhnVWtYeU16Z2xaYXRwS1hQRjVvL2NxNnZ1ZnBF?=
 =?utf-8?B?dVhaSSt4eHZqNDhJR09xWkQxd1FDYzh2WUFFRG4vaGdEREZ4R3ZSN0hpT0FO?=
 =?utf-8?B?Sk9zSVNQbHZQRUlyOVYyMkpQN3Nmald1UHJyaW1CNkNXNFRQME5XSkwvTDV6?=
 =?utf-8?B?RmNFZ1FWcG15ZVFmaGZrLys5eEFLRmJ1MWRjYUovaUNBTlByUG9kU3VYNHB1?=
 =?utf-8?B?NFJDNDVDUDZjMndibGV0Z2RqVEpKaHhYM0pPeEVHdlNtMmlzVnRYUmxTSUFp?=
 =?utf-8?B?YlBDbWtkNCtqczdnUzA4Z2srUUJUNjNWSFdpV2lLbkNFcU1DbllraWhNMkhr?=
 =?utf-8?B?VFpLWjdHVlcvcUl5dGZiVnMyQjFGZGVDYy9Wa2tiSzBiOXo0ZkE2RG40bzJZ?=
 =?utf-8?B?Q3FHbkd2NVdOa0hqelA5VmNJemd4WFZidW03R1o0b0NtZ3J3R0JNRFV6VWRX?=
 =?utf-8?B?bXdoSkhHbmJLdWs0STFyNjFnMzRFM0tuT3N6S0NFN2o1MVdjSldveS9IdklO?=
 =?utf-8?B?Um1KRUJPcHZ6MlJsUU9MV1ZWa0tmUDBGaEhsRWIyK3QzOUZJOG55VUFNOFA4?=
 =?utf-8?B?Qi8xTnhUV3BHa1kwTlZGZThOK216c294SzlQa1NLZktzMjdnNE1BVlJIemlR?=
 =?utf-8?B?MjViQ0h3UXBJNlgrMDh4VHhEbTdPVE9RSXR1K2ZSOGFXTStOM1hZTi9TcC9u?=
 =?utf-8?B?WTcyOVJ6UkE1S0hMaTdmU1VaWTBwYjJmL0lUenh0S2hPMWlMa203RXgyWk5W?=
 =?utf-8?B?Y0IxZGU1VVhuTFhGTitWK1ppeWo3MXYyUkRYU1BSMXBweDRaUDI4K2FZZzls?=
 =?utf-8?B?T0praVBmYnZ1dTJLYW8ySmZpV244dDF1dmVKR1p4cjlqTXZ1bEY2OERpd0dk?=
 =?utf-8?B?WUdwaGlqWFBrMjRVWDR3MFFSTm82bWM5YzhXUWp1SURLYjhWcUFDeDlCWUVR?=
 =?utf-8?B?bEJGWUVKU0JoNjViUzQ1T0JvbHZxZGlOZ0hod09OMXBSUTdyR3NUTXIxYkNr?=
 =?utf-8?B?eUpDQUZqb0tyeVRDVElxZkFPMTROaEhBU3lzdHc5N0JwakR4MW0ray9rMS90?=
 =?utf-8?B?MXM5NnRCNWhrWklsNXQwZ3V2MEYwYTVOVXNVY3JQdU8yRXB0UGNZSVJNOVlo?=
 =?utf-8?B?aXRWMEM0Mk9nVTY3b0N2UHRWOUIyV0psRTAvR1lVc2oxMFZUeThOUTFHVFVv?=
 =?utf-8?B?bHF0TDA1WWxKdG5iZU1SN2NNY2tlYUdrYkd3VGFNL1hjUURTWEFtZ2pZZmpz?=
 =?utf-8?B?ZXRzVHhwdTY5T1BPRXAvbUdVRjJtWEVKa2V5MWtGUzJEVDAxOHV5a3J4Mkl2?=
 =?utf-8?B?U2M5ZjIxY1IyaSsxVXJ1ZWFPYnhhZzBVUm1RR0htbWNNaVByT0VhQ3FOVGRs?=
 =?utf-8?B?WlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd07ff16-58d7-4a43-f9bb-08dc64e169cd
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 04:37:28.6639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: snGJAlF7bKHjmcTq/PKzvzE86LFOl3kCLd8Zl6ZR2S0xBnEEI1Q2Cq32IJrjCAs5t/YMrEoja0esHL36LTyRkA62Qgzp2BILoBuFTG+a2kg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7330
X-OriginatorOrg: intel.com

Hi Ilpo,

On 4/8/2024 9:32 AM, Ilpo Järvinen wrote:
> 'bm_pid' and 'ppid' are global variables. As they are used by different
> processes and in signal handler, they cannot be entirely converted into
> local variables.
> 
> The scope of those variables can still be reduced into resctrl_val.c
> only. As PARENT_EXIT() macro is using 'ppid', make it a function in
> resctrl_val.c and pass ppid to it as an argument because it is easier
> to understand than using the global variable directly.
> 
> Pass 'bm_pid' into measure_val() instead of relying on the global
> variable which helps to make the call signatures of measure_val() and
> measure_llc_resctrl() more similar to each other.

nitpick: measure_val() -> measure_vals()  (two instances above and
also in the changelog of next patch)

> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reinette