Received-SPF: pass (google.com: domain of linux-kernel+bounces-158000-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <21a1152d-2005-4883-bdd1-396b561aaea1@intel.com>
Date: Wed, 24 Apr 2024 21:39:04 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 11/16] selftests/resctrl: Add ->init() callback into
 resctrl_val_param
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, <linux-kernel@vger.kernel.org>
References: <20240408163247.3224-1-ilpo.jarvinen@linux.intel.com>
 <20240408163247.3224-12-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240408163247.3224-12-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2lPM1d5bUNFTUdXZFVXVmdNUG5DRjJaRUQ3SEpYcmxrSnIySERKenE5MlJR?=
 =?utf-8?B?bFNXQzFnTk1OVS92S3ptTUoyWmJVMTdCdU1VVENrczVpNktaeHMvSy9Yb3pP?=
 =?utf-8?B?Z3M5QjREOTZvRXJZd3ZiY3JUT0xSVWFSUWpLSzNScytwcEFyc0E5dVBhc1Zk?=
 =?utf-8?B?cSt6bUJUUTJiQklEbU1kaTlocHZabnJza1Yxejd2VVM3SmwxZzVBZlRjQVp3?=
 =?utf-8?B?cGRhb3VYMStrQ3VHOFFnMkppYjVsK2ZyQTlsRDlyTGJ5cXhmZE1xY25JQlox?=
 =?utf-8?B?ZXZuSFVvUVBsQ0VGQWFOTHZvcjhMaHRGWHhIWTBzeGZVaStneHgzZmEyYnRx?=
 =?utf-8?B?Wm1PaEJZalV5ZUhVM3BLTXB3c21sVEdPa25NR1RVTzlGd1Z3cVpYRlV2dlZ2?=
 =?utf-8?B?VlhrbkNBc3FMTnBpR2hnK283bTNrKzd2S1E2OW00UzZMZWJxd1dnZW9MQ0dT?=
 =?utf-8?B?MkpLVllLcXhzZ3poc2p3TlVxakYxMk1XNmpHS0oyNWFlSFVjYVpZZnZsUHgw?=
 =?utf-8?B?Z0hFL2Z6TkpmSndMeDFsOEl4L0phRzFwUmRoRlNac0d6SHUvMXNuNkEyNmp1?=
 =?utf-8?B?c1NDSnFVeGJYY0VCclpwalFTSFFub3NxMW1yeU1ZOWdncXIrR1JJMjR1L09B?=
 =?utf-8?B?elZhS3ROeHkxbHhyYlFJek1QY2tqZ3BjVVpITlN2Nm1zL3BPY3prcklmVVFq?=
 =?utf-8?B?a282TjhPNnhJby9wQWRtK0IwKzdEUGNEQ016WjhNY2ZxN1Y2QWx5T0hqczZS?=
 =?utf-8?B?alRZZFNjSVRuTjNrYTRUN0drcWFPYXdzZ3QyM0pucXpjcWZsZTNuUDREQmhY?=
 =?utf-8?B?M0hZSGVWMThsSTlzTkFHTTNGckRRSXpCWGMxZVc1Mk5tVHlPZ2I5UEU3ak1n?=
 =?utf-8?B?L3JuL3dhMHBwSlUyN2hVb0t0alpXZXRLNlQ5MnVYVENCeS9qY0pWU0RRVkxq?=
 =?utf-8?B?cU9pR2J4QTZaYkdJeUNUL01yekxOcXdQVzU3T2h0MGhaWko3UDRISS9NSnlD?=
 =?utf-8?B?TE1waHhTZm8wRDY0YTQ1YlRtQmxlRFYvOUdnanNtaVNnejJla1pvM3MrM3Yx?=
 =?utf-8?B?TWlRbllFUVNpalVJT3J0WWhGQ2tSd2ltVnRWZW1JWTArdzU0Q25EWFlnWFNE?=
 =?utf-8?B?cFAwekpsUWN3MklFRTV1ODMzNUY3WFJkQ3FoODUwbDVrSjZjekFDNG4yOWtJ?=
 =?utf-8?B?WExjZWFXdUNob2Nra0g1SlJncXI4MHRLMkJzVG9rWThrSXRDUEtkOFBJVWo0?=
 =?utf-8?B?M1doSEtJNW02eEUwS0ZhcHl4RUc1TERpb3FvbHI5VHcxZUZVWGt3VmFIejZ6?=
 =?utf-8?B?WHI1M2JuTWVINXc0Uk1EYjlGVlN2Rmp4bHpBdnM1cUx0Si96TU1remdzZFpn?=
 =?utf-8?B?M0V3bk1KOXhTc0daTnc4aFAzOWduNDltWnNmZE5VNFFLZ2RjcUNUSGhLeFQx?=
 =?utf-8?B?M0NOYlRpdTN3MFA1MXlkbHBlVXV2WmtzbmsyRzltV2UzRWRTbUVtOUUxR3Fl?=
 =?utf-8?B?OVp4WGJpK0Z4TkV3bHlGMU5wZVZDK0UyNmJoWWtrekJGMFg1OUtpbTduUHk0?=
 =?utf-8?B?cE1ZT2hmMVFFZFUra21wa2ZSMUp2OEd1N1ZBOHJIMk9tYldTem5kbTZBUitU?=
 =?utf-8?B?MVF2bHpLMjlmaEpVSVZaNHJBRmk5bkFkV2o2M0lUcGlmdEVNNXFWVVVFeEEw?=
 =?utf-8?B?YWxMZnhINjN0cXBYQjhNTFhEY2JRTHlMTEpZbFoxajJJRGoxcWxnUDlKTjJj?=
 =?utf-8?B?R1l6UXR5Z0RQN0pPd2Y2UG5mVzBmdUx0SHM2VXlqMXlyYzdNNE1iWmZ3dmcx?=
 =?utf-8?B?UE9CWmYwTGozeGVJWGpJbHlVeHRUd3BPYmllUTMyTVFlM3VuM29vdUZUcE1m?=
 =?utf-8?B?L1oreDd4TUN4Tkt3TFhkdHpJU25hZ1YxVkhYLyswYjZKZkh6aGJTVFRGWVhz?=
 =?utf-8?B?RmJ5ZjNSUjA3dHVzZEdWV3cvRnExMVFQRSs1Y3pyWnlyckZEVnZCTnI1MlE3?=
 =?utf-8?B?MVFncm1MdEFjMVJHWjgvczkrRWJpV1EzVUQ2dWo3RVArT041Wm8rcTV1L3Vz?=
 =?utf-8?B?QkZsU2NGNmdPNHNZWE9DdFlUQ2wwS2E0R04wdnhzc0lxWno2bXRTQzJzUEl4?=
 =?utf-8?B?WlRCYnlQdzZWSS9JWVVMeWdNaEhPV1NibitiUStQNDNOVTNlTXdxZENZVFV3?=
 =?utf-8?B?Rnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a65e8c6e-2881-4792-4f43-08dc64e1a444
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 04:39:06.7258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1DbmM+5sXU9ThLfE8Mu6RZPY2vIrH2xxPQVVUKPB35lzi+r8KlwNaPBaKmyZFVOht2ysaaZFb3suBtu9oIkDmeGxFDVi29dsxYLvvZ+iRPQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5940
X-OriginatorOrg: intel.com

Hi Ilpo,

On 4/8/2024 9:32 AM, Ilpo Järvinen wrote:
> The struct resctrl_val_param is there to customize behavior inside
> resctrl_val() which is currently not used to full extent and there are
> number of strcmp()s for test name in resctrl_val done by resctrl_val().
> 
> Create ->init() hook into the struct resctrl_val_param to cleanly
> do per test initialization.
> 
> Remove also unused branches to setup paths and the related #defines
> for CMT test.

All these code being moved have a similar pattern to earlier code that
was deleted. It seems to me as though the CMT may also unnecessarily
create a monitor group and have the same opportunity to remove
some of the code being moved around here.

It is starting to look like resctrl_val_param->mongrp is not necessary.

Reinette