Received-SPF: pass (google.com: domain of linux-kernel+bounces-158003-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f865d91b-5e1f-45e2-9f1a-cf9feb8c9c59@intel.com>
Date: Wed, 24 Apr 2024 21:46:20 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 00/16] selftests/resctrl: resctrl_val() related
 cleanups & improvements
To: Shuah Khan <skhan@linuxfoundation.org>, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?=
	<ilpo.jarvinen@linux.intel.com>, <linux-kselftest@vger.kernel.org>, "Shuah
 Khan" <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
	=?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, <linux-kernel@vger.kernel.org>
References: <20240408163247.3224-1-ilpo.jarvinen@linux.intel.com>
 <cc46c002-c771-499d-96f7-38db978ae975@linuxfoundation.org>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <cc46c002-c771-499d-96f7-38db978ae975@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlFYUXplWmxHYkNuajlXbmxjWmJKVi9EcTQ0TDFVNEZnV3ZRVnU1emFmU1Z6?=
 =?utf-8?B?dkJkZWVqR2VOTVBKTjJqQTNadGRoUG9zRUlkSzVrc09qaHp2aTdGdTdFMGlV?=
 =?utf-8?B?elAvcG1ha3NWcEx1cjVQaU9WMlFLdnhsRnFKK3p2dlVvYlZNZDdkSU1JOFA5?=
 =?utf-8?B?NWFJaVA4c1RmQk9VR0N0QWFNS2xiVEphTFdZMVRHQ0FRcEdZRjJHa01Md1NR?=
 =?utf-8?B?ZTNzcWNZYlF3RU8xNHZmamc1Tzl4Wk1QSVNqWHRaQUxXTUhZY2l2eUFMd0Mv?=
 =?utf-8?B?cmZlSUpldmhuU3Frc1U1R3BrOCsxZmdNUElYT05nTnVua2JJbEJRTTd0dkRr?=
 =?utf-8?B?MmlBdUM4Z1hYd0Fqc1FKTXVnZFBEenB4S3VBcnJaZ1F3Q2h5bUQ5ODlaK3NU?=
 =?utf-8?B?blluOXZGemN2azA4TnZGMlY1VjRLeG1wSGNuY0JSZXpjRklBU2o4MTlsZDUw?=
 =?utf-8?B?Y2RBc2dHdFlnYmJnd2ppVUdmQWZGMVUybDFjdkVtbi80cWczTUJRalZUUlBk?=
 =?utf-8?B?TWlCc0ttRUhLQWs3QWdUbm5sVndQMjJBdkNRZ0dybjNvMHZwK3JVWE5zdjFP?=
 =?utf-8?B?eUtzNzljUnBPa3p3aWNMZWNFcHM5ajBMOElaQVF3YS9CclBTVnhSSHV0clQz?=
 =?utf-8?B?cjFZU0ZxZTRuYVRFY0tNUjVoYkxBaFBIMXhPSHNwVlpXV2pLY2hRV2VwVmZw?=
 =?utf-8?B?MGZHOENweVduYUQ0dU9ENXc3bERYUzJoRkN6MEUyb2p2Z2lSWFpiN2E2dGg0?=
 =?utf-8?B?clZtMXIrblJYNVJlWWJhNUFBRXhScnNBVXJqS0M4NzJiSElsTlNCVFRmM0w5?=
 =?utf-8?B?SUwrakRhQjN2REtVbEhDTHpubWxZY0JnTDZ1dytJVElEcG1tM1JBcHpGYjhE?=
 =?utf-8?B?bElEY0R4SzRsRzF0MEtjM0Ixamdqb2ZYclYvNkVOSzlZUnU2UXI3cFl6U0hG?=
 =?utf-8?B?THNjQnJIRzdwbHE1MXdnT09lQTVydDduVlorTHl1NkRzVFp6c05IaDBWZEFT?=
 =?utf-8?B?ckR5NjYwRG0vSFZEdHdzdHh3QlZYQXZZaVdqeHhaNG5yOUw4TVllMGxFN1pk?=
 =?utf-8?B?S09jQUhGZGdCT0hRQUF0Mi9MMU12ZVZEbFJMNDRtT2oySkVqUkpYM0xoZ2F1?=
 =?utf-8?B?dnBDQlYrZFEramMweCtXY3Joa2FuZ3cxeDhrc3gwM25UVy9QMDhUcUw3Ym1x?=
 =?utf-8?B?YTFPcjBqcDhna3hSa2YrNndoT1RpT0pSTllZL2hvQlRtdTlxT2Z6Z0pVb2Rl?=
 =?utf-8?B?V2w1dFdZRVRLbjgzYnNSOHl3SExWM09CdU9zd2xhOWpwSFB1VkFOZDBsOE43?=
 =?utf-8?B?UjNhSGFQL29jbmh4U2dON24vT2owMEFJZWtDK2dsOEJTa3NzU0tnWjY5dS9M?=
 =?utf-8?B?bXBKY0p0cTM1MkNWdDE3T0pHQnpWeGtocTE5UTg1TW03cU9QejBiQThXaWJs?=
 =?utf-8?B?aGtZejhucjU1SmJSeTFLRHNBQ3B6cUZGT0JRWURsZHpzOUpYUEJ4cUJ3MXE3?=
 =?utf-8?B?SWxWejkvdE1aTGhJdm9XbEN0dytDYnUxSm5CMUtEenVFOXhTNUc1ZlRjaWYx?=
 =?utf-8?B?TCtDRGVhSHk5ZXk2SWdUMmV1SXNzcTFtVnpsaTQ2ckhtUE9od1ViY05CVDJU?=
 =?utf-8?B?cWlCMVJSZFg0VHAvYzZacEJ0RElvUDlOMkU0VVRjQ05JMTFlcVE5U2FPdXFy?=
 =?utf-8?B?M1V0UEVxZzFZRWVrQjBPQWhxMHFIOEhIK0VQc25UWmphcnF0U0tUekUzRzhI?=
 =?utf-8?B?SWR2UVo5bm96V3hBamxiWHJmeGlOaUQrdkFHUFRlOUJhRmNGWE4wQ2QyUDFF?=
 =?utf-8?B?VWJZSFdoaStPc09iWCtFdmNreFcrUGl3V3IzMEs5MlcxTFNjK0RzMWtVcE5P?=
 =?utf-8?B?Rm43aHI1M2VWN1BLRDZzYWpnNkRRdTB5TVhYWkkzN0luUkpPYTRrZkVYYXFl?=
 =?utf-8?B?UHV6eU4xaGxNelpqS0o4RC9NVUxoS0NGL3pFSkNwa29ta0FPcmFySnVGQVAv?=
 =?utf-8?B?S1hvbHBEL3Z5bE9NWnBBOG1yUVEvMjgwa2NsL2VaQlpraHVDZFFjaExjSXpi?=
 =?utf-8?B?YXh6N0MwbmplejYwejFUUFp2bEVmSTJwN2lkVkloNXlOam9hTk5IcHUzV3Bn?=
 =?utf-8?B?WTd3NSt1NVdWM3h0U3lEMEtjaWJJaGVVenlVR2JQb2dseXRqdGxUaEc0ZkRQ?=
 =?utf-8?B?VlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a24314d8-5c7b-48b1-922d-08dc64e2a855
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 04:46:23.0648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6m/rL0pXpxiDzJfphDzJVGVm5n12cZCWrcgXwttvFlbi3871B1LSf8yEp4mtLl0py6381OlFLKbiZp4OjgSioZA2V4POpS3RxjJdG3TTwng=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5940
X-OriginatorOrg: intel.com

Hi Shuah and Ilpo,

On 4/24/2024 6:49 AM, Shuah Khan wrote:
> On 4/8/24 10:32, Ilpo Järvinen wrote:
>> Hi all,
>>
>> This series does a number of cleanups into resctrl_val() and
>> generalizes it by removing test name specific handling from the
>> function.
>>
>> One of the changes improves MBA/MBM measurement by narrowing down the
>> period the resctrl FS derived memory bandwidth numbers are measured
>> over. My feel is it didn't cause noticeable difference into the numbers
>> because they're generally good anyway except for the small number of
>> outliers. To see the impact on outliers, I'd need to setup a test to
>> run large number of replications and do a statistical analysis, which
>> I've not spent my time on. Even without the statistical analysis, the
>> new way to measure seems obviously better and makes sense even if I
>> cannot see a major improvement with the setup I'm using.
>>
>> This series has some conflicts with SNC series from Maciej (Maciej has
>> privately agreed to base his series on top of this series) and also
>> with the MBA/MBM series from Babu.
>>
>> -- 
>>   i.
>>
>> v3:
>> - Rename init functions to <testname>_init()
>> - Replace for loops with READ+WRITE statements for clarity
>> - Don't drop Return: entry from perf_open_imc_mem_bw() func comment
>> - New patch: Fix closing of IMC fds in case of error
>> - New patch: Make "bandwidth" consistent in comments & prints
>> - New patch: Simplify mem bandwidth file code
>> - Remove wrong comment
>> - Changed grp_name check to return -1 on fail (internal sanity check)
>>
> 
> I can apply these for Linux 6.10-rc1 once I get an Ack from Reinette.
> 

Apologies for the delay in reviewing this. I've now provided feedback for
consideration.

Reinette