Received-SPF: pass (google.com: domain of linux-kernel+bounces-158011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Apr 2024 10:37:21 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Portia Stephens <portia.stephens@canonical.com>
Cc: mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	rafael@kernel.org, florian.fainelli@broadcom.com,
	abelova@astralinux.ru, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	stephensportia@gmail.com
Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: ISO C90 forbids mixed
 declarations
Message-ID: <20240425050721.vks2bq7gqwl2gfpe@vireshk-i7>
References: <20240424050220.889814-1-portia.stephens@canonical.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240424050220.889814-1-portia.stephens@canonical.com>

On 24-04-24, 15:02, Portia Stephens wrote:
> There is a compile warning because a NULL pointer check was added before
> a struct was declared. This moves the NULL pointer check to after the
> struct is delcared and moves the struct assignment to after the NULL

            declared

> pointer check.
> 
> Fixes: f661017e6d32 ("cpufreq: brcmstb-avs-cpufreq: add check for cpufreq_cpu_get's return value")
> 
> Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
> ---
>  drivers/cpufreq/brcmstb-avs-cpufreq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied. Thanks.

-- 
viresh