Received-SPF: pass (google.com: domain of linux-kernel+bounces-158022-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Bharat Bhushan <bbhushan2@marvell.com>
To: Dongsheng Yang <dongsheng.yang@easystack.cn>,
        "dan.j.williams@intel.com"
	<dan.j.williams@intel.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>
CC: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        Dongsheng Yang
	<dongsheng.yang.linux@gmail.com>
Subject: RE: [EXTERNAL] [PATCH 7/7] cbd: add related sysfs files in transport
 register
Thread-Topic: [EXTERNAL] [PATCH 7/7] cbd: add related sysfs files in transport
 register
Thread-Index: AQHalIXaD9AgiEKpPUChgALPnXDFErF4d/KA
Date: Thu, 25 Apr 2024 05:24:46 +0000
Message-ID: 
 <SN7PR18MB5314D1E502937E34BC5AC823E3172@SN7PR18MB5314.namprd18.prod.outlook.com>
References: <20240422071606.52637-1-dongsheng.yang@easystack.cn>
 <20240422071606.52637-8-dongsheng.yang@easystack.cn>
In-Reply-To: <20240422071606.52637-8-dongsheng.yang@easystack.cn>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?cOCuokxpRnwjieVrLZUTWeiZf1IP15z2XnCTF9cUopliGqL2H5DPuNWmzeeh?=
 =?us-ascii?Q?UegtPJ9jwCPO3KUZ9xuDmlSa/kZXDb/DmnChUbp5OThq2VlPWLHXc67JZJP9?=
 =?us-ascii?Q?1c4Hl28JQMCv9MrfV8xOQ/rbXkvaq+YvFLMuea12VkOJVRgsptc3XeMLvNJA?=
 =?us-ascii?Q?tAedj+qaDk1JYks8C1TTfWKoiS29tKa3iu/vjmEMXJUNs91KMxw5uIJstIc5?=
 =?us-ascii?Q?uM5dBOy8Kk9yjJKbHs0KtyQ/mUUpMMtIpyCVqQnAt3u1s/729AspNFr65/vr?=
 =?us-ascii?Q?IifMIW2JhrGRVUZigIp7pHfCW5YtBLgAi3zWB5LyVmp1cXTktCqFkkkFl0Br?=
 =?us-ascii?Q?He1idQw3+GZVvExMAORZyhaFFHJwnNefHMXUoB95y3XWF8YAMtKsKhXRkt9z?=
 =?us-ascii?Q?Y6cPuK53hyTwhQRnpbzzRQJC6eaBRFccZlDtbTrtnUAIp7Vr1pXMx5OTe5Lu?=
 =?us-ascii?Q?sRhv6gKUY4E3//z57yWePgpgi3d9zvwfey6C0CpXnSfw/uqkN/rw1dzuESzu?=
 =?us-ascii?Q?zcAM9cdd5+emlKZjDrTeSJL8faCpkvZGjRzoDyQUUXgK2FHyaKi4saDJt1SD?=
 =?us-ascii?Q?cjo57JhVC+jnuffNot40OrVuIOHFE2fyekvKoxx4ROmSs0PfxjlMsy+l33a8?=
 =?us-ascii?Q?j12BMI5cwN76l91G8kdzOoh830SEU1du8gc00+/dtPsLNVrxE6LxmNKSzA+1?=
 =?us-ascii?Q?L89Da+bbWMTmfhsUKj6lOKnzA0BsZpJ+5ehsbEGjubxhudVBwiFk/JDhGqcJ?=
 =?us-ascii?Q?7f4h5gnCyMRvD76Icc2ZCdQONfNx94dG3bq5fucMED3tGjYNmCFJkBB8sdLh?=
 =?us-ascii?Q?IqRsjY6s27Ir0p21MqaCfhH3l8PDocAyV3nPge0l7fOan/5AzmfGnvQEaaTN?=
 =?us-ascii?Q?bNjHXfAlICORkV0C8Dk9qQvI4SUIMhghTgmwSG6eMTEmTKAZzkkK14EjS9lY?=
 =?us-ascii?Q?k5DJEikb3W21P2klkBNttA5oVofpoF2997izxl5PLP9XevfhP/nPjs41GbCn?=
 =?us-ascii?Q?B/YSsNV5M/0lIqrwSOIFazHYDVVAdvQpEwI8H0MSq4zVQkAuxxcF0P4JSKgn?=
 =?us-ascii?Q?fGOdKUMq1tncN9j02EfpA2LGW8U0EZBVR72CZgzNvOdqMHTiLgiKkQrAq+56?=
 =?us-ascii?Q?hW80hRlJgGjIF0cQCQd9NiSPEsJJ9jg9zfcgqKK0oIYi2/btl9j8xxSBtUCc?=
 =?us-ascii?Q?H+UAEB5nw0fAy3OtRmaggYXPLRZmuTHq1o4HSXzsn+xz6nLm3rOdELV6HfMZ?=
 =?us-ascii?Q?gYeRFAz8fuWey3Qg9ItBO5lDxNC92EYUMlD6Y0xXK0n9irwCnjxFTktLIelJ?=
 =?us-ascii?Q?/eRRSajUJFhUbsvOTq/u1g+jvvQdV8NroU+UJw9pQUu6JP/z+qsQGTu7mXmc?=
 =?us-ascii?Q?h6kk/Pt2vfxg2tQcziH+92lGZoiSZcc2gq9dKseAhTFAlbLXtBeZoJEqsSd/?=
 =?us-ascii?Q?J/6XNucBQ/vXcX+6+SGIDHYa9MPGqH7+QacsiZFKvmUk5aqYjLDFRSj8kSra?=
 =?us-ascii?Q?NKLalcvAFQ/KGl78smenjf7NmwZvbrF1/zKoJu0AYmCtAlx8AJ9eKS5ZcMHF?=
 =?us-ascii?Q?x/SKiu6W+ptkjJuaH+HadixZ0Ulbwnsdj4a46x8m?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR18MB5314.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0855d36-d10c-4846-fcfb-08dc64e805ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2024 05:24:46.9706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S2Ok8mEQwTHfeWqamMuG/mqODrbsxlzYMUIT+0pOR6bhUGejJmqwThqXZ9CIHKDSUqNDgM0QMinzBSJCJ6YV0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5857
X-Proofpoint-GUID: W7NYICw2eyEoaU4zDAobUrIiu8WQxo0Q
X-Proofpoint-ORIG-GUID: W7NYICw2eyEoaU4zDAobUrIiu8WQxo0Q
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-25_04,2024-04-24_01,2023-05-22_02


> -----Original Message-----
> From: Dongsheng Yang <dongsheng.yang@easystack.cn>
> Sent: Monday, April 22, 2024 12:46 PM
> To: dan.j.williams@intel.com; axboe@kernel.dk
> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> cxl@vger.kernel.org; Dongsheng Yang <dongsheng.yang.linux@gmail.com>
> Subject: [EXTERNAL] [PATCH 7/7] cbd: add related sysfs files in transport
> register
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y
> before clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> From: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
>=20
> When a transport is registered, a corresponding file is created for each
> area within the transport in the sysfs, including "cbd_hosts",
> "cbd_backends", "cbd_blkdevs", and "cbd_channels".
>=20
> Through these sysfs files, we can examine the information of each entity
> and thereby understand the relationships between them. This allows us to
> further understand the current operational status of the transport.
>=20
> For example, by examining "cbd_hosts", we can find all the hosts
> currently using the transport. We can also determine which host each
> backend is running on by looking at the "host_id" in "cbd_backends".
> Similarly, by examining "cbd_blkdevs", we can determine which host each
> blkdev is running on, and through the "mapped_id", we can know the name
> of the cbd device to which the blkdev is mapped. Additionally, by
> looking at "cbd_channels", we can determine which blkdev and backend are
> connected through each channel by examining the "blkdev_id" and
> "backend_id".
>=20
> Signed-off-by: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
> ---
>  drivers/block/cbd/cbd_transport.c | 101
> +++++++++++++++++++++++++++++-
>  1 file changed, 100 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/block/cbd/cbd_transport.c
> b/drivers/block/cbd/cbd_transport.c
> index 75b9d34218fc..0e917d72b209 100644
> --- a/drivers/block/cbd/cbd_transport.c
> +++ b/drivers/block/cbd/cbd_transport.c
> @@ -1,8 +1,91 @@
>  #include <linux/pfn_t.h>
> -
>  #include "cbd_internal.h"
>=20
>  #define CBDT_OBJ(OBJ, OBJ_SIZE)
> 		\
> +extern struct device_type cbd_##OBJ##_type;
> 	\
> +extern struct device_type cbd_##OBJ##s_type;
> 	\
> +
> 	\
> +static int cbd_##OBJ##s_init(struct cbd_transport *cbdt)
> 	\
> +{
> 	\
> +	struct cbd_##OBJ##s_device *devs;
> 	\
> +	struct cbd_##OBJ##_device *cbd_dev;
> 	\
> +	struct device *dev;
> 	\
> +	int i;
> 	\
> +	int ret;								\
> +
> 	\
> +	u32 memsize =3D struct_size(devs, OBJ##_devs,
> 	\
> +			cbdt->transport_info->OBJ##_num);
> 	\
> +	devs =3D kzalloc(memsize, GFP_KERNEL);
> 	\
> +	if (!devs) {
> 	\
> +	    return -ENOMEM;
> 	\
> +	}

Do not need "{ } " here=20

> 	\
> +
> 	\
> +	dev =3D &devs->OBJ##s_dev;
> 	\
> +	device_initialize(dev);
> 	\
> +	device_set_pm_not_required(dev);
> 	\
> +	dev_set_name(dev, "cbd_" #OBJ "s");
> 	\
> +	dev->parent =3D &cbdt->device;
> 	\
> +	dev->type =3D &cbd_##OBJ##s_type;
> 		\
> +	ret =3D device_add(dev);
> 	\
> +	if (ret) {								\
> +		goto devs_free;
> 	\
> +	}

Do not need "{ } " here

Thanks
-Bharat

> 	\
> +
> 	\
> +	for (i =3D 0; i < cbdt->transport_info->OBJ##_num; i++) {
> 	\
> +		cbd_dev =3D &devs->OBJ##_devs[i];
> 		\
> +		dev =3D &cbd_dev->dev;
> 	\
> +
> 	\
> +		cbd_dev->cbdt =3D cbdt;
> 	\
> +		cbd_dev->OBJ##_info =3D cbdt_get_##OBJ##_info(cbdt, i);
> 		\
> +		device_initialize(dev);
> 	\
> +		device_set_pm_not_required(dev);
> 	\
> +		dev_set_name(dev, #OBJ "%u", i);
> 	\
> +		dev->parent =3D &devs->OBJ##s_dev;
> 	\
> +		dev->type =3D &cbd_##OBJ##_type;
> 		\
> +
> 	\
> +		ret =3D device_add(dev);
> 	\
> +		if (ret) {							\
> +			i--;
> 	\
> +			goto del_device;
> 	\
> +		}
> 	\
> +	}
> 	\
> +	cbdt->cbd_##OBJ##s_dev =3D devs;
> 		\
> +
> 	\
> +    	return 0;
> 	\
> +del_device:
> 	\
> +	for (; i >=3D 0; i--) {
> 	\
> +		cbd_dev =3D &devs->OBJ##_devs[i];
> 		\
> +		dev =3D &cbd_dev->dev;
> 	\
> +		device_del(dev);
> 	\
> +	}
> 	\
> +devs_free:
> 	\
> +	kfree(devs);
> 	\
> +	return ret;
> 	\
> +}
> 	\
> +
> 	\
> +static void cbd_##OBJ##s_exit(struct cbd_transport *cbdt)
> 	\
> +{
> 	\
> +	struct cbd_##OBJ##s_device *devs =3D cbdt->cbd_##OBJ##s_dev;
> 	\
> +	struct device *dev;
> 	\
> +	int i;
> 	\
> +
> 	\
> +	if (!devs)
> 	\
> +		return;
> 	\
> +
> 	\
> +	for (i =3D 0; i < cbdt->transport_info->OBJ##_num; i++) {
> 	\
> +		struct cbd_##OBJ##_device *cbd_dev =3D &devs-
> >OBJ##_devs[i];	\
> +		dev =3D &cbd_dev->dev;
> 	\
> +
> 	\
> +		device_del(dev);
> 	\
> +	}
> 	\
> +
> 	\
> +	device_del(&devs->OBJ##s_dev);
> 		\
> +
> 	\
> +	kfree(devs);
> 	\
> +	cbdt->cbd_##OBJ##s_dev =3D NULL;
> 		\
> +
> 	\
> +	return;
> 	\
> +}
> 	\
>=20
> 	\
>  static inline struct cbd_##OBJ##_info
> 	\
>  *__get_##OBJ##_info(struct cbd_transport *cbdt, u32 id)
> 		\
> @@ -588,6 +671,11 @@ int cbdt_unregister(u32 tid)
>  	}
>  	mutex_unlock(&cbdt->lock);
>=20
> +	cbd_blkdevs_exit(cbdt);
> +	cbd_channels_exit(cbdt);
> +	cbd_backends_exit(cbdt);
> +	cbd_hosts_exit(cbdt);
> +
>  	cbd_host_unregister(cbdt);
>  	device_unregister(&cbdt->device);
>  	cbdt_dax_release(cbdt);
> @@ -647,9 +735,20 @@ int cbdt_register(struct cbdt_register_options
> *opts)
>  		goto dev_unregister;
>  	}
>=20
> +	if (cbd_hosts_init(cbdt) || cbd_backends_init(cbdt) ||
> +	    cbd_channels_init(cbdt) || cbd_blkdevs_init(cbdt)) {
> +		ret =3D -ENOMEM;
> +		goto devs_exit;
> +	}
> +
>  	return 0;
>=20
>  devs_exit:
> +	cbd_blkdevs_exit(cbdt);
> +	cbd_channels_exit(cbdt);
> +	cbd_backends_exit(cbdt);
> +	cbd_hosts_exit(cbdt);
> +
>  	cbd_host_unregister(cbdt);
>  dev_unregister:
>  	device_unregister(&cbdt->device);
> --
> 2.34.1
>=20