Received-SPF: pass (google.com: domain of linux-kernel+bounces-158023-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240424135148.30422-1-ioworker0@gmail.com> <20240424135148.30422-3-ioworker0@gmail.com>
 <0534d647-0753-4c34-943c-e705db1fbddd@arm.com>
In-Reply-To: <0534d647-0753-4c34-943c-e705db1fbddd@arm.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Thu, 25 Apr 2024 13:26:11 +0800
Message-ID: <CAK1f24m+k+UpRnq8hP6u4uyLOkGZMt8MtX+k3fS=OTDqdA85uw@mail.gmail.com>
Subject: Re: [PATCH 2/2] mm: add docs for per-order mTHP split counters
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: akpm@linux-foundation.org, 21cnbao@gmail.com, david@redhat.com, 
	baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Ryan,

Thanks for taking time to review!

On Wed, Apr 24, 2024 at 11:34=E2=80=AFPM Ryan Roberts <ryan.roberts@arm.com=
> wrote:
>
> On 24/04/2024 14:51, Lance Yang wrote:
> > This commit introduces documentation for mTHP split counters in
> > transhuge.rst.
> >
> > Signed-off-by: Lance Yang <ioworker0@gmail.com>
> > ---
> >  Documentation/admin-guide/mm/transhuge.rst | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation=
/admin-guide/mm/transhuge.rst
> > index f82300b9193f..35d574a531c8 100644
> > --- a/Documentation/admin-guide/mm/transhuge.rst
> > +++ b/Documentation/admin-guide/mm/transhuge.rst
> > @@ -475,6 +475,22 @@ anon_swpout_fallback
> >       Usually because failed to allocate some continuous swap space
> >       for the huge page.
> >
> > +split_page
> > +     is incremented every time a huge page is split into base
>
> perhaps "...successfully split into base..." to make it clear that this i=
s only
> incremented on success.

Yep. Your suggestion does make it clearer.

>
> > +     pages. This can happen for a variety of reasons but a common
> > +     reason is that a huge page is old and is being reclaimed.
> > +     This action implies splitting all PMD/PTE mapped with the huge pa=
ge.
>
> What does it mean to "split all PTE"? It's already at its smallest granul=
arity.
> Perhaps "This action implies splitting any block mappings into PTEs."?

Nice. It would be clearer and better!

Thanks again for the suggestions!
Lance

>
> > +
> > +split_page_failed
> > +     is incremented if kernel fails to split huge
> > +     page. This can happen if the page was pinned by somebody.
> > +
> > +deferred_split_page
> > +     is incremented when a huge page is put onto split
> > +     queue. This happens when a huge page is partially unmapped and
> > +     splitting it would free up some memory. Pages on split queue are
> > +     going to be split under memory pressure.
> > +
> >  As the system ages, allocating huge pages may be expensive as the
> >  system uses memory compaction to copy data around memory to free a
> >  huge page for use. There are some counters in ``/proc/vmstat`` to help
>