Received-SPF: pass (google.com: domain of linux-kernel+bounces-158041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
To: Jiri Pirko <jiri@resnulli.us>, Geethasowjanya Akula <gakula@marvell.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: Re: [net-next PATCH v2 5/9] octeontx2-af: Add packet path between
 representor and VF
Thread-Topic: [net-next PATCH v2 5/9] octeontx2-af: Add packet path between
 representor and VF
Thread-Index: AQHaltYOAVZUsaVMhUStY+HonACP/Q==
Date: Thu, 25 Apr 2024 06:01:47 +0000
Message-ID: 
 <BY3PR18MB47379134443CB002D80A7F90C6172@BY3PR18MB4737.namprd18.prod.outlook.com>
References: <20240422095401.14245-1-gakula@marvell.com>
 <20240422095401.14245-6-gakula@marvell.com> <Ziey7sruZrtq_5Hj@nanopsycho>
In-Reply-To: <Ziey7sruZrtq_5Hj@nanopsycho>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?0mGL7JjOfPmt1fZ2thrhnJih7D6XR2px6HrUnQ3ULnTB5+xF0tMiwo6iiX7U?=
 =?us-ascii?Q?+5PKvfNVqCYrVHPL1L5KaabE58C3uDHFV+P9A2EDZksrvFCDsx/LhOA0c5Nx?=
 =?us-ascii?Q?TGuEAHMPcHxzgJ2eSV6/SX4L1hP6eDp6RZHVxGU36osgRUqUWvgPmIVQjo+g?=
 =?us-ascii?Q?p14z8n4yxvb7wwt96z7kKswI80LwJnGLFQBkEX22jhiZ2wjuIuKcyjCbazt6?=
 =?us-ascii?Q?Hvb000kxlrW9kohlcbChTGDxIrlSsbFahdp3ZE9I8QNQgO1jeIqM6yREGqqe?=
 =?us-ascii?Q?K5ljZO9XFEor9sSYNsYSJEDMAs9cKk/o/ekOwayormiSlBI8SasQQKqNeFNQ?=
 =?us-ascii?Q?CBJaq0SjLBodzdJzROYX8QOPvujrL5Af9yw/buTP1OqvJYV/qEwJfwgIBl9K?=
 =?us-ascii?Q?V4iKQ5KkUWn+NwWJ1NI5LjHAJMWUuXhKhAVNYzpPY9+zdNa0BpdgHm45lXPn?=
 =?us-ascii?Q?3UiPTyRE8OtCODPSA7CEBhZZUewWDJDQrAuHmZFCToT+uwuH0s97e7hyfzVf?=
 =?us-ascii?Q?WcUol0hhCSBKuq9612/lUpJGSZXlBo9NdN92U4+6t6BmFZmZ6T7yI8mRqekX?=
 =?us-ascii?Q?DowRVT4BhNcKaveZg4q5zoKoYXmM6ziB5m405+jyUfvOp0giN7yrUW1O+f/T?=
 =?us-ascii?Q?goMFYD5IMxVRx2BLI5b7ZV0fzO8Dkt3hMy1jeT8kUjipdJiF1JxH+l5Uyoty?=
 =?us-ascii?Q?Gt1AyrdMIY8kGPJbQDhkXjESoFHPYcPY05qpTO9PbLo8hy+fJaOkiyRxpu+1?=
 =?us-ascii?Q?UDdWshI2DW1kIWM93KD98ZfpAYip9fWv32kBZjknFlzeHaN4e287J8ajRyq4?=
 =?us-ascii?Q?UVvKDRu3btyz/JWfgF81p66mICiZ0/pr98lro2s3p9DC9dkpNJAfr31kcarP?=
 =?us-ascii?Q?2W2szJvz/4/gKzQoX40luNhF8aeANOHwxHi+k1Ccv7lyG25HjgvLn9pl42gu?=
 =?us-ascii?Q?Zp/oOZrjsRQjQAVvvI6uDQamysvJzG12Ti0ZdVYdWQV8IWxGMmGU0zDgVYRX?=
 =?us-ascii?Q?hdyMkTsbpgsd0b7NtIeDsxMA+sRc4SBrAVg/KcIfcSx1wahQdVj2F+whxzVG?=
 =?us-ascii?Q?lgF5yKn1Fm0uU3JA+K4OC04FkjGp15BsFlsXxYeqQQDMjn1R+htjO6T6aL1N?=
 =?us-ascii?Q?8G/goIg0+XorJ4xBOhjDkyySeZ3zx+Inpd+6H6iuZ2oPacS5JOTkN7EYnLCh?=
 =?us-ascii?Q?DwYdYABf7Vdxkia0JV/Mhcmve2MFunet+KveFrKyocRdLiZf7Ps4M70TS4Ps?=
 =?us-ascii?Q?tIBEI/Lcbpqk5CVETdQ543lqtZcN0IhJP6Lzgq/yt5C1H0A7dtsAJ7/Au/V5?=
 =?us-ascii?Q?UbVZpbo5htEIP50W2Op6my3Y+otjE4p6tT4mgfQggl/4w+cKuviOYdmR0xtz?=
 =?us-ascii?Q?PTmt6hwOqV2P7eUykAps5F6YfQ0lK0xi6UWkmocXUh8YdepzRkIbmrbMI6pV?=
 =?us-ascii?Q?NzWZ7AVchEtJ/T5PLCvY4XYR1qy6mW3InvGw8lqgpoNxkZU4vnIOPpm34nUg?=
 =?us-ascii?Q?wCZeeCohTq2TkTo00dbN3sRoFkfdUcxmvtcucQKaqNEpvqUzVnS0tygKuSLa?=
 =?us-ascii?Q?k6PbqliAWPs3hT8CCx8KgLH9Mb/phxEaDd1IeSEQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4737.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85079c2a-f059-4c11-2d09-08dc64ed3103
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2024 06:01:47.2040
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Utz+T0PrTPk4aCt1676FqZ1hdDMZnBtZn9PvzNFF2HD2tmrj/CMonTOKWH6qD+28OFcr7s8B0QG41CO6+h3w2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR18MB4594
X-Proofpoint-GUID: iKAlSLErPUlOc52tBEfA1zgeJOITMGtS
X-Proofpoint-ORIG-GUID: iKAlSLErPUlOc52tBEfA1zgeJOITMGtS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-25_04,2024-04-25_01,2023-05-22_02


> -----Original Message-----
> From: Jiri Pirko <jiri@resnulli.us>
> Sent: Tuesday, April 23, 2024 6:39 PM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org=
;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXTERNAL] Re: [net-next PATCH v2 5/9] octeontx2-af: Add packet
> path between representor and VF
>=20
> Mon, Apr 22, 2024 at 11:53:57AM CEST, gakula@marvell.com wrote:
> >This patch installs tcam rules to stree traffic representors and VF
> >when swicthdev mode is set. To support this a HW loopback channel is
> >reserved. Through this channel packet are routed between representor
> >and VFs. "ESW_CFG" mbox is defined to notify AF for installing rules.
>=20
> This sounds very wrong. In switchdev mode, there is no implicit packet
> forwarding. User configures that, either by setting up TC filters to
> match/forward packets, putting representors in a bridge, etc.
> Basically the driver offloads whatever configuration on representors the =
user
> does, in case it supports it.
>=20
> Please make sure you follow that.

In our HW, there is no in-built switch which will forward pkts between repr=
esentee and representor.
When representor is put under a bridge and pkts needs to be sent to represe=
ntee, then pkts from
representor are sent on a HW internal loopback channel, which again will be=
 punted to ingress
pkt parser. Now the rules that this patch installs are the MCAM filters/rul=
es which will match against
these pkts and forward them to representee.

To be more clear the rules that this patch installs are for basic represent=
or <-=3D> representee path
similar to Tun/TAP between VM and Host. Now for any further offloads (eg: L=
2 or ConnTrk)
user will have to install explicit rules via TC filters.

Thanks,
Sunil.