Received-SPF: pass (google.com: domain of linux-kernel+bounces-158071-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9a9ab302-5da5-47bb-85f1-d2295fa9f8c9@amlogic.com>
Date: Thu, 25 Apr 2024 14:28:27 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 5/5] clk: meson: c3: add c3 clock peripherals
 controller driver
Content-Language: en-US
To: Rob Herring <robh@kernel.org>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Jerome Brunet <jbrunet@baylibre.com>,
 Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
 <sboyd@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Kevin Hilman <khilman@baylibre.com>,
 Chuan Liu <chuan.liu@amlogic.com>
References: <20240424050928.1997820-1-xianwei.zhao@amlogic.com>
 <20240424050928.1997820-6-xianwei.zhao@amlogic.com>
 <20240424200107.GA372179-robh@kernel.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <20240424200107.GA372179-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Sm9zNi80QkNiRjNKdkZWK2NqRGVLais4OGJHd1RUOU8rb2RkZWhMYUJxcld2?=
 =?utf-8?B?SVFkVndqWlB6ei9IN1B2Q0N6L1ZBZDFEYWlIYzhyL2NGMi9hTElkTVloZ2VC?=
 =?utf-8?B?bWljRjdrV2sxNjcwZ3BFQmFtTlE4ZG04NXVCTDRWblF4clduekp4dUpESGZV?=
 =?utf-8?B?YmFJWUZqdkFiNHRWZDdMcURybmV5SW1UL09DZlkrWjEwakFxdmpQVmhxRGNj?=
 =?utf-8?B?YW5yTHd1ampxd3oyZHdkSVUxdFRRZk1qMFJ3RGJNajBTNlpnd3l4SER5NUtk?=
 =?utf-8?B?SGhkTzBUWHNrbVNoYzBiK2tiajlma1NNQXAzNzRoR0hXUnE1dUMrbkNEUklB?=
 =?utf-8?B?dW05dWJZTERRZ3JhRzZjNDFyblQxNGRFNXFHemJ3QkJrL2VpU3NRbG5hLytS?=
 =?utf-8?B?ZW13Y01xVDNxSVQ5dHhsbmFYYVVCMFpFWmo0Nzdaeks0YTM0dmFHajlDVS9V?=
 =?utf-8?B?aEJLd1YrSTV2NGRqWlNIcG12YWJwSXArZUJZYUU4djY2NjBwRnp2a3FSMitL?=
 =?utf-8?B?dTV2Ums2djZsV2YwNVhScmdVdWFJdkRhc2Z5c2VNd29NR0hWRWFRRVdZM0t2?=
 =?utf-8?B?VFlvY3JDTUFCWHpWVk5MZm1VMHBETUJUckJ3M2FVdzBrU04xdnh3QWNGYjhz?=
 =?utf-8?B?Q0w5QkZpN00vQmhsQzFQdVMvMDVSc2kvNDg5MjRYREtyTjBHVHpENm0yVTRW?=
 =?utf-8?B?eFpUQTJlOXdUNitIdnpHS05MNkhxYVcvVjRocEJVVENwRlF5QTIvTXMyOXJX?=
 =?utf-8?B?bEtNYVhwZHQzZ3QrNDY2cUVsM3YwTkllcXRWSjA1QmZmS2NVeVJhZVBUa0pi?=
 =?utf-8?B?QzFScGd5UnlHbXlxbWFwMi9IYmZMTGpOVS85ZURjeEczbGVOazRUNW9MMGY2?=
 =?utf-8?B?eWI0bklYbUFKeEdIaFZkZEFyVktUdW8rTUZjL0hzK2g4VGc3OE1jNDFZOFg2?=
 =?utf-8?B?Zm1wNFhvWnUrSWcvM29CcHFCU2dPdm1vM2gvTHh4Um8vc2pSQlJ6cHRDalpu?=
 =?utf-8?B?d0ZJQlVMOGpLRTJvSGh3TVJGUndvWjF5OEpYNWJrQ21QRlpCLzBKNHJONjVz?=
 =?utf-8?B?RmRTTHZLQmszWFcrUGVUN1NKNzRITlczOUZJc01VTGY0aUZsY1F0dFNJZFIr?=
 =?utf-8?B?ZENUTzNWNzRLU0ZnOHhsT0c3KzJPL0c2eS9xd1RJMW5Ld3lTNmwvWjJ2WG53?=
 =?utf-8?B?alIvWU5oUWV6WjNpVzRVRnI5Y2JWMFVDdlMyVWIrdkdkb2xIdmhwWUdLa1BQ?=
 =?utf-8?B?RW44RnhkVnIzam4zMSt0NEJOS2U4QmM0b1hyTlhRNkJmZ2ttYkE5MVp3ZVZ0?=
 =?utf-8?B?c01WaURZVW5TQ3cxTERlZzhxR1JVcTYvQjJlMmpjdG1uL1VCLzhsZm0raTNo?=
 =?utf-8?B?Y2N5L0QzWGxqdlpxZHFYSWNlNElTWjl1aHF0M1JyTXZHUEkxcmpHK3V3ZlU1?=
 =?utf-8?B?MmtiVW1oTkpQYjgraXhBTTlleXFTeWRZb0hHMXdsODkrV1lvTTZ6UENZcGxm?=
 =?utf-8?B?T0VwdlI3cTlYUEQvaVIxSUV0VDBHT3ZJT25kZTNlMkhtWkpGK0draFZBSlF6?=
 =?utf-8?B?RlcvdlMzUVllYjRXcGlkemdHdzFrcTFTbnZoWGZRaVk2SWZXcEVWeDkyMldH?=
 =?utf-8?B?MmFBdzBHQ1lkbzJyVnBJb1NCYncrNHFqbWczN254Qm50SjVDKzVNQlBqcllu?=
 =?utf-8?B?b1dFM3JWbEtxbTV3Z0V2STV5TEpkTVlwTlAzOE5ZaFhpOEplUFZQTjYvSEpI?=
 =?utf-8?B?c2QzL2VxU0RDRGJJd0pDbHdGd2Z2bmozYXN2WDY1NVlkNGdhUm8vU0t0NHVw?=
 =?utf-8?B?a3dPQWRjS2N1eGQzUWFvR1lDRkEyL2FxYXRqcThLKzA0Z21HWDB4WjRWbzFP?=
 =?utf-8?B?OXgzS3lVN2dpZDl1aWVRMW93eXJjVzZzaWw1VUZobU5OZVRYV25mcENraE1S?=
 =?utf-8?B?NFF1OGRRWnFFQU8vb1BSeEhnVENacnB5eHlpeWVUMERrKzhBWGJ4QU50RVl1?=
 =?utf-8?B?dmM0K09Eckt4K0RYdE4zaXllSTEweGxHUWN2ZlhzTDRybGRUcFZSQUxabGhI?=
 =?utf-8?B?alduKzVVbkFUSmhnMlVmNnR2dldyV1QyQTJaSUkvWjNBQnlqRVlMNjFmQnFO?=
 =?utf-8?B?S24wSjFvY3F5T09FNXRuYWRBdFVodGR0aGo0VFBlekdQUStHa3E1OVJ4MjFU?=
 =?utf-8?B?ZXc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3016ab3-4aac-40b8-413b-08dc64f0ee3c
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 06:28:33.2668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Dz2r8mZf8JnZLa2IRlRzsPWJPNuZq8er+PYOrCnv93HhayA4uX1dEPmO3KPiCVQJc/aH7oYGmPukxsUOz7hifiLn2e0o/NnpYf88+YMP/w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8639

Hi Rob,
    Thanks for your review.

On 2024/4/25 04:01, Rob Herring wrote:
> [ EXTERNAL EMAIL ]
> 
> On Wed, Apr 24, 2024 at 01:09:28PM +0800, Xianwei Zhao wrote:
>> Add the C3 peripherals clock controller driver in the C3 SoC family.
>>
>> Co-developed-by: Chuan Liu <chuan.liu@amlogic.com>
>> Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   drivers/clk/meson/Kconfig          |   15 +
>>   drivers/clk/meson/Makefile         |    1 +
>>   drivers/clk/meson/c3-peripherals.c | 2366 ++++++++++++++++++++++++++++
>>   3 files changed, 2382 insertions(+)
>>   create mode 100644 drivers/clk/meson/c3-peripherals.c
>>
>> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
>> index 9f975a980581..0b85d584910e 100644
>> --- a/drivers/clk/meson/Kconfig
>> +++ b/drivers/clk/meson/Kconfig
>> @@ -142,6 +142,21 @@ config COMMON_CLK_C3_PLL
>>          AKA C3. Say Y if you want the board to work, because PLLs are the parent
>>          of most peripherals.
>>
>> +config COMMON_CLK_C3_PERIPHERALS
>> +     tristate "Amlogic C3 peripherals clock controller"
>> +     depends on ARM64
>> +     depends on ARM_SCMI_PROTOCOL
> 
> I may have missed it, but I don't see the dependency on SCMI in this
> driver.
> 

Some clock sources for peripherals controller from SCMI module.
In previous version, Jerome suggest us the clock  that relevant 
registers can only be accessed securely is implemented through SCMI.

>> +     depends on COMMON_CLK_SCMI
>> +     depends on COMMON_CLK_C3_PLL
>> +     default y
>> +     select COMMON_CLK_MESON_REGMAP
>> +     select COMMON_CLK_MESON_DUALDIV
>> +     select COMMON_CLK_MESON_CLKC_UTILS
>> +     help
>> +       Support for the Peripherals clock controller on Amlogic C302X and
>> +       C308L devices, AKA C3. Say Y if you want the peripherals clock to
>> +       work.
>> +
>>   config COMMON_CLK_G12A
>>        tristate "G12 and SM1 SoC clock controllers support"
>>        depends on ARM64
>> diff --git a/drivers/clk/meson/Makefile b/drivers/clk/meson/Makefile
>> index 4420af628b31..20ad9482c892 100644
>> --- a/drivers/clk/meson/Makefile
>> +++ b/drivers/clk/meson/Makefile
>> @@ -20,6 +20,7 @@ obj-$(CONFIG_COMMON_CLK_AXG_AUDIO) += axg-audio.o
>>   obj-$(CONFIG_COMMON_CLK_A1_PLL) += a1-pll.o
>>   obj-$(CONFIG_COMMON_CLK_A1_PERIPHERALS) += a1-peripherals.o
>>   obj-$(CONFIG_COMMON_CLK_C3_PLL) += c3-pll.o
>> +obj-$(CONFIG_COMMON_CLK_C3_PERIPHERALS) += c3-peripherals.o
>>   obj-$(CONFIG_COMMON_CLK_GXBB) += gxbb.o gxbb-aoclk.o
>>   obj-$(CONFIG_COMMON_CLK_G12A) += g12a.o g12a-aoclk.o
>>   obj-$(CONFIG_COMMON_CLK_MESON8B) += meson8b.o meson8-ddr.o
>> diff --git a/drivers/clk/meson/c3-peripherals.c b/drivers/clk/meson/c3-peripherals.c
>> new file mode 100644
>> index 000000000000..0f834ced0ee9
>> --- /dev/null
>> +++ b/drivers/clk/meson/c3-peripherals.c
>> @@ -0,0 +1,2366 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Amlogic C3 Peripherals Clock Controller Driver
>> + *
>> + * Copyright (c) 2023 Amlogic, inc.
>> + * Author: Chuan Liu <chuan.liu@amlogic.com>
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/of_device.h>
> 
> I don't think you need this header.
> 

Yes, I will fix it with c3-pll.c.

>> +#include <linux/platform_device.h>
>> +#include "clk-regmap.h"
>> +#include "clk-dualdiv.h"
>> +#include "meson-clkc-utils.h"
>> +#include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h>