Received-SPF: pass (google.com: domain of linux-kernel+bounces-158096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Apr 2024 09:04:18 +0200
From: Jiri Pirko <jiri@resnulli.us>
To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= <ast@fiberby.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Ariel Elior <aelior@marvell.com>,
	Manish Chopra <manishc@marvell.com>
Subject: Re: [PATCH net-next] net: qede: flower: validate control flags
Message-ID: <ZioAchImQ65ck1Ua@nanopsycho>
References: <20240424134250.465904-1-ast@fiberby.net>
 <Zikcq2S90S97h7Z0@nanopsycho>
 <923135c6-1bd1-414d-b574-c201644d35ab@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <923135c6-1bd1-414d-b574-c201644d35ab@fiberby.net>

Wed, Apr 24, 2024 at 06:43:14PM CEST, ast@fiberby.net wrote:
>Hi Jiri,
>
>On 4/24/24 2:52 PM, Jiri Pirko wrote:
>> Wed, Apr 24, 2024 at 03:42:48PM CEST, ast@fiberby.net wrote:
>> > This driver currently doesn't support any flower control flags.
>> > 
>> > Implement check for control flags, such as can be set through
>> > `tc flower ... ip_flags frag`.
>> > 
>> > Since qede_parse_flow_attr() are called by both qede_add_tc_flower_fltr()
>> > and qede_flow_spec_to_rule(), as the latter doesn't having access to
>> > extack, then flow_rule_*_control_flags() can't be used in this driver.
>> 
>> Why? You can pass null.
>
>Ah, I see. I hadn't traced that option down through the defines,
>I incorrectly assumed that NL_SET_ERR_MSG* didn't allow NULL.
>
>Currently thinking about doing v2 in this style:
>
>if (flow_rule_match_has_control_flags(rule, extack)) {
>        if (!extack)
>                DP_NOTICE(edev, "Unsupported match on control.flags");
>        return -EOPNOTSUPP;
>}

Looks ok.

>
>pw-bot: changes-requested
>
>-- 
>Best regards
>Asbj?rn Sloth T?nnesen
>Network Engineer
>Fiberby - AS42541