Received-SPF: pass (google.com: domain of linux-kernel+bounces-158113-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <77b837b8-600a-4ad9-b2f9-ee24450e8c5f@blaize.com>
Date: Thu, 25 Apr 2024 08:18:56 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/7] dt-bindings: clock: Add binding constants for
 BLZP1600
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "linux-arm-kernel@lists.infradead.org"
 <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: James Cowgill <james.cowgill@blaize.com>,
        Matt Redfearn <matthew.redfearn@blaize.com>,
        Neil Jones <neil.jones@blaize.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd
 <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
References: <20240424133241.19210-1-nikolaos.pasaloukos@blaize.com>
 <fd4072dc-7cd3-4d13-a15b-d63c675a5994@linaro.org>
 <c11194fb-0449-4b36-adf1-c15d7a66344d@blaize.com>
 <b9b3ccaf-7ad1-485a-9ee8-9a9922936e79@linaro.org>
Content-Language: en-GB
From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
In-Reply-To: <b9b3ccaf-7ad1-485a-9ee8-9a9922936e79@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eG4vV3BJY3lFemxuZWdBWFl3LzJTWnliRm5XRVF6eFUzUzY1TnJtV29qa1pn?=
 =?utf-8?B?WnJHcndNRFN5cldiZjhQb3d6UC9GN1J2K3FqQ1laTVFuZU1OL042ekhvR25Q?=
 =?utf-8?B?RWZFSEQrM0orK3ZqejA4Y1RhQ3ZJZ3lzQklEOHZveXdLYjZwYTZNLzNnZ3hw?=
 =?utf-8?B?MmlOdktzeUlRaXFGSzV3TUtVMFlrT0NwTEdtQVQ5SG1FclZYaWxtRHoyMFk2?=
 =?utf-8?B?cDNuaVdZSDhiOVFyZkd3RmRzc0hkUWhrdTgyOGVVd2dJSjV6UmNZKzdvQVJ3?=
 =?utf-8?B?VmZma2xVR2kzNWY0aU93aU9lS0tZVHRIRkgycEs4UmhtQmlrOUhhWFVoMkJQ?=
 =?utf-8?B?ek81b0IrdWl0YVFQUTVicmFJbm9xdEU1YmxRU1pMb1pkQ3AwYW5iajdEblBC?=
 =?utf-8?B?STAveDd1aUtra2MrT0ExT2tIMWlvQWI2YkRsdUdXeXZOK2ZQaGhqNW96VjZ2?=
 =?utf-8?B?Tk9oZ0NjK0plcGFkY1dYYlJTSXdodXZOeXdSM1RudExDaC9QdXdsSVF6Y3FZ?=
 =?utf-8?B?YWI2eTdnNFYyV2ZCekFhcFZGUWxzOHd6WktIeldpSnc5U3U0dTdUK1JNUk9s?=
 =?utf-8?B?V0hsMlNGZFNESjh6eDdnU3hMOWRsTVYxMk1JTXYrY0xUbXJmTWl6UmJPWmJW?=
 =?utf-8?B?NC9IWmthUXEyVTR0Q000VzN0K1BhWHI2dEdjdkJoWTNDajNqdjRwcHhhNzRI?=
 =?utf-8?B?dDZ5ZjBEd1c0NjhJUkgwV2FLbUV0UXZRN014ZzlmaTFTNmlaa2Z4U0xwZ3li?=
 =?utf-8?B?ZGplUDYrQW5qMW5WSVp4Q0U2dnNSU2VaemNwaGxNOEkwRlU0OGNtaHpJVXhP?=
 =?utf-8?B?TVcvRys4K0diOFE0MENLcE1lbWxJR3FFVjdiMGdpUTEzWVRqeittVk91Q25X?=
 =?utf-8?B?eTVLdkJ5Wm1oWjB2clduTzUrd0Jxck43bUZmSzRZOXhpOWVTSW5OQlRBYTQy?=
 =?utf-8?B?WG9FZGRUdXBDSGJ0bkJBb0dmQURnMDhuOHRQeGZmSUx5NDZZUy9VcnByN0RP?=
 =?utf-8?B?cFJjSEROcnVvdHp5KzJZbDIwbEMzWjhmMGlnZjhxNHE1S254cVVUTEkxL09P?=
 =?utf-8?B?VHpGZFFZcENxUk9CZDhBMTNzbmlKOCt6WEd2UUZWMmErU2cyQ0hod2sySTg5?=
 =?utf-8?B?dUc3U2NlOWh6M095ZC9SejlWSFZoV3hjdkhBcWFhakxtT1hrVUhtRnZKSWs5?=
 =?utf-8?B?bE85U0NWM2xEVXQvTGJnTkF1SC9xUmx6alVUekg1STZkZ2NPMkpaaHhFNkFM?=
 =?utf-8?B?T1NTU3pvd1RRM3BaaVdVQmtkZk5uUjdKVU1PdkVYb3VwQWpmYmpYUXl5N2xN?=
 =?utf-8?B?UFZXanZTZ3lFakMvbTh6ZkJBcGUyWW13bUdvTkVjMTlYQjM0VnhDb29ncnFP?=
 =?utf-8?B?SHFTWXYvQWVEcTJZYXlKWENXeFlkaVZGQlFRQnI2a2xRcmtrWFBxaGpBNFJp?=
 =?utf-8?B?TTVqSVVxem55Si9VQ1RTcGg1TW42ajlkSXl5VW1HVFBqR09lajFuQ3lVaFV0?=
 =?utf-8?B?bTZsYkN3NEN0c2xCV2VVeXVGZ21vby9tVHA3WUR5aEljN1VTWHd6V0s4cmdX?=
 =?utf-8?B?MzVyUkk5Y29tNzcrdDJ1NlNhK0ZJOXY2MmNIem1GMjBrRFBRQVdsWWhoYjQ0?=
 =?utf-8?B?S2JMYVpXK2IyRHFXckFSSDNtcXVNTTFPL1d6SkxCdmhaNi9kZ00ySWtzZmJB?=
 =?utf-8?B?Nndad3IzVW5sRW5NMG5vbmd1RjVVN2VzYzlHV1YyektJem4vLzN1dmpZTENL?=
 =?utf-8?B?L3JJOEphdWk2ZFdVS1loYnlDaFptRDZuV0VTSWpjMFdqL0szeTcxWWZoNDJF?=
 =?utf-8?B?c2wvbTZJWGNFSkhocGo1TkdhSGtnRkk2WUd4N3Q2bmE4UG84ZERtejlDOGkv?=
 =?utf-8?B?SDZZVXlqRm1KSnJudzhFeFhBUDZvSEZMWmxTOXFzTnpuWGVPZnBYcmxwWVpI?=
 =?utf-8?B?YmowMldCVXZnSmg1aVhoNXJjVmZVcjFtTlhlTW9JWFZsL1RRN3pwUGNCS0RT?=
 =?utf-8?B?bENtNnNNdlgzSTlUaUxyT2hPQ0oxK2FQZWFpRHliaWRBWlMyTndEUVdlL1ov?=
 =?utf-8?B?cHZBNW8zZTFGMmR2V0JZTG04RmxiL1FQWnlFWWJ6T05pdTBaNjVablRTYTNU?=
 =?utf-8?B?TmFieEtlNk40NHVtNW1mdVkzYTZzaDhRcHF5RzN4WHpNWjNONmljOVk5MWNt?=
 =?utf-8?B?Zmczc0d5R0xFNkpBWk5BSzUrT0c0RkZRcmtlU0p4SEIwM2drRjJwT1ptNXV1?=
 =?utf-8?Q?9EabroZmaUMkiIgObn1Db7dgZZ1tjD/zTalFuni7Bg=3D?=
X-OriginatorOrg: blaize.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65848b63-a622-4314-f203-08dc64f7fd06
X-MS-Exchange-CrossTenant-AuthSource: MA0PR01MB10184.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 07:19:04.7537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 9d1c3c89-8615-4064-88a7-bb1a8537c779
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nlAw/5LwgzWnxxhoXYoIpPHD3w19msA2tSn4s46WtP3Bg3GE177jpu1K9WKM5ETZoDx06+upKut4ybh1kIHWxu3sreE42PDfbxK+sAl7HwA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB9336
X-Proofpoint-GUID: 0w7rnmwZF64Fw-pN-EBQHvyskiPKKsBI
X-Proofpoint-ORIG-GUID: 0w7rnmwZF64Fw-pN-EBQHvyskiPKKsBI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-25_06,2024-04-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0
 lowpriorityscore=0 clxscore=1015 bulkscore=0 mlxscore=0 impostorscore=0
 priorityscore=1501 mlxlogscore=808 phishscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.21.0-2404010002
 definitions=main-2404250051

On 25/04/2024 07:56, Krzysztof Kozlowski wrote:
> On 24/04/2024 18:14, Nikolaos Pasaloukos wrote:
>>> No, they cannot be invalid. IDs start from 0 and are incremented by one.
>>> If you have holes, it is not a binding.
>>>
>>> Drop the header or use it properly, so as virtual IDs.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> My intention was to avoid using magic numbers on the DeviceTree. That's why I added them here.
>> Also, we have some custom drivers which we plan to upload and their schemas need those files.
>> The alternative would be to use magic numbers for our clocks and resets.
>>
>> In the commit message and on the header file I have mentioned that these are numbers matching
>> the hardware specification (1 to 1) of the chip not just enums.
>> Some IDs are invalid because of a hardware gap, some others are invalid because the SCMI
>> service will return an error that the number is invalid.
>>
>> Is there another way to prevent the magic numbers in the schemas and device-tree.
>>
>> Thank you very much for your fast and detailed review.
> Bindings describe the interface between DTS and drivers (OS or some sort
> of other software). The purpose of binding headers is to document the
> constants which are used by both, because they are part of that
> interface. Therefore constants are pure abstraction.
>
> Let me rephrase the question: Why you do not have headers for interrupt
> numbers? All addresses? GPIO pin numbers?
>
> Best regards,
> Krzysztof
>
Thank you very much for your feedback Krzysztof, I'll prepare a v3 with proper
threading this time, removing the dt-bindings for the clock & reset.

Best regards,
Niko