Received-SPF: pass (google.com: domain of linux-kernel+bounces-158138-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Apr 2024 09:30:51 +0200
From: Fabio Aiuto <fabio.aiuto@engicam.com>
To: Shawn Guo <shawnguo2@yeah.net>
Cc: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	Mirko Ardinghi <mirko.ardinghi@engicam.com>
Subject: Re: [PATCH v3 2/3] arm64: dts: imx93: add Engicam i.Core MX93 SoM
Message-ID: <ZioGq1/zlRP1o7dj@engicam>
References: <20240419144953.8700-1-fabio.aiuto@engicam.com>
 <20240419144953.8700-3-fabio.aiuto@engicam.com>
 <ZioFaJtxYsUlchfW@dragon>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZioFaJtxYsUlchfW@dragon>

Dear Shawn,

Il Thu, Apr 25, 2024 at 03:25:28PM +0800, Shawn Guo ha scritto:
> On Fri, Apr 19, 2024 at 04:49:52PM +0200, Fabio Aiuto wrote:
<snip>
> > +			MX93_PAD_SD2_DATA3__USDHC2_DATA3        0x130e
> > +			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT	0x51e
> 
> Could you try to align the indents, so that those hex values appear at
> the same column?

thanks for your review, I will send a v5.

kr,

fabio

> 
> Shawn
> 
> > +		>;
> > +	};
> > +
> > +	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> > +		fsl,pins = <
> > +			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e
> > +		>;
> > +	};
> > +};
> > -- 
> > 2.34.1
> > 
>