Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp938700lqd; Thu, 25 Apr 2024 00:51:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU6ekAz/exStEfjSgSXfJrO4IcrIdpT/QYPO/wBq1Zo08zP2SyeOnSzkdOY+oLI660FeGKyIIDXdzQiCdugRZ3sJzR+qZ2BOOA8yZv2hQ== X-Google-Smtp-Source: AGHT+IEe39k2fwZFKTRD1qLBJf+GkYHkcvvmfYGrjRJ1yvayqQHKMK8hmGpvrtpQ91xGWUXyu9Z6 X-Received: by 2002:ac8:5881:0:b0:439:846a:d766 with SMTP id t1-20020ac85881000000b00439846ad766mr3069097qta.3.1714031509086; Thu, 25 Apr 2024 00:51:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714031509; cv=pass; d=google.com; s=arc-20160816; b=a6XRrDmEgZJ0FJJqYc/Sf6MRC68yyxRht4whEkzogQ7rDkQTFEZPhZNWF+xdrHbvWy Rz1z2gnVzlQNjhAK95I7bp+Wszk6suw6+CBaYttUzDmURbFIZNZkbxHBGccHYj3Y26hz exGxo/qhG5qycMOTxhPKve2goLuDq0Y7v6Un5FxetYs7TEDnk0n2Dj5eENVlRhk9y+5h a/HVLLeHJXNOF4prd132YGp3bKN1utSwhtIPyE8R/TsnTvjnb/gz7sTAnupT6nVcMrDE znB2i9jcFWKoYFn5Kb3LPrkH1cSE3bWjZZwWZsFxjSHY80q5sUwFIPM9CU+2HwlrKWuD p+4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=IalwHlFT6sSBOYgqoWx3ZddcL59v2TYDVEDNgoSvy0w=; fh=VU0ZoJdzdRpvkDteti686835hPJoSRwigxofuHlon0I=; b=eP2tt3J90i1hbXUouakip4tuVW7+6B1MsF+M7EI7Ua+1HGiJAxv9SmxomKpoJFe7D+ 73citFXxXhGWYzoVlCoGwT84ra9lROjBgzhsEsHRkeSFiAdeKXCkXtHGlE2INNrtAZCF MeEIG6OjAwxHx9rr/csd/8pOGwPcjIJqxSUN+gKgGcXweCIFSumQak1+OpmN3Ap1Z5rm i+xEfswNI9sV7hBZWd1Z+I8exxKoUKpmc314R7C6e1/pwW9TzIj72jEloW7kuDlHxFWV gQQ8eWJ5q6phEOn84sEXeMqbJhoG3TaEi1v44OPE5JI/TaXg/qn64Fv011vVb5Ejx15C /RlQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=h+zgT3Dq; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-kernel+bounces-158152-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158152-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o7-20020ac85a47000000b0043a3f343827si1403505qta.136.2024.04.25.00.51.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 00:51:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-158152-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=h+zgT3Dq; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-kernel+bounces-158152-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158152-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CD74B1C235C0 for ; Thu, 25 Apr 2024 07:51:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 442296EB76; Thu, 25 Apr 2024 07:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="h+zgT3Dq" Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2394D6D1D7; Thu, 25 Apr 2024 07:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714031488; cv=none; b=dhwAKJeDY8VzIkeZCz5Qfw6WM4KhNw4evwIECkdl9YU5VgoO0H0Za+jOm5SblxEBkbcTPfKb31G7VyHq4uhXUdv/cf6bCYn//Y4GLtigENFZOVWzvk3aBLtBaUoGklFwFCZtwf6wuPuSap4RUIiPIYBTt5fcnyKcMZ2Do9SV8zA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714031488; c=relaxed/simple; bh=E8nqpW5ZzmfZlyFxMTgnUG0S6w7Wm5x7ngIcV+KYTrs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F+Y/TATiWuXPmvcLazlu+9n5VONof9WPThfUhnvUx3kFBwO6rvzIlEgijfRsngWSn4gyrfdnJK7F2bPxQdoUBW8isjpfTl+/nFvptWAZgu8rTvER5eMEgcTbM3w4EosTxcRjFN45ggdm0g0tawZzjmK2Cd0DtY0leEpBBPgWihU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=none smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=h+zgT3Dq; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nbd.name DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IalwHlFT6sSBOYgqoWx3ZddcL59v2TYDVEDNgoSvy0w=; b=h+zgT3DqsdtXGefzg157RtSARo CRH/apCaMvTZJ/qFG/uMw8dVDp5W8aPYvxIa+1HOPXaAzUak4tQU9iqh+EO3Mh2raFGIIqRYn1Wvc mVjfm95ATzwhv+Ohef72DtCFa2ZWhZ7D2PhozT57hB27OomjLeDEqB9j9CzIkIRT0sMM=; Received: from p54ae9c93.dip0.t-ipconnect.de ([84.174.156.147] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1rztsu-007BVh-23; Thu, 25 Apr 2024 09:51:12 +0200 Message-ID: <1bc0ac3d-b18d-4969-a090-6803fa4dd5b4@nbd.name> Date: Thu, 25 Apr 2024 09:51:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/4] net: add support for segmenting TCP fraglist GSO packets To: Willem de Bruijn , netdev@vger.kernel.org, Eric Dumazet , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org References: <20240424180458.56211-1-nbd@nbd.name> <20240424180458.56211-3-nbd@nbd.name> <6629c805d808e_1bd6b029424@willemb.c.googlers.com.notmuch> From: Felix Fietkau Content-Language: en-US Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: <6629c805d808e_1bd6b029424@willemb.c.googlers.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.04.24 05:03, Willem de Bruijn wrote: > Felix Fietkau wrote: >> Preparation for adding TCP fraglist GRO support. It expects packets to be >> combined in a similar way as UDP fraglist GSO packets. >> One difference is the fact that this code assumes that the TCP flags of >> all packets have the same value. This allows simple handling of flags >> mutations. > > Can you clarify this some more? We expect potentially different flags > on first and last packet in a TSO train. With fraglist, the segments > keep their original flags, as the headers are only pulled. When do > segment flags need to be replaced with those of the first segment? Maybe I just misunderstood a comment that Paolo made earlier regarding TCP header mutations. Will review this again and compare with regular TSO. - Felix