Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp944957lqd; Thu, 25 Apr 2024 01:06:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWa94KsmkwyQT6IospWuKXqQX2tAiCHHvXf0d4MvxQ+80qz/oonM2CPHLP7yfighCbffSYIlPonUiyest2mKK+PiP7a9fArWaF/QXX/aw== X-Google-Smtp-Source: AGHT+IH6OT4XsbFGMDms/TIND+GYJ4K+sbfZOvRFrMXU5Pvq8hdLdBOYQGAZuZA/G5INjjv5Y771 X-Received: by 2002:a05:6808:8f1:b0:3c7:f30:ed0f with SMTP id d17-20020a05680808f100b003c70f30ed0fmr5349975oic.34.1714032392279; Thu, 25 Apr 2024 01:06:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714032392; cv=pass; d=google.com; s=arc-20160816; b=zk84cwNcnLbrPAy2dazhcEk0j0ouvfTIW9VyuwFx0i4o9kenFddDaQQBAQBYRBmbtx /5FsjDvwfcwiCTo/prDmPq5D/5qPYviMAZRkCS6u8Kj5/8v2gP9Xl7tizTAOChOijoSF RFISdtkzaVwU5pmRAk1WWSC6glbiYtV7cuZHQTTJa5CUhKm4q64JjyFJoo3EpL6YPkWF pj4PBpr78uUsCnaVhZwqlIYGqbR1s8e2cyo7tbMXEWI6mqpsv1TVgcJPTTsdNA2OyQNs jvMSmoW8Yx/t9PTsJcvqePsB5ct9kEdBRJsKzWZ7DeB7ULUsESCwlZ2sztbsGHJGra+w BMzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=YOtHCuQVgrYDXWdRuWwEP3mcQFoNJIbnwBuetJ2gNNU=; fh=OSqgNqp8YS27Zn5SGm+Ankg49DqRaR1sUlooQ6zVsMk=; b=x+vfmgY7h3v3dPv4fWGcP10GHmW1Mvgu8atCJINC24ijLOahuTpFRFB07+HVlE8grH QM7ZSP8xIBwIqpBTHmSvjqP+AlbcpSGYBCbZYpw26bmwTTO1cUzQfnA8AKMxNCOpDf1T QxhguRNyyO+UKPDc7wlhkSHMAnZlQlba+2i2fCwmF4b6ebvgOGN5XWxPnVvag2aUr9du KxgezFOSUEK1w61PCopIXDVW+iM9xbXPwcyJCkZE6c1qKSFC0AqCbqhzawN3xzEA2ZdW wobrUBCJ7Ng+OWJ+cmbvWpkg+uoRM8sziyPL+qdIBUgIb4Zadi3o37f847JRcL3ffi0E asJQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=0ZYKrry4; arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com); spf=pass (google.com: domain of linux-kernel+bounces-158163-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id j17-20020aa78dd1000000b006f0b53cdfc3si11308015pfr.203.2024.04.25.01.06.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 01:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-158163-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=0ZYKrry4; arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com); spf=pass (google.com: domain of linux-kernel+bounces-158163-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 92372B25435 for ; Thu, 25 Apr 2024 08:01:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BBFA6EB60; Thu, 25 Apr 2024 08:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="0ZYKrry4" Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E8AD67A1A; Thu, 25 Apr 2024 08:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032074; cv=none; b=Xe7pX8zL+5ZVmD8rs9ayZV4UH29Kx72KoZ0jy8/P/aV5/oF/voMBwEnBwkgCoiwY4dKo9LPfRNu5szSN1CMUuV9gVrg35leumqv2tzpgr6riFJ3VH1mA3YxO2jOZUAlDSseJdhxlfUppt4gwcBqBDnCsVYYzPPRdbd1J/8q2MsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714032074; c=relaxed/simple; bh=UzPMGSUJtT+RInEMFbaQI5Sl0HTJ8lUHorsleo6mKZY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=pnv+xhv26xGFvUXXJ/owBp01zFt7ZHuN5PcWrogqpyikGegHNtSpKdxwN0baA3FzpPjOTTLIuHRvQXx9QXGc06Uogo69dhtdLkGM+vgl5+Tfe6IFz7liGOLqjVr5LdxSIXcE7FZStqMNboneKlS8WtCDiVYHKcNhUW3ZzJFY1UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=0ZYKrry4; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43P6kBGS012219; Thu, 25 Apr 2024 10:00:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=YOtHCuQVgrYDXWdRuWwEP3mcQFoNJIbnwBuetJ2gNNU=; b=0Z YKrry4yGKBct1MDuCBybElqQy5KsACTBj6pKJ8yGTVCB/ZnT0/hHZZFXYLnOVxgl 7v7CnCZO2tRSiutP5IB6jIIO8obG8/HYUy1qjWw5fZNQCfbqk73598+quodjDTXa SMpvDz4NaeI8cwVQ27xByeMeWCHbhMCH6HUJiXKLFBqFwcfAzRnkFTMijypBchvj VRXe2YiIZDiD1QODBx85QtPqSH4EPwcCtxUkLyU8TtdeNLihKNOrZwogeJfbzuEO anmZMT8yRMYw5oIF5DSHNKwPpX139M0IIUX0crVLeCUQgKUqcPnVtp3YCQu44RdO 9C64JBJMgTEi2hnL70og== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3xmq90th7w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 10:00:55 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id F3AE54002D; Thu, 25 Apr 2024 10:00:51 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 153102132C0; Thu, 25 Apr 2024 10:00:07 +0200 (CEST) Received: from [10.48.86.79] (10.48.86.79) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr 2024 10:00:06 +0200 Message-ID: Date: Thu, 25 Apr 2024 10:00:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/9] i2c: stm32f7: enhancements and support for stm32mp25 To: Alain Volmat , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Pierre-Yves MORDRET CC: Conor Dooley , , , , , References: <20231215170617.95868-1-alain.volmat@foss.st.com> Content-Language: en-US From: Alexandre TORGUE In-Reply-To: <20231215170617.95868-1-alain.volmat@foss.st.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_07,2024-04-25_01,2023-05-22_02 Hi Alain On 12/15/23 18:06, Alain Volmat wrote: > This series first perform enhancements in the way interrupt are handled > and cleanup in messages. > Then it adds support for the stm32mp25 which differs in that > it only has a single irq line for both event/error and has a > different handling of the FastModePlus. > Support is then enabled within the stm32mp25 related device-trees. > > Changelog: > v3: - addition of 2 commits dealing with readl_relaxed(I2C_ISR) in > isr handler and a second one to use dev_err_probe during probe > - correction of SOB in commit > > v2: - correct st,stm32-i2c.yaml. Use if then else scheme to indicate > number of interrupts / interrupt-names depending on the > compatible while keeping the description within the common part > > - correct 2 maybe-uninitialized warnings > * ret in stm32f7_i2c_write_fm_plus_bits > * irq_error in stm32f7_i2c_probe, move the platform_get_irq > within the same if block as devm_request_threaded_irq > > Alain Volmat (9): > i2c: stm32f7: use dev_err_probe upon calls of devm_request_irq > i2c: stm32f7: perform most of irq job in threaded handler > i2c: stm32f7: simplify status messages in case of errors > dt-bindings: i2c: document st,stm32mp25-i2c compatible > i2c: stm32f7: perform I2C_ISR read once at beginning of event isr > i2c: stm32f7: add support for stm32mp25 soc > arm64: dts: st: add all 8 i2c nodes on stm32mp251 > arm64: dts: st: add i2c2/i2c8 pins for stm32mp25 > arm64: dts: st: add i2c2 / i2c8 properties on stm32mp257f-ev1 > > .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 28 ++ > arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 36 ++ > arch/arm64/boot/dts/st/stm32mp251.dtsi | 96 +++++ > arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 20 + > drivers/i2c/busses/i2c-stm32f7.c | 342 +++++++++--------- > 5 files changed, 358 insertions(+), 164 deletions(-) > DT patches applied on stm32-next. Not that I added acces-controller bindings for all I2C nodes. Thanks! Alex