Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp963989lqd; Thu, 25 Apr 2024 01:53:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVV5oHpDoJYQ1HNrSE6I60B9BdiyRcb9eozZn4bZjkX4S284UyuPqVr1XtFqv+VNMuceKbhA89cS1BI+Jqm5+GrjIl2GM9iTknWmlKTaw== X-Google-Smtp-Source: AGHT+IHndr2QDlw7I0VPxI6JkolzJK1DBz9MA1KbiZTwI/0t9n4Db/JWH+tQjdWBQMHObFwPAYJz X-Received: by 2002:a05:622a:298d:b0:437:9fdb:97d4 with SMTP id hd13-20020a05622a298d00b004379fdb97d4mr6416875qtb.33.1714035189536; Thu, 25 Apr 2024 01:53:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714035189; cv=pass; d=google.com; s=arc-20160816; b=C/4lYh/p9ghrttzExZtTBD3CwmK5rtOvGgGqBn9HE25CpSqMKa1brwrXe59thfqR0c AUmbAZmNh2hS2lhfekloG+oyDWxBKqWtJf5yejyqmBxWR5+4zVOO+g5/3L4+LMvej/ay AHMJ+1E0GCYmSIdwBdquuPamAJqIk8ZL5vAE4uY/5o/LJ2jf6lnbGDsJjVKhd4ReIHhN Rh22WueuzhoIDVMAdPgUk8MxcREqnWJiOgmrTCS27Kk8QCPzYA3aHTm6w2wqlq1ThxER SE3b4AFaiCNG8/l9SJGUBqTX5GMqZ8iDIz1Vp8MIXU+hqQvw6NmkSNBohWbjvGnMWRSE 8SVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=2ii76LUBj9Ob19+f2whv+RVZumtvMFFoj0WwOmyLIt0=; fh=pXSPbYxB4Gt+tuxYhwh0w5z34cTOvFdHv+0ARw3rWaw=; b=ELu06Ybgy5thXKHqFnJM3aNOX0WdAVsYSH0wLmVtnUWi58W06thHRXo2nKx4AXveEL gUWO501XAT/sxa2+bQUw/K7G80IO6H7hgNgFw9CPuuQhlbvMPZ4WrIcHIbgXPDChY87V N/XTMKtC2neWkZNX7gH637ym0TKoaoUn6m339HFPDapyNSqYTCKHXfhCz+BKMXBfvZ1d yzlmFrgmJtyTZ2VfQLbJg5nRQrnecvtzw8b6wlbItF+IW6BO+yQoxdoV1a3MKgkmBT+E DW5M4HNKpZi/NvxP3coaIXtYfl8+rjhVOx8VJMQJzrvGF6VeON791oquhwdOdXQqM16K /Mug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=dIfdBXPI; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-158219-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158219-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h11-20020ac8584b000000b0043a0d6e5558si4471501qth.767.2024.04.25.01.53.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 01:53:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-158219-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=dIfdBXPI; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-158219-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158219-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 446E51C20F98 for ; Thu, 25 Apr 2024 08:53:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A12BF8172E; Thu, 25 Apr 2024 08:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="dIfdBXPI" Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D377F486; Thu, 25 Apr 2024 08:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714035174; cv=none; b=aYGpJc6AmtUGwE+Vl/bGXKhjbCz/r1/BBjFVKIfTcA4outpucsnb8oGfdx7WO+krrmVRJag3LV4EaitOHTaJ/7aLSqRGIMWtgsPuQPlLKVncDrhvREyvC1yHSPR0E+bMAdSbYYYAYhTnDcpU1de5xx12kmZ26BiEPpqyuxFv3WI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714035174; c=relaxed/simple; bh=2ii76LUBj9Ob19+f2whv+RVZumtvMFFoj0WwOmyLIt0=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=ao5sl5IWpyoDek6F6JF+utecVMQCIUsmDzAT0xk/pvp/QYfwIg71IfJ4EQs/FMhNcEmpt5/HWnrcpEaqdOzCYv6HltYDkyQ90JMtos+7zlwTi6wl/iXoioI0QEid6C8flc8PDcY6PuyDb2TP4Bl5lZPhS76Qo6on+G8p9tG3USs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=dIfdBXPI; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714035117; x=1714639917; i=markus.elfring@web.de; bh=2ii76LUBj9Ob19+f2whv+RVZumtvMFFoj0WwOmyLIt0=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=dIfdBXPIujAhwTh6VZnWtncvA1XWiKqV9vpmVx6mtVKkAZ7C8ihefH1HCRvrH5ep I+sZZEO/50ZvJcBLfa9cg1dIuGapn7oIVC/UKYrWQT9fJlUQGqisN3JMVLrsS2k8C lxYiUrwi4R9M9J1/J9KJnFryPFEZgCzK/PvUXqBa55tzsBGo3ttIqzqMS47M0YmFU XjsufLLyLN9ZdVyHpVCPqJIIwFqgrBOkPrzMnZKGzk2F0NPOkJP2zBAHXHkUF/wI9 /203G0Qb5/JOkJdR/f/1VFCLWJU5VZKDahErizDNM9HMhGZYoXoivB/ENICtwOG+W gYjApMmG+MBiuJNjIQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MRW2D-1sNLPF40Qf-00NUmb; Thu, 25 Apr 2024 10:51:57 +0200 Message-ID: <6e028bfa-9063-42ac-b40f-cf17a81c2af2@web.de> Date: Thu, 25 Apr 2024 10:51:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Abhishek Pandit-Subedi , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, Heikki Krogerus , Jameson Thies Cc: LKML , Benson Leung , Bjorn Andersson , Dmitry Baryshkov , Fabrice Gasnier , Greg Kroah-Hartman , Hans de Goede , Neil Armstrong , Prashant Malani , Rajaram Regupathy , Saranya Gopal , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= References: <20240424014821.4154159-2-jthies@google.com> Subject: Re: [PATCH v2 1/4] usb: typec: ucsi: Fix null deref in trace Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240424014821.4154159-2-jthies@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MWIAd9tfE9Cl5DWSBlawdxc9rLXN4r3w9oVfMsROo9DFxAP9QSb dAN5xhx39A6eJxpcr09q4YAV5nIQda6BWSBQrr3iHiQ9Y6JZm0SFInuOSpWh/yELwxqOoob 9yiOlZC1rEZLPD//da/dOOGv0mPtYh2Q+7Quv9Zzg6a2dDM8q2XN3iutK6lkbuRhoLxDduv Dovre41suigX1sdGsANlA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:82+JCbADl/Q=;8624TNLGloARLOYQ/BOLV+yGdVj tRYpiSQQIjL3i73JQ6pzaVWf4ROTq73TDcxAFVMTQivqidd3asU5pIHmHYQ21sgSYa2DWuM1u Ask9GZR9uCK5j43oaBoHQmvv2kWliElxtpcOMlZe1ZdXTaAudOnLQGewybrzEV7Av44h0qh9J UG54OdL/iJwJP4UcwgwN0AKGTf7GCAWd5LKEDrYpAY/5HmMqegr4x6WUb8XhNJJaXIIA1g5+L asGyFg2JlK6QcAkMa6n4fOWhNXjyGjgkhM1OpR/jQaskTU+xIuyLqppuGLKCnbE1yIUTolRyO ETCHoNDJDJJkcdnmlQ4J/R+y/aDC7ieB5LVLzJURXLmyjCK+UtYcQ/bnPrjaoljlsK7kIoVEx 6qqtnmvq0VovcVOWntybaAu89CdGzsZ0BKCcGjMk1tHV3ZYtbwk8YSPXQQft1nxV1wCKSBg0r NNVR2gB4LFQkgtV0SMk5GGgRnI0//fxAO+Zb/cukiRXpXgqgyyQC99CjxQ1daa4kEPTXxDcz/ iOAIev88+eyHDm23vE3vGj11niorw5Xn34hsnCc/sHBbeDbr6IvZcIVQg9CnVcwXGYTOULCSp j4kCYRCah/NPB1B1wHa6re98hlx7vmblpTn3QXXD1J6i3EfXch2X193YY5EBJ9kg0OCaOGrKh ld+zLLhNeRMAlExFy5EUOTxSW+0anFoKlmXp17hTPHuEVH/G8Rc9BpVjWwmP0qB3jLIRMlH9A TYlmjYdkTH/22/XwVSbc+NqcwFl2Pr5zv6Xnd19LbOl4ZmExDVvdDk5Qq16Um3oSLCjaMsrAA k6gea/TJZQ0IAvFXJQuTYftUJZTX+oALHCqiquNotVzQ8= =E2=80=A6 > ucsi_register_altmode checks IS_ERR on returned pointer and treats > NULL as valid. This results in a null deref when > trace_ucsi_register_altmode is called. =E2=80=A6 Can it be nicer to use the term =E2=80=9Cnull pointer dereference=E2=80=9D= for the commit message here? Regards, Markus