Received-SPF: pass (google.com: domain of linux-kernel+bounces-158290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fa7f3c1b-7693-465c-9f24-e6176074a818@intel.com>
Date: Thu, 25 Apr 2024 11:21:57 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION
To: "liuyuntao (F)" <liuyuntao12@huawei.com>
CC: <linux-kernel@vger.kernel.org>, <linux-kbuild@vger.kernel.org>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <hpa@zytor.com>, <masahiroy@kernel.org>,
	<nathan@kernel.org>, <nicolas@fjasle.eu>, <peterz@infradead.org>,
	<jpoimboe@kernel.org>, <leitao@debian.org>, <petr.pavlu@suse.com>,
	<richard.weiyang@gmail.com>, <ruanjinjie@huawei.com>,
	<ndesaulniers@google.com>, <jgross@suse.com>
References: <20240422060556.1226848-1-liuyuntao12@huawei.com>
 <8cb7f43e-0ee9-423d-ad27-93b3c69809f5@intel.com>
 <d129733e-6c53-41b9-ae23-4a97c4eb5a30@huawei.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <d129733e-6c53-41b9-ae23-4a97c4eb5a30@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0RhVjQ4T2MyZVplSUl2WE1FSi80U0ZGVDJlckVNb3hwOTIxdi82UDJTajNP?=
 =?utf-8?B?WGMvRm90dlFBQ2t4KzZkcWIvYlByMkxPcE9Jd3psOFR2YVBaUE1jOXhiampm?=
 =?utf-8?B?U3dSSnhSNGx5OUlRZHNRZTJ6MzIyRkxmeEdWOWFUUllZc00rYkZDWjlhYzIw?=
 =?utf-8?B?U1N4anpDakFab1BLclNRbjZ6UU93c0Vib3JHeDBPeGx4djlSY2Z4Q25VdGRo?=
 =?utf-8?B?VjY1clNyOWdpUEhsUUdLYURkdUFSMTQvaG04cDV4QVpoZHJOTVBURjFwS0lr?=
 =?utf-8?B?UEFra3Q4Vlp2ZTJrWHFlVGpYYmYwcEJSTWNRUjlYNk5HaWduM2grRG1JRDJ3?=
 =?utf-8?B?elE1dDE1TVN6WlVLWVVtT1A4Um5BSHlKSk5lZjNqTmM4MUNqZTBUeDRLdFZl?=
 =?utf-8?B?aU9JL01LdmhaUEdsSWpGQlFhb2lTU2JzWjJTRmh3SHd2dFM0RWgwazFBd2RQ?=
 =?utf-8?B?Mnl3dDFDbURTcXowem9EdWx5M3pEVmpxYXhHRmc3cTFHRGpjQkYwb0hrbGtu?=
 =?utf-8?B?bXRISURHM29lSVJmUERhSFRIdDR0a1Jvc0R0b3M4MkNHODJKM0NBb0RRVHRX?=
 =?utf-8?B?MTZtSk13MnhkNGVYRktoTCt3b01vWk1zN3BBOGd2N1RCaEtuZTJsbCtPMmVD?=
 =?utf-8?B?TSs4RTllK3J4ZEpKWFdCdFhCWW1wZEZkdndHZVBsSDlRS2NrZDd0RUFoRUZ2?=
 =?utf-8?B?U09CWlhJWVpCZEtZZ3R1Q2RaYi9DY3pEZlVTeERaK0xQUGF0N0VhTHFCckhD?=
 =?utf-8?B?N1ZhNzhJTFRvWldmWlBzeXJiN0ZKcG4zRjhXekp4RVJiSFRhd3dqYVE0NEQ5?=
 =?utf-8?B?bGl5cHpvdTdoeVJiTGFaeTZaYk01cXAyTEFGd1puQWF1NWJSRDUzdWhocThM?=
 =?utf-8?B?QXl6WTFyRDA0eTZVcG83SUtsTTg1dFR1Zy8xeFdZYTdqd3hzWUVFbUZENjl0?=
 =?utf-8?B?bEh5RitLVnBkZGU3TWc2SC8xNkg0WWE2M3l6c2FkbTNFRlg2a2MvOUJzZVEy?=
 =?utf-8?B?WEF1VEF3ZWMyUFZObDYwTW1PdG1yTldnOHFNMUhPME5PSE03dEdzbStmVmVE?=
 =?utf-8?B?UEdpUkJvUTA4N2RnODZhU2ZoemUrSmxwRU8rM3Z6ZWtSNTY2WHgrbGxiSXJp?=
 =?utf-8?B?ZFVXaXBTUzJLa3ZRbHhFMUJzQ3EycFZPeWx0UC9tWUlVczlyUHN4ZFlxU0ZF?=
 =?utf-8?B?SklTS1BSNHUyd25JQTViTkRWODI3L0p4S25WbEZBckFsMGpKSFZHSmV2anZp?=
 =?utf-8?B?bVJpVStsNkQ5aVQxVDVlVXMrTkliWSsrZXJUUk9xYktDaldlc2JaQkxhemtk?=
 =?utf-8?B?bUZiNFFucktabVNFZWhmRDZJK0dyNjI2eWsxZ3RJTGNGQXFjNEhKRzE0VXlE?=
 =?utf-8?B?aGEwR0dyUzlURmdGWVhqTGRuazBZc2h0U0pSL2diQXhXYTZFaCt3NUE5dFdO?=
 =?utf-8?B?MDEwbEE5eWF1VDhNRHY1emdzbTFsQ1ZLdmQ1THpzaVlNVmF4WU9HTzFEUjVS?=
 =?utf-8?B?MmhqVlZvTjJDYXR3bmI0ZSs0RnFUbmJidkpSR0FLZVZQOXZ0VGFDWWl5OGU0?=
 =?utf-8?B?QmZPOXFIRkVQdG9lbnJiZEhUSUtnTEc5WWYwVjBoU2xGVmVMRWhvbTg2dHNT?=
 =?utf-8?B?NXprQm5USnQ1dUplMWNOaXFOTVB2SmhwM3JVbFBKRFFoK0FmRVNVZk0yZTRu?=
 =?utf-8?B?MThORlZvZ2lNN2J3RlZlM2NEeksxV3NMK3ZoZ0lpa1FmdG1kM3c4ZlZjZDNF?=
 =?utf-8?B?aEtDRGNNRldDaUpCQnRIOFhmNGxCcm03TElSYWJ2bmVYNnUyTFNGWk82ZjVN?=
 =?utf-8?B?M0wxSEZwNlRIMlRpcHJvRzZRa09RdTd2QzZMK1lUdEZTUWQzMHp2R2hmeHlE?=
 =?utf-8?B?aEF4RWhSMGdLUkZtQ2dLTnN3U1ZVTXI0WHVOeWw5dHlKdnFxaHF6cjBWbXNp?=
 =?utf-8?B?cnF5NWRJRjVjMitoZzljb0FxMnBNM1FqaEdybmZiOFRnblpBVFRHanJyaFd4?=
 =?utf-8?B?K21EaU5XZlZDZHFJNDlKSmtOempycll0TllLWmxsQXdUYWw2YzhSL1hHOU4r?=
 =?utf-8?B?aUdYakVPUHd3YlFBOTh0bU1FN1owajFIUUd0VnVud3FMejBFWUlzUVhZakdt?=
 =?utf-8?B?WTRqNWZJZWd1MXg1a1prWU9GRUg4dEhlWUNIdE52MDZHUWFhVURvT2N2NFRS?=
 =?utf-8?B?N2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f59fbac0-9336-4d97-1769-08dc65092b2f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 09:22:03.5500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wgyAeyKBPuSrS/o2yC3nkNBy7Z+Q6SZEabtCad2p/kfNZndNLl+Ql9mPl/GXPfniHUC+9q1B5jLczDNwrj3mVgh8BiinbeUF0xmHPK5Id0Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8714
X-OriginatorOrg: intel.com

From: Liuyuntao (F) <liuyuntao12@huawei.com>
Date: Thu, 25 Apr 2024 14:37:19 +0800

> 
> 
> On 2024/4/24 19:06, Alexander Lobakin wrote:
>> From: Yuntao Liu <liuyuntao12@huawei.com>
>> Date: Mon, 22 Apr 2024 06:05:56 +0000
>>
>>> The current x86 architecture does not yet support the
>>> HAVE_LD_DEAD_CODE_DATA_ELIMINATION feature. x86 is widely used in
>>> embedded scenarios, and enabling this feature would be beneficial for
>>> reducing the size of the kernel image.
>>>
>>> In order to make this work, we keep the necessary tables by annotating
>>> them with KEEP, also it requires further changes to linker script to
>>> KEEP
>>> some tables and wildcard compiler generated sections into the right
>>> place.
>>>
>>> Enabling CONFIG_UNWINDER_ORC or CONFIG_MITIGATION_RETPOLINE will enable
>>> the objtool's --orc and --retpoline parameters, which will alter the
>>> layout of the binary file, thereby preventing gc-sections from
>>> functioning
>>> properly. Therefore, HAVE_LD_DEAD_CODE_DATA_ELIMINATION should only be
>>> selected when they are not enabled.
>>
>> Dunno, I have DCE enabled for years on my home kernel, see commit [0]
>> with both ORC and retpolines enabled, and I didn't have any issues.
>> vmlinux still shrinks well, even with Clang LTO.
>>
>>>
>>> Enabling CONFIG_LTO_CLANG or CONFIG_X86_KERNEL_IBT will use vmlinux.o
>>> instead of performing the slow LTO link again. This can also prevent
>>> gc-sections from functioning properly. Therefore, using this
>>> optimization
>>> when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled.
>>>
>>> The size comparison of zImage is as follows:
>>> x86_def_defconfig  i386_defconfig    tinyconfig
>>> 10892288           10826240          607232          no dce
>>> 10748928           10719744          529408          dce
>>> 1.3%               0.98%             12.8%           shrink
>>>
>>> When using smaller config file, there is a significant reduction in the
>>> size of the zImage.
>>
>> [0] https://github.com/solbjorn/linux/commit/25c4953ea73d
>>
>> Thanks,
>> Olek
> 
> I apply your patch, and use LLVM toolchain to compile the kernel, it not
> boot on QEMU.
> I use the following command.
>> qemu-system-x86_64  -smp 2 -m 1024M -nographic -kernel
>> mainline_linux/arch/x86/boot/bzImage -hda rootfs.img -append
>> "root=/dev/sda console=ttyS0 rootfstype=ext4 init=/linuxrc rw"
> Have you tested your patch on the latest mainline version?

Nope, it was a year ago and I haven't touched it since then. Did the
low-level code change a lot?

> Thanks.
> Yuntao.

Thanks,
Olek