Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp983692lqd; Thu, 25 Apr 2024 02:35:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVcOV886lNyvDmM3RNlog6RMR/Df43BRqGZZgsoLTwv181QgJjs6rcib1/DM1TACSvBMro++iubQWu2HFxAqv7ylz0jvu79yDfv8qeasA== X-Google-Smtp-Source: AGHT+IFW3ah0pQ1uIz/ivVMFK5BDrNba1rcCSve+MvqJCXXBVzemeOB5dqK0f6QjnpdRbD9ckjDk X-Received: by 2002:a0c:efc7:0:b0:698:fd40:dec9 with SMTP id a7-20020a0cefc7000000b00698fd40dec9mr5250675qvt.32.1714037699899; Thu, 25 Apr 2024 02:34:59 -0700 (PDT) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id s4-20020a0cf644000000b006a0598e3f6csi3938784qvm.404.2024.04.25.02.34.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 02:34:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-158305-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=YLxTctwn; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-158305-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158305-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 52A5A1C219B8 for ; Thu, 25 Apr 2024 09:34:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 57E8C85277; Thu, 25 Apr 2024 09:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YLxTctwn" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0550C84D1C; Thu, 25 Apr 2024 09:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714037680; cv=none; b=mtDZdLLeH/ykSNop2yz8I9O3T3TTidZVID5LV+vTVI3K5kDXohoEZrAwh9WoP6WlfZZd5FK25eFF+QBt1Fo6guXt//Fqu2v3Gn5cjVH/D+CpFIFgGdux6Klpeh3fl6YwqNXcDMVYlU57sZsq1bR2aeA8sPOmnZ3eKnnT66FPNks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714037680; c=relaxed/simple; bh=xf+cGSpTyS5HTjPAzG6cQ2kpu/5/9RutGA1f+6j5JMg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mDNV37P14aa0oQ6Ce3/YF6mtKC6A1Tk8aJ13SjbZeLvh/V8F85SzYrGYwKhaEalEw67Rwg/nBIl0Li0Wv0q75gljsbEiM58Ew9BG+PyXEFeWjsrbpNb+qbcf6z79ilwG7i3OwFnJq4SkH3ktcyEc0L4dTcrFXwVUpRmDo1Q912g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YLxTctwn; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714037679; x=1745573679; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xf+cGSpTyS5HTjPAzG6cQ2kpu/5/9RutGA1f+6j5JMg=; b=YLxTctwnKaN6VUetWsm7Lltw+mgjliLYhVgUnfMupLb4iSd+T/4p1cC6 m28YPul29bCkFDqsRpvr87U1ASsDX9b57w9bErdj6FS5Qr58l+NtbY2iG FP4QsBSdaoHaso7ju73qLhEHNZiZDUf8mpW5yXkyZxpxyBWNPIrVx2/vZ B6Cw868dFF/4u1uHg3maKpPSesL4ExS5NJ4FVf/g8UUyDxL/cuPWIKzfC 5ISXSp1HERpU9P8d6teDUM8bob2Li8D4yJOXBEqUz+HI4GnQm7HaWDoGj k68SEjATP8VfS0p8YI8VASuo0FO8eZgdghUOZc2k7J2bvxNJQzUkIWJkX w==; X-CSE-ConnectionGUID: GeuCZC5dTd6SfTe49aVdeg== X-CSE-MsgGUID: fmcjr6yQQb+23NsLzvAwig== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9577330" X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="9577330" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:34:37 -0700 X-CSE-ConnectionGUID: XEdt0L7yRv+zKzqu0H8pjQ== X-CSE-MsgGUID: JW2q2ci6SzKlPgRqJfpwRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="48277830" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:34:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzvUr-00000000wqq-3lRX; Thu, 25 Apr 2024 12:34:29 +0300 Date: Thu, 25 Apr 2024 12:34:29 +0300 From: Andy Shevchenko To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Jarkko Nikula , Mika Westerberg , Jan Dabros , Andi Shyti , Lee Jones , Jiawen Wu , Mengyuan Lou , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maciej Fijalkowski , Andrew Lunn , Duanqiang Wen , "open list:SYNOPSYS DESIGNWARE I2C DRIVER" , "open list:WANGXUN ETHERNET DRIVER" Subject: Re: [PATCH v2 2/4] mfd: intel-lpss: Utilize i2c-designware.h Message-ID: References: <20240425002642.2053657-1-florian.fainelli@broadcom.com> <20240425002642.2053657-3-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425002642.2053657-3-florian.fainelli@broadcom.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 24, 2024 at 05:26:40PM -0700, Florian Fainelli wrote: > Rather than open code the i2c_designware string, utilize the newly > defined constant in i2c-designware.h. .. > +#include Please, group this with linux/dma/idma64.h below. .. Acked-by: Andy Shevchenko in case this go anywhere. -- With Best Regards, Andy Shevchenko