Received-SPF: pass (google.com: domain of linux-kernel+bounces-158287-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <17953924-bf09-4eba-b8d6-1f828f39c0a2@blaize.com>
Date: Thu, 25 Apr 2024 10:20:49 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/5] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "robh@kernel.org" <robh@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>, "arnd@arndb.de" <arnd@arndb.de>,
        "olof@lixom.net" <olof@lixom.net>, Neil Jones <neil.jones@blaize.com>,
        Matt Redfearn <matthew.redfearn@blaize.com>,
        James Cowgill <james.cowgill@blaize.com>,
        "heiko.stuebner@cherry.de" <heiko.stuebner@cherry.de>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "macromorgan@hotmail.com" <macromorgan@hotmail.com>,
        "sre@kernel.org" <sre@kernel.org>,
        "hvilleneuve@dimonoff.com" <hvilleneuve@dimonoff.com>,
        "andre.przywara@arm.com" <andre.przywara@arm.com>,
        "rafal@milecki.pl" <rafal@milecki.pl>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "andersson@kernel.org" <andersson@kernel.org>,
        "konrad.dybcio@linaro.org" <konrad.dybcio@linaro.org>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
        "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
        "nfraprado@collabora.com" <nfraprado@collabora.com>,
        "u-kumar1@ti.com" <u-kumar1@ti.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
References: <20240425091403.17483-1-nikolaos.pasaloukos@blaize.com>
 <20240425091403.17483-3-nikolaos.pasaloukos@blaize.com>
 <f45a76b3-996f-4204-9b9c-289d40767708@linaro.org>
Content-Language: en-GB
From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
In-Reply-To: <f45a76b3-996f-4204-9b9c-289d40767708@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dWRORmVmZ1FkMmhXd1gxaGdJNEkyUGF5WFRtbWh1a2t1dWdqcnp2TVE0cWha?=
 =?utf-8?B?OUp2VWJZL0FIUjdUWlA5OTEvMklCNjUwd0pZSnI5ZVdodXhsWjFtUTByZE1m?=
 =?utf-8?B?REFPWGQwNFhmTHZqdm5peWVGcjFQODMxYUl4ZGZvSGh1NnVjK3JENXdwTHFQ?=
 =?utf-8?B?MUhDK2ZHdnZFeU9pelFSb3FDeFFqQ0NvYTZJalRIN0MwMFV2YU1CZXFFWm0z?=
 =?utf-8?B?VDQvSnRHV0VQWjhaV09GWXd4amo4TW4xcUNnZmpWTExyV2JXekVJd1RTZmJw?=
 =?utf-8?B?S0t4TktmYzFzMjNDN2JPMDlrT1cvV010MkwvTlNqVjlYVWNsaDczNGxSL2FG?=
 =?utf-8?B?TENnV0VUdmtrV3NIZkN5bVFRR3ExVm1qUVNMUFlvU2JRZjllajFla0xQcEpV?=
 =?utf-8?B?TVZrS2VMOEFwVUlMcTY4NU01V0l4TGtrS1N6THd4MlFHTXU1T3JqZHVzQUpJ?=
 =?utf-8?B?UTJidDcrOS85N2dHcUoyRGFWY0VyT3Y0cXZ0ZGpORi9FRDBnVjhuM2tQeW5l?=
 =?utf-8?B?ZTVTTmJrTDlYZytUN0VCWHAyOVhnQ1lOVjZ5VG9NVjFZcUt0SmxJZGxrbkVJ?=
 =?utf-8?B?d3drcjFZMkZKQnJpM3lKczBDb2RZbUVZQk5maCtjcEplN1FJMVJ6OVNmaDh5?=
 =?utf-8?B?ekZBMzJ3V2lEalo2RVMwWnlObkhSTXBtdTVqQTVZZnFXZElZV2pRRmxnL0ZE?=
 =?utf-8?B?UDZicHN5azNJV0JCQTFTalI3WXJjSnlZM2dycG1nRkJuenBzdkM5NE81ZDRQ?=
 =?utf-8?B?bFlrVVRMSUUzVllGV0J5YW1UT1gyN2NmL1Q0dmtQbElRRi9uSXg0QU5PMGZh?=
 =?utf-8?B?Y1VKb0FwRzdwUnZDZHcwS3dKeUJlUmJxVHZ6SytkZ0Z3VXV0Ums1dnhrNXVF?=
 =?utf-8?B?MStCSUtYVWlVMkNXUXZBY1JxSGpGTGJqRWw3QlRMM1JnWXE3bCtCS3NTcXkv?=
 =?utf-8?B?UStoMFB5SjFnME9ZWnNUV28wbEE2UUlNdUJxRjJrTitZcWRqWTU5S0JMZWVq?=
 =?utf-8?B?Zy9PN0Vvbkh1dk5YOW1xN3kwVlZRbjU2Sm1JSnQ3QTlwZzZCU1ZlU2J6eTZR?=
 =?utf-8?B?Tk4xWDNwalo1bG14WkkvL3VkTG92VGE2ZWdzYjZvbXlzRHZYSER2WUV4dDVB?=
 =?utf-8?B?RVlVTUFqS0NUaEk5RVhvbEFMQmFkaFNBbmZMbHdKV2JWWG1jTjljQjR0VFNt?=
 =?utf-8?B?UW1wbXp2WEdoNk1YL2xmS3V3UlV4ZGREZWRkZ3llc2JMelFNYVpZZjBVYjhW?=
 =?utf-8?B?MHJOZ0NjVHlMUlYzbmt6Q29YN2FpM3JnZ0h3S1hyS0RIL3AzU3BKOC9aTFZj?=
 =?utf-8?B?YVduQ2V1Nk9uQ05ETmI2ejFod2FmeE9WajJ4Z0llN2pFTGRuWWJvOS9TRkY1?=
 =?utf-8?B?MHRUWXdHdXhqQkR5VngrYmNzcUlxNU1KU25rSzU2aVRpZ2t6dGVTeUdZQjhU?=
 =?utf-8?B?T0cyYVc2Sy9NS2ZESE1yRk5vZ1c0WGhUTGVkQ3luSVlzd09QR3dXTG5YOFZD?=
 =?utf-8?B?dWF1U2x0U3lIMW0rUVg4aEt2VFRqM3pQcHBCajhpamxBNTN6WnRqVWVVRE4z?=
 =?utf-8?B?ajhYd0w2SjJtSWxNdjM5KzU2OXJiQjJINmdhaHljRmdHeTBBcUJCeW9pMEN0?=
 =?utf-8?B?M3dEcjB2UzdhaFRwQ0g3bHMrZnhwUy9wdHNoOGRpaUhOUW1sOE5sb3hlZ2Jt?=
 =?utf-8?B?Tnp4eUc1aHFsZ1QrYmRqQi9uT2lvTVdrRVRSWVdPaDdrdElOVVI4dTU3eCtI?=
 =?utf-8?B?QjlsTXF4OWdRYVEyczZWZ0k2WGp4Mnd3ZTBWQVhzM3ljcFB2VGgzQk1xMzJr?=
 =?utf-8?B?ZHI1ZHNsclEzTkdqOHMyNG1BL2FNTVYrU3Bmdy9YVHJhZjdMelA0WUhsYWNM?=
 =?utf-8?B?aXo3QmVsblZtUzBEaEFSQWUxY3kyeGpnSDhNeVBkZVJwN0p1TEdaeVJvZ3Rq?=
 =?utf-8?B?L1pXRk5sa1NQbE1hYUZKZ002cXY3c2M5elk0b25MaENSTUZKamxCbFRzek92?=
 =?utf-8?B?cHRyTzZ6ejFjMGQwZElSNmVXNm9kOTdqY0tINVUvb3NVUFdhUXZWM2pHNU1C?=
 =?utf-8?B?Y0JKQjhDclVMa0FPejByem9pSlQzNWNLdDJWZXh3SWE3Q0pxUnpiRDVxNU1B?=
 =?utf-8?B?TjFWSGZ6c2RDS2w2ZzJWUXV5Y01na1JoYUlPaXNsYUVOaXZhNkNZMUNNY3J0?=
 =?utf-8?B?cTZkN1NqK3NQSG5MN2dDbUxBcDN0V2ZmdHlEWUlUdUNWT2lIanF0MkV6K0pU?=
 =?utf-8?Q?/es5XWe9O2dL9h+ZYmnuTbfZYZA1FVw7k/m6fWjlkc=3D?=
X-OriginatorOrg: blaize.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 682d651b-c115-4f91-24bd-08dc650906ac
X-MS-Exchange-CrossTenant-AuthSource: MA0PR01MB10184.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 09:21:02.5045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 9d1c3c89-8615-4064-88a7-bb1a8537c779
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /+HePL+n4ahxUVEI0YVw7UW80K6CD+tFW4t0Xe8cVMUKiseMdKF7tq05cNDYAC/t7uQ0UqI5Efbwt03rEv/R1Tf6maSeDEgP+Bc0co1tWSc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB9343
X-Proofpoint-GUID: fcLep7KfcQ8bYnncS_hEScPJWp4opmE5
X-Proofpoint-ORIG-GUID: fcLep7KfcQ8bYnncS_hEScPJWp4opmE5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-25_09,2024-04-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0
 lowpriorityscore=0 clxscore=1015 bulkscore=0 mlxscore=0 impostorscore=0
 priorityscore=1501 mlxlogscore=999 phishscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.21.0-2404010002
 definitions=main-2404250067

On 25/04/2024 10:16, Krzysztof Kozlowski wrote:
> On 25/04/2024 11:15, Niko Pasaloukos wrote:
>> Add device tree bindings for the Blaize BLZP1600 CB2
>> development board (carrier board), which uses the
>> BLZP1600 SoM.
>>
>> Reviewed-by: James Cowgill <james.cowgill@blaize.com>
>> Reviewed-by: Matt Redfearn <matt.redfearn@blaize.com>
>> Reviewed-by: Neil Jones <neil.jones@blaize.com>
>> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
>> ---
>>  .../devicetree/bindings/arm/blaize.yaml       | 40 +++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml
>> new file mode 100644
>> index 000000000000..8034aeb7a2b4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/blaize.yaml
>> @@ -0,0 +1,40 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/arm/blaize.yaml*__;Iw!!FddXBOku!i6XKbnL3gXmoklJKfuksrfCB61MTEFuw8JiIVn9sS0CzEmHpqDhXguC5Me3sUQt1gw4RxA4mo8TAHR8psxBV0Dmrs0veWKlRgo18$ 
>> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!FddXBOku!i6XKbnL3gXmoklJKfuksrfCB61MTEFuw8JiIVn9sS0CzEmHpqDhXguC5Me3sUQt1gw4RxA4mo8TAHR8psxBV0Dmrs0veWEVjMhqf$ 
>> +
>> +title: Blaize Platforms
>> +
>> +maintainers:
>> +  - James Cowgill <james.cowgill@blaize.com>
>> +  - Matt Redfearn <matt.redfearn@blaize.com>
>> +  - Neil Jones <neil.jones@blaize.com>
>> +  - Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
>> +
>> +description: |
>> +  Blaize Platforms using SoCs designed by Blaize Inc.
>> +
>> +  The products currently based on the BLZP1600 SoC:
>> +
>> +  - BLZP1600-SoM: SoM module
>> +  - BLZP1600-CB2: Development board CB2 based on BLZP1600-SoM
>> +
>> +  The compatible property should follow the format:
>> +
>> +  compatible = "blaize,blzp1600-cb2", "blaize,blzp1600";
> 
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> 
> Best regards,
> Krzysztof
> 

Apologies, you are right. Now with the threading fixed, I'll be able to gather all the feedback properly.
I'll fix this on V4.

Best regards,
Niko