Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1010599lqd; Thu, 25 Apr 2024 03:31:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXVBJrAtWDF0uxSdJjj2oiXoWYF96cIYUBUJ6uUyOUEGWCPALKx2onVcxYStC3hU22Y7xrXoBtT47n3Vw1omGEJFYFAGPr2GaOqngxuGg== X-Google-Smtp-Source: AGHT+IGY7J5DwE4dOvbAShW68b7I9irA1+rfNV9qb4zCqDRfdBjX2cLDqb49SccXrFfYYBpMrJSZ X-Received: by 2002:a9d:6d0e:0:b0:6ea:126a:bbd0 with SMTP id o14-20020a9d6d0e000000b006ea126abbd0mr5901217otp.14.1714041086272; Thu, 25 Apr 2024 03:31:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714041086; cv=pass; d=google.com; s=arc-20160816; b=itK+7bEyJu5aGN0G1clUqPdZypD/ichqpRykdRW5SEO0GWhVQbZmHe8iPm4EMPxZh1 Rs+XouvKiojz6HFVYxWuk00tQ/1udcpbbewWXjefTHqzmL1KIdSfnruMtKMXZpdZZJzc hKoqxfgfxxe0UJEcFZnqd4vF5aU2F9q2dERoljauV0lCN8Hvk0tWdZxjaVftXUL8XRVz n40q33YDswZIvym0wR83kB84hh7izRcgFDLZs0yS9R3lPA/YrPo3WfmqzMtEDXgl9UVs nnf/0Ro8UsctRgnVKQuMe8RkfKNv/8svKlhb18gItrhZwa00PVCstxeIa40oOKuPYscM VuVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=xN9PtKBvyMktmSfmEeNUmxWtUYxk59jPOkkFgsg7R2o=; fh=ac2hJnapNVPK17ICEyLOQICiWWtYkv0dWUXgiHv8If0=; b=JdNvkM+RrCaPyfM2xuENxvXd3i+EZy4jIbN52ndFrqzxaNkXSqNMIqMKSOfIzC2M9X YXqzqtMWEQsOCz6ePppy8YGnit/L65CU5Og3nB7f6fghuMvx5dWpEAbpqSEmCqa0Ulpk uT2ixfA75Vd3k0eDBtaRUGuwxYiPXRub5WUFW7JEtCmuyLoRF++efTatTZ/T1FYHAuCs KlJBACYNbwiI5E3x6aXcpvv2Ulh3AbtgjVQfvZSMEwAVChpzi3sbfDWJj6osfKmdoRvA Zz3o7Mhb3wUvcOzjNn1k609dLypVOudltKFqXvYLt862nWpquXQk5mv3XXHlODA4Qa8g ALtA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Dxlnf/mo"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-158394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158394-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e4-20020a05620a12c400b0078ec311648fsi17318780qkl.364.2024.04.25.03.31.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 03:31:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-158394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Dxlnf/mo"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-158394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158394-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E17A51C24035 for ; Thu, 25 Apr 2024 10:31:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E3D31DA3D; Thu, 25 Apr 2024 10:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dxlnf/mo" Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D55FC2031D for ; Thu, 25 Apr 2024 10:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714041074; cv=none; b=sjhJ95cpM9vqlaa5gil9v3ZKzW82AG8DbvX0y+BNrYKlg7VcmxcOLYrFISEl8gzvrii72q5rYf42klK4NgGTjcUR8GoR4+iqGto5XZuGfZXYD6JgVTMFABmmLZWWOlz1/pBPwPTLu3uChUlpxO3ggp5EoLBQKXrTXRhLSpAkN/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714041074; c=relaxed/simple; bh=xN9PtKBvyMktmSfmEeNUmxWtUYxk59jPOkkFgsg7R2o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SRx2U5Z2NU/Ug5EBRM5gZURQ2MWHISZA1Fxjs1FpEjygfQQ5SccVTWecORHNkr3o8AgVTGUXBopGXreN4NjhSlGmm40jik8iGGHcpsYQQmiITy70s9aUPV7jtbjgFfFh5YgxUA2RQxwhJ5DKx5RP9lTt/UM01qHH1RbSOHwv2v0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Dxlnf/mo; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5aa1b7a37b5so450075eaf.2 for ; Thu, 25 Apr 2024 03:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714041072; x=1714645872; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xN9PtKBvyMktmSfmEeNUmxWtUYxk59jPOkkFgsg7R2o=; b=Dxlnf/moo14SsVqyHA/PQOXlfZmr6ZihgMMXZPQbNsoq6DN2Uw5TkRu5yWnmVqCTxo FGoxjlTiKTsVJs3Aq5aa+7dVDc8/zccq6VGlmkr4h4AHurD+f/iE/FtYWabLYbfCYEie tosakCbp8T9AVkLbF+chNAd7rjaljSRRgHyMoBS/ASn+HllLnCgWGddcUlbJfDFzRtQM JY7HS4YvSH+XC3m+5tR7RU20VLsfwgKnSp9nYNOim+zlYMq8LPW7BF2s9jTueNbj5WFW 8wkLWIOdyXyMQUyWGMTrLwp1Vd4albeZpOq5/Z53mL9kCZ4H2QX7S8pgLJ7/0VVJpwkm VGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714041072; x=1714645872; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xN9PtKBvyMktmSfmEeNUmxWtUYxk59jPOkkFgsg7R2o=; b=T6AcUGlASQhTKPSw39GYTq4NQg+8FpufF92AMBNcb2Un3L+cqo6Vq9XH/xw18aVs7y JZAGsNSKT4QK1PTuBgOwQmSsENxrQSLlHWkfgjwqnjwb2zRe0Yrqpeu8+1TKArv9D3LM nnvfSuvRQq2Jf/YYN4EHT6EgNaTjxNIanB5Gyr7oSS9VGI1FlrE5ZK/dWwAbxBAeMVDS xJqq9pw3DqxXMMt/keZ/9EyuqtoGB1C7imyIKTHEas7S+VueY6ZAb25JWi2QpuQIxGSB n/A+BIacFN/8wBjZ1gJqMOZCfizorvOiwTcwRt+wJ71rTQFxsCfxqZfDV8ap80M6yKC+ +m9Q== X-Forwarded-Encrypted: i=1; AJvYcCXinteKjoLLVDqmXBtUTuan8g+egl44Cq/jJJkbVUm8Iun825fR0xm0QjDe3FUPxhd7Tqzwqc9F1Yc5ikE83+Gt8yn5SNaNeIQ2nfGk X-Gm-Message-State: AOJu0Yww0X5mgl3g6EAPZgH2WKnTackV+TVYUaCQHjxkTpB3N24h6d0e D2vHjThZ+OVASIV3ux/PfZ7cHFGNxGI63iqQrXp79+wSYMbHwLlvXRjN/4CuuHsKxwLHZZiYPMI THfs1tuAfncfEM8oxplRz511SbsulTgxUYgLKdQ== X-Received: by 2002:a4a:ab82:0:b0:5ac:bdbf:8a31 with SMTP id m2-20020a4aab82000000b005acbdbf8a31mr5448764oon.8.1714041071820; Thu, 25 Apr 2024 03:31:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240423205006.1785138-1-peter.griffin@linaro.org> <1c6f5984-7f9f-47e3-98c3-3c3671512675@kernel.org> In-Reply-To: <1c6f5984-7f9f-47e3-98c3-3c3671512675@kernel.org> From: Peter Griffin Date: Thu, 25 Apr 2024 11:31:00 +0100 Message-ID: Subject: Re: [PATCH v2 00/14] HSI2, UFS & UFS phy support for Tensor GS101 To: Krzysztof Kozlowski Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, s.nawrocki@samsung.com, cw00.choi@samsung.com, jejb@linux.ibm.com, martin.petersen@oracle.com, James.Bottomley@hansenpartnership.com, ebiggers@kernel.org, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com Content-Type: text/plain; charset="UTF-8" Hi Krzysztof, On Thu, 25 Apr 2024 at 08:08, Krzysztof Kozlowski wrote: > > On 23/04/2024 22:49, Peter Griffin wrote: > > Hi James, Martin, Alim, Bart, Krzysztof, Vinod, all > > > > Firstly, many thanks to everyone who reviewed and tested v1. > > > > This series adds support for the High Speed Interface (HSI) 2 clock > > management unit, UFS controller and UFS phy calibration/tuning for GS101 > > found in Pixel 6. > > > > With this series applied, UFS is now functional on gs101. The SKhynix > > HN8T05BZGKX015 can be enumerated, partitions mounted etc. This allows us to > > move away from the initramfs rootfs we have been using for development so far. > > > > Merge Strategy > > 1) UFS driver/bindings via UFS/SCSI tree (James / Martin / Alim) > > 2) GS101 DTS/DTSI should go via Krzysztofs Exynos SoC tree > > 3) Clock driver/bindings via Clock tree (Krzysztof / Stephen) > > 4) PHY driver/bindings via PHY tree (Vinod) > > > > The v2 series has been rebased on next-20240422, as such all the phy parts > > which were already queued by Vinod have been dropped. Two new phy patches > > are added to address review feedback received after the patches were queued. > > > > The series is broadly split into the following parts: > > 1) dt-bindings documentation updates > > 2) gs101/oriole dts & dtsi updates > > 3) Prepatory patches for ufs-exynos driver > > 4) GS101 ufs-exynos support > > 5) gs101 phy fixes > > > > I asked to split, otherwise please explain why PHY and UFS depends on > DTS and clk. Seems I misunderstood your feedback. I thought you just want me to make clear who was merging what from the series via which tree. But you want separate series? 1) ufs host dt bindings & driver 2) minor phy fixes series (most patches got applied already for phy) What do you want for cmu_hsi2 clocks and dts/dtsi? The device tree depends on the clock bindings to compile Thanks, Peter.