Received-SPF: pass (google.com: domain of linux-kernel+bounces-158516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a834a59d-9f31-4374-923f-ddd89780b62a@redhat.com>
Date: Thu, 25 Apr 2024 08:24:46 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in
 sched_partition_write()
To: Xiu Jianfeng <xiujianfeng@huawei.com>, lizefan.x@bytedance.com,
 tj@kernel.org, hannes@cmpxchg.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240425093016.1068567-1-xiujianfeng@huawei.com>
Content-Language: en-US
From: Waiman Long <longman@redhat.com>
In-Reply-To: <20240425093016.1068567-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 4/25/24 05:30, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
>   kernel/cgroup/cpuset.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index f5443c039619..a10e4bd0c0c1 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
>   
>   	buf = strstrip(buf);
>   
> -	/*
> -	 * Convert "root" to ENABLED, and convert "member" to DISABLED.
> -	 */
>   	if (!strcmp(buf, "root"))
>   		val = PRS_ROOT;
>   	else if (!strcmp(buf, "member"))

Yes, that comment is now no longer relevant.

Acked-by: Waiman Long <longman@redhat.com>