Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1089097lqd; Thu, 25 Apr 2024 05:58:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWuLWsTj5cJ9at6uPS+8nLt8oTKXdYsl+hrgxQ5zM6WuLDb45yydmHExyIfJrMDCXDEfFbWk9Urvb8S5tXTWqzwAsx9vNJAXGRNPSFACA== X-Google-Smtp-Source: AGHT+IH8Vc4DoFPq4mueD2yAifNj8KRpDwmj39liLkyyffXg1b35gwiHhuaBzaobabP3krZetkvp X-Received: by 2002:a05:6a20:3204:b0:1ac:4219:b817 with SMTP id hl4-20020a056a20320400b001ac4219b817mr5118838pzc.16.1714049931961; Thu, 25 Apr 2024 05:58:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714049931; cv=pass; d=google.com; s=arc-20160816; b=D9R2AZCiTRQmdOjfubNXBD9yENKnD6cisKsroRcClz2ojWbdASYreLblyIgAiSYmzQ pUd7aLj6LgDd3lGq2/ePxF21HzkZFv3m9QsWPL5SG46o+CCTqS3UbKDoF9YZoH5HPqcV 1JaYk1skTPSTZ8O4F1TVcHDFN+UB5xZ+CWtqXWLTuxA9VcC+cdgfeakgi58IaxvJ7kOr GQwMgZh41XQqxrluQ/0Mn2cP4x1u2e3kwDEQ1fA4tXGqfFzNap9ggae0E75y8bB353j5 khqFpwIgLyrbpInAbFLHKUFo81VoCrQ7e5TUbEg2RAh2JRPjHgXODjJVQSJc+RI3JW1D vcig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qG/+pHxKsF0EjW0aqfIbxlagHCNmLhwnFQVaN8EkrzI=; fh=8RWZCsFcFW7tfRyjnxchvkKLz+fqJXf4t60QAFPbaoQ=; b=D/bs6KPg9aHMJRCYKQj3agHICrXlaaMgnrB3UUAivRgKmk1Pih9U6mky24pqNhb0tY EPHvuIy37yyYZYKv/V8pAXz3uZCs0SeS2FTrGC1+N2J5lFXUAgMPFGrVhhBHmmCp4S45 mheP8ZEnhY7f2o98wzJC4pSDshzxiMzJnX24+pGc7d132Re8csck0GSV6ZlIoe8FlzJL ewiQifdOFJgbTRmBq14sFYkVOeNU+xBpR+TGrfXwKT/1KHBigyYWd3gJ8q2YfW9w5k2U c2+c1y+lxtlhLfcF6ARuFJnZ+9pCHsc3EfDKVecsQmGV2qL6oMqqT3NKMKOCiF3XExGz Rsew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qTgf5U0F; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-158550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158550-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id f8-20020a170902ce8800b001e462e42228si13531785plg.547.2024.04.25.05.58.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 05:58:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-158550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qTgf5U0F; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-158550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-158550-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BBA3BB27254 for ; Thu, 25 Apr 2024 12:49:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13A211494D5; Thu, 25 Apr 2024 12:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qTgf5U0F" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E119827715; Thu, 25 Apr 2024 12:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714049386; cv=none; b=Vhtob1+9dKZt0fZN+iNBSR1tZGPg9nC2a1dq12C90H1SdzSV8t739xh7KF0ZrSl0PIXqYkiMhjfgMb4F+QJRcUQItjYmSzopYoRWF7iqzC5W52syoK4Oy3YqAZYlKolhlw8LBnFahvBQwyafRgXIgSNrczIuWolBidyLHis+f9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714049386; c=relaxed/simple; bh=Q0rC6Dg58DuHJs63AQMz3PHeklpFh0kC3hGfFEJpx5g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WLtN5nRoqRsiu+u01vmm22xxUX98rkaaXpp3dDtH6IQfdCY9uPPTZbpbCGP0G+vWdGMTuqsK7RR10utWFbfe6JukB8K5MVhky9F1qiYTEQwZgaHd0L9hh1L0+9IdLDx5jktbt6xArMixmweI7JdiUd1NX7PZzVoW4Uz0LNbKmFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=qTgf5U0F; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=qG/+pHxKsF0EjW0aqfIbxlagHCNmLhwnFQVaN8EkrzI=; b=qTgf5U0FU8QWZno94l4Qit5vhd 2gOVOZHD/qrfAxf9yqFl/Gui9Xh8UKSAv+qlpXToy+NUlp8TEdhg11ZE4fr/scCGtsLssCnNF9WGm BHytA9YXTYwqGGn7WL5Y7QimDOeh5bPA8EA1V53qxsh83fWMsARGbgKwoe83TAYeYY8w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rzyXa-00DywX-3U; Thu, 25 Apr 2024 14:49:30 +0200 Date: Thu, 25 Apr 2024 14:49:30 +0200 From: Andrew Lunn To: MD Danish Anwar Cc: Dan Carpenter , Heiner Kallweit , Jan Kiszka , Diogo Ivo , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, Vignesh Raghavendra , r-gunasekaran@ti.com, Roger Quadros Subject: Re: [PATCH net-next] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers Message-ID: <2a4bea87-04bf-4373-8220-69650b435710@lunn.ch> References: <20240424091823.1814136-1-danishanwar@ti.com> <98588a89-4970-4d75-be8a-ac410d77789f@lunn.ch> <1c5809f2-b69d-48d1-8c27-285f164ebeb8@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c5809f2-b69d-48d1-8c27-285f164ebeb8@ti.com> > I did some benchmarking today with, > 1. Default driver (without any IRQ coalescing enabled) > 2. IRQ Coalescing (With this patch) > 3. Default IRQ Coalescing (Suggested by you in the above patch) > > I have pasted the full logs at [1]. > > Below are the final numbers, > > ============================================================== > Method | Tput_TX | CPU_TX | Tput_RX | CPU_RX | > ============================================================== > Default Driver 943 Mbps 31% 517 Mbps 38% | > IRQ Coalescing (Patch) 943 Mbps 28% 518 Mbps 25% | > Default IRQ Coalescing 942 Mbps 32% 521 Mbps 25% | > ============================================================== > > I see that the performance number is more or less same for all three > methods only the CPU load seems to be varying. The IRQ coalescing patch > (using hrtimer) seems to improve the cpu load by 3-4% in TX and 13% in > RX. Whereas the default method that you have suggested doesn't give any > improvemnet in tx however cpu load improves in RX with the same amount > as method 2. > > Please let me know if this patch is OK to you based on the benchmarking? It is good to include benchmark results in patches which claim to improve performance. Please add the default and the patch version results to the commit message. The numbers show your more complex version does bring benefits, so it is O.K. to use it. I just wounder how many other drivers would benefit from a one line change. Andrew