Received-SPF: pass (google.com: domain of linux-kernel+bounces-158566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <63b89455-3e30-421a-a082-00d39e836e20@intel.com>
Date: Thu, 25 Apr 2024 15:00:14 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] PCI: dwc: keystone: Fix potential NULL dereference
To: Aleksandr Mishin <amishin@t-argos.ru>
CC: Rob Herring <robh@kernel.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>,
	=?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>, Bjorn Helgaas
	<bhelgaas@google.com>, Manivannan Sadhasivam
	<manivannan.sadhasivam@linaro.org>, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?=
	<u.kleine-koenig@pengutronix.de>, Serge Semin <fancer.lancer@gmail.com>,
	Niklas Cassel <cassel@kernel.org>, Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@renesas.com>, Damien Le Moal <dlemoal@kernel.org>,
	Siddharth Vadapalli <s-vadapalli@ti.com>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>
References: <20240425092135.13348-1-amishin@t-argos.ru>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240425092135.13348-1-amishin@t-argos.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjBnL2ZFNHBBMTBhc3pJZkRETWhVQ1RtYnRha0s0R1RrVUhkZGdkWUJIWTZ6?=
 =?utf-8?B?Y1lLeGZkTGVJYWQyRlJjNnFDb243bkk4aURnMFRnZEpkdkJFUUdOSmNqanpB?=
 =?utf-8?B?SXZQMzcrMmZLUmhzU0thYk1UeUYrS0RtK1UwUk0weTRpKzZ4N1AyUXhJZ3RW?=
 =?utf-8?B?cEpmLzI5b2VoMEE5MnBVTWliMWU2UlBWMzh4bnB5UVA3SGY3b2wveGJyb2xF?=
 =?utf-8?B?Q0lMZVVBNEVWUHNQcWZ3aVFiQXpNZldBbmF5VjFrODZ6TUxIYnZlanFDeEh3?=
 =?utf-8?B?TzQ4QUxrbnlXZmREV1FVY096YUMwbDJGSUh3cXMzZzJQTTZTOS9jMUl6RTlX?=
 =?utf-8?B?eTc3KzJpbUN5dEFjZlZZTmlLL3MvTGRYMm5vVjIrdHdLTzdGYU9XL2pVV09U?=
 =?utf-8?B?elBRV0JTZ25GaEcwQWtYejF1N2NMWmlMK1R2bE9CbkNKaC9JZ3lmN0FqMTIy?=
 =?utf-8?B?dkdueUtYdktQU3RONEFhWDB1bnhNNEJlRFFONlYxL1Y2andnUzN5U0RTMHla?=
 =?utf-8?B?RnFvUmwzZFZHZGNqbTBZSVQ3RkRoSE4rL1BoeWpNamlzNmJhOXl0ZnNSTjdo?=
 =?utf-8?B?NHdnaTI5RzUvK2dyS1MraXcyNE90ZWdTUFlBSnMrNHRiN0lxRnBGWUZPZ3RS?=
 =?utf-8?B?RFFEbGZxazdzY3VEVW1MYkc1MUVBL3ozbHlZSGJwUkJ2UEJrRnpQemgydU5R?=
 =?utf-8?B?eDF3Zk5uanBBQ0tIRW5RRnVvWDE1QTZiNkN3bUI2d3ZQMmJyK25PT2tJbmtj?=
 =?utf-8?B?N3RlODE3djJWL3ZSNHRhRS9kZ2tHd1Z4US9QV1o4UUVGNGpMdnQzaUtpd1NV?=
 =?utf-8?B?OXdMVktnOG1xbzRFQk1rMFJUV0tidE0wTSs2UVpGZHFCS29JMWxqcjZvYkU3?=
 =?utf-8?B?V2l3elpRRElzRDhiODE1K1FsVkNaS0g5SDJKNVRwdWovdnRDSzBFS1FZM0dV?=
 =?utf-8?B?N3lxc0Vud0dDSlQ1eFBUZm8yRUZwekFSMUtIeDh5SU1Ud0ZLU2ptSXR0N25p?=
 =?utf-8?B?bnVnMi9FTG5LRjl0ZXQ4QlhoUzI2aUZQOVpsbnBsNlFtUnAvR1NjSm1kZEtN?=
 =?utf-8?B?aGoxZDRDckVVbHRpK0JMdStWMTV0UGIvd1F3amlFbkRreGdEalYyS2VadTdZ?=
 =?utf-8?B?NFZtNWJNYTdFaEF0cDBIdDJ5VExDSUI2Tk0rdlYvb1Q2a2w4azZVRk5SUnhD?=
 =?utf-8?B?N2kva2NRbzlRY0xxZTNvb0U2RmtCaUhxRFFIN1JOUk5XKzdSdWtFQjB0ckcy?=
 =?utf-8?B?aUVZdkNpdDNNSkRyWW04Q2xTSXBLYjJLUVpVUGtFMm4xTksrMy9JUzI5KzZw?=
 =?utf-8?B?QW1PMlRnU3A0UjVGajd6U2VnM25jVE5CMStLQW1IaEJ1TmRFdEQrRTl4cFB1?=
 =?utf-8?B?ZllyNnY3ZHhLcUFZc2UwbzlGc3Y1RThMQjdKYWREb0ZVeGtQRU1rb2JJTURW?=
 =?utf-8?B?WG5jZXZYY3BBQWgvQXh6NllRRGRJMXhGRkxWd1NFOHozZmdiaXJrSm1BVmFZ?=
 =?utf-8?B?YnhscVlPVXJSdHNTM05IUE5mRG9ZTURTUmRnaGplZ1g3TFFrdWJzNlQ4T0hI?=
 =?utf-8?B?eGR5YkFUZkgyZGlobDhCUFhkTWt2a3kyd3JIMHM4Ukdsb0RtTFhjQ1FheGZj?=
 =?utf-8?B?dFNtZlFEVVBzOXdKbWdxc29VZUFFUk5tbURqRllrL2lwOWdST2Z6bndRNVho?=
 =?utf-8?B?OWVWaC9qSjNYOEd1M0pRTE96YnQwclRleGtKdXRVaDh0b3ducFd5REp3Z0x3?=
 =?utf-8?B?cFd1bE5wZmI5TWRWT1I2V2lBREhxc3Z6OVE0eTcybERkSkE1Ry9LZldtenVl?=
 =?utf-8?B?TkdTZmF0UURmRkZHUHArNjduUTUxbU1zd1RuZDVqK0Rlcm9Vc2tubWxNK2gv?=
 =?utf-8?B?TlFYa2lRVnp4SUlQK3NXSUJhTmxDaDBvZ2VFd3pjNnBIUkNmaW9LOHoxWmVv?=
 =?utf-8?B?ek1YL1ZMcjNHcmVNY2dDQ2UwWFhXTWZiaVlGV2FSeEcwUDBCeTk1em5wSEVt?=
 =?utf-8?B?WWxmRE5hais3R05Fczg3TTFmbURGWkFQdG80MXlTblhhaW9wWnVseC9GTjJV?=
 =?utf-8?B?bEZxTnM2Mk5MRmtpWU1UeGxCRWVpZmpoY0VhNTVkdnJmOTVWbEdQRkV5SEFW?=
 =?utf-8?B?Q1RZU1hKWDdndG9nYldROUdHYkhWNmlvVDV0YmtPNnhHMXJUSDBsTnNSaWJx?=
 =?utf-8?B?eEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ff08cef0-90d2-4e08-6c84-08dc6527aa34
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 13:00:21.6060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6P5+jqXaf/bVZslPquaKpPZdHn6yG5T9l03c+KwSY6/5V3aRdRgabGf+rcu7FmvT2kvAKqzML20pCO2YXbz6e7S5zKwRbnCrxAS1gh/YR3A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6430
X-OriginatorOrg: intel.com

From: Aleksandr Mishin <amishin@t-argos.ru>
Date: Thu, 25 Apr 2024 12:21:35 +0300

> In ks_pcie_setup_rc_app_regs() resource_list_first_type() may return
> NULL which is later dereferenced. Fix this bug by adding NULL check.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Please stop spamming with "potential fixes" made mechanically from
static analyzer reports without looking into the code flow. These
patches are mostly incorrect and may hurt.
Either have a stable repro and then fix the real bug or don't touch
anything at all.

> 
> Fixes: 0f71c60ffd26 ("PCI: dwc: Remove storing of PCI resources")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>

Thanks,
Olek