Received-SPF: pass (google.com: domain of linux-kernel+bounces-158647-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <96624d87-2198-4176-9b98-208595380132@collabora.com>
Date: Thu, 25 Apr 2024 11:01:38 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm: ci: fix the xfails for apq8016
To: Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Clark
 <robdclark@gmail.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 Sean Paul <sean@poorly.run>, Marijn Suijten <marijn.suijten@somainline.org>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20240401204859.24223-1-quic_abhinavk@quicinc.com>
 <357b6395-5fae-38c9-8b53-5edc9fcbae32@quicinc.com>
Content-Language: en-US
From: Helen Koike <helen.koike@collabora.com>
In-Reply-To: <357b6395-5fae-38c9-8b53-5edc9fcbae32@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 08/04/2024 14:04, Abhinav Kumar wrote:
> Hi Helen
> 
> Gentle reminder on this.
> 
> If you are okay, we can land it via msm-next tree...
> 
> Thanks
> 
> Abhinav
> 
> On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
>> After IGT migrating to dynamic sub-tests, the pipe prefixes
>> in the expected fails list are incorrect. Lets drop those
>> to accurately match the expected fails.
>>
>> In addition, update the xfails list to match the current passing
>> list. This should have ideally failed in the CI run because some
>> tests were marked as fail even though they passed but due to the
>> mismatch in test names, the matching didn't correctly work and was
>> resulting in those failures not being seen.
>>
>> Here is the passing pipeline for apq8016 with this change:
>>
>> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

I'm sorry about my delay.

Acked-by: Helen Koike <helen.koike@collabora.com>

I'm also merging it to msm-misc-next.

Regards,
Helen

>> ---
>>   drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
>>   1 file changed, 1 insertion(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt 
>> b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> index 44a5c62dedad..b14d4e884971 100644
>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> @@ -1,17 +1,6 @@
>>   kms_3d,Fail
>>   kms_addfb_basic@addfb25-bad-modifier,Fail
>> -kms_cursor_legacy@all-pipes-forked-bo,Fail
>> -kms_cursor_legacy@all-pipes-forked-move,Fail
>> -kms_cursor_legacy@all-pipes-single-bo,Fail
>> -kms_cursor_legacy@all-pipes-single-move,Fail
>> -kms_cursor_legacy@all-pipes-torture-bo,Fail
>> -kms_cursor_legacy@all-pipes-torture-move,Fail
>> -kms_cursor_legacy@pipe-A-forked-bo,Fail
>> -kms_cursor_legacy@pipe-A-forked-move,Fail
>> -kms_cursor_legacy@pipe-A-single-bo,Fail
>> -kms_cursor_legacy@pipe-A-single-move,Fail
>> -kms_cursor_legacy@pipe-A-torture-bo,Fail
>> -kms_cursor_legacy@pipe-A-torture-move,Fail
>> +kms_cursor_legacy@torture-bo,Fail
>>   kms_force_connector_basic@force-edid,Fail
>>   kms_hdmi_inject@inject-4k,Fail
>>   kms_selftest@drm_format,Timeout