Received-SPF: pass (google.com: domain of linux-kernel+bounces-158671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 25 Apr 2024 16:13:22 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Raju.Lakkaraju@microchip.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	pabeni@redhat.com, edumazet@google.com,
	linux-kernel@vger.kernel.org, Bryan.Whitehead@microchip.com,
	UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net V2 2/2] net: lan743x: support WOL in MAC even when
 PHY does not
Message-ID: <38718a9b-bc7b-45d1-b15e-f4fea628db3d@lunn.ch>
References: <20240320042107.903051-1-Raju.Lakkaraju@microchip.com>
 <20240320042107.903051-3-Raju.Lakkaraju@microchip.com>
 <22089299-a3e2-4cbd-942a-65ea070657b8@lunn.ch>
 <LV8PR11MB87003ABBCA98F00F3EEA9AB09F032@LV8PR11MB8700.namprd11.prod.outlook.com>
 <fb5a6f19-ae4c-443e-babb-cbbcf6ba5fc6@lunn.ch>
 <LV8PR11MB8700A34520EA2521BC5F59EF9F112@LV8PR11MB8700.namprd11.prod.outlook.com>
 <9c4f8fcd-ae95-4874-b829-d381928c5f13@lunn.ch>
 <LV8PR11MB8700D54F5E03440681BF0D449F172@LV8PR11MB8700.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <LV8PR11MB8700D54F5E03440681BF0D449F172@LV8PR11MB8700.namprd11.prod.outlook.com>

> If PHY handles the magic packet or phy activity (i.e. WAKE_MAGIC or WAKE_PHY), our PCI11x1x's MAC will handle only interrupt (MDINT from PHY). Not MAC's magic packet.
> In this case do we really call phy_speed_down( ) ?

phy_speed_down() is orthogonal to who does the wake. Packets are
packets. phy_speed_down() does not change that. All it does it drop
the link to a slower speed. And slower speed means less power
consumption. A PHY operating at 10Mbps uses about 1W less power than a
PHY operating at 1G. The numbers will depend on the PHY, but you get
the idea. Plus the link peer will also save a similar amount out
power....

If the MAC is needed for WoL, because the PHY does not support the
needed modes, you probably also save power with the MAC running at
10Mbps. Its clocks probably tick slower, etc.

But there is a trade off. When resuming, you want to go back to the
full speed link. And that takes time, a little over 1 second. So you
need to decide, do you want to prioritise minimum power consumption
when suspended, or fast resume?

     Andrew