Received-SPF: pass (google.com: domain of linux-kernel+bounces-158673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 25 Apr 2024 15:15:31 +0100
From: Gary Guo <gary@garyguo.net>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>, Wedson Almeida Filho
 <wedsonaf@gmail.com>, Alex Gaynor <alex.gaynor@gmail.com>, Nathan
 Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>,
 Nicolas Schier <nicolas@fjasle.eu>, Boqun Feng <boqun.feng@gmail.com>,
 =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>, Benno Lossin
 <benno.lossin@proton.me>, Andreas Hindborg <a.hindborg@samsung.com>, Alice
 Ryhl <aliceryhl@google.com>, linux-kbuild@vger.kernel.org,
 rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
 patches@lists.linux.dev, stable@vger.kernel.org, Daniel Almeida
 <daniel.almeida@collabora.com>, Julian Stecklina
 <julian.stecklina@cyberus-technology.de>
Subject: Re: [PATCH] kbuild: rust: force `alloc` extern to allow "empty"
 Rust files
Message-ID: <20240425151531.44df19f3@eugeo>
In-Reply-To: <20240422090644.525520-1-ojeda@kernel.org>
References: <20240422090644.525520-1-ojeda@kernel.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vu0KFpJylnFkDyAw6xOoeXsimlAE7+XF5xWhBzN3j2ICX4jLD0r29Wiaaicp?=
 =?us-ascii?Q?+lXFx3ZNEctbuwS3ycelu7A9HR4+nHF7pyWpRb/yPdlocnIqRpn/iR/givCU?=
 =?us-ascii?Q?9ZcDSYvo2HY9iQQUA0kd6z8UiQhSohSQVcUXKjXfI2k8NIgCeTfCrR9GqBc5?=
 =?us-ascii?Q?w9hNrxjtD6E0BdCjTp+5WSj6u84AQvTK/5oCrTZvxaRs6fsUPxyxzaxSQFQy?=
 =?us-ascii?Q?n2cqp6mGKDYtvzTeNg9lFuK27foUL7zKT3+FIguINhs2NPocAXfk7lXZQo8B?=
 =?us-ascii?Q?z1bho1TuGy60fF+YBNsDRPXu9bp0XowSGf8atW2gUl4mUcxVfcJOPEBswC8C?=
 =?us-ascii?Q?CCdtYs4cehTcDLQeMzOb7JuKvBLXGum4c6XVGg8x+f8YPNPqwFr/G/RiNdB1?=
 =?us-ascii?Q?YmDgJy9IgiSzf//4+QsXUMKKJ+YnQT+OMlTdtvoAxmOnIl7y6WjYRA4FtspP?=
 =?us-ascii?Q?D0QeKOl+8JBozMrHW64t62Swxe4okj3eU3AkQE8UqRTXPNOxeV6TL1qW2ZoW?=
 =?us-ascii?Q?tHry8ve/ctwcdWFytEL/UoAQ4NqLPdVDpXfx+6i1ZTuB2o4f5w/gApJyvFdV?=
 =?us-ascii?Q?AvBCroBfZuDjUXFbQDPf98sSxNgXYnh+6PAG1SG4kVTQEYBYqrHgoBxTca5p?=
 =?us-ascii?Q?CRZ/+xrVB+sjd64eGzF+5rs8hVZGWXail3gKsiRDLRDCUDEQCjyAc0PQThL0?=
 =?us-ascii?Q?eP6U4dl4Xk9dISkXH1PX2sbfR9XPRO+RahlufkwQ0jQ4rq+CY1EqIjZikLlk?=
 =?us-ascii?Q?S3qqcg4YqDvo9mY/BLsgyR6EMMk1NQi8re5lcDpY22oe7SYxo/MBjj3dp3rv?=
 =?us-ascii?Q?fKQUrCheFDfYhkA3jJrQQFKLAXIzewgvVeYeqVVPVUh//5A6If360QP/VnX1?=
 =?us-ascii?Q?NSFS+GdTo4/Y1jOOAiUK+4NgNcfN0jHOOj9wM972kPoLNo4jYtz81RxUuZeE?=
 =?us-ascii?Q?G3VH6kUojmHGD2mZ45MthCcKR0HOI9ItPF8DoxENmmUgnOf+I3L2pQgRyhB/?=
 =?us-ascii?Q?cAR3Ht8pgbqr48fjbmHW99GfT6aNs0pOlWt8IAwFLgtyX1uioHKv88FvBS9Q?=
 =?us-ascii?Q?HSB25ikobjfdvoiftWJVPMnmT32DXDcrh8vnbFlWAPIlrRoaFLas5YMRjzDu?=
 =?us-ascii?Q?Pv3LlFVz5LKS6ZmJS7NO0gEFG/NvsUY1zY4+P+kA1rXKo3mQF+LK6Lx+ogb8?=
 =?us-ascii?Q?tFEoYL8qODaGmjoRefTgcRpyMRLM1zhqUPm7tC2D1HJiMMyHZZ2n1tc8pInD?=
 =?us-ascii?Q?oaY802etECIii+SE/Kz9TSzYTDC1cDlwA4J6hXI6jZV7Ei9s7oV45fBaffJr?=
 =?us-ascii?Q?43GuhobCWOrLMrwM9fDhbI+X5emNi/u7tPAOUPPqYe6wW8odDH/QTGjgaLBG?=
 =?us-ascii?Q?YtNwiVR3Hnbkf7SO+nUd4sNawPReYQwwVS2e9aXc7lPiGSlxzcVG+75cvZUh?=
 =?us-ascii?Q?TvWVXYV7q6/i7XaeVG+PFQBp620A84aJFiY68+Z+j3RJ1SLDY2+X6NqS/emT?=
 =?us-ascii?Q?0Lmao5zVbS05VD4fZkc9XOeJh3gAZOoB3OS7igV1lDmWzCCQE84XY1rRvC/f?=
 =?us-ascii?Q?ORwM8Ixo+915MhMsQM22fjsAnpSxCQsttqSfZBjr?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 056671b6-4ae9-4b32-b88a-08dc65322c10
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 14:15:34.3847
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TybCqmWHl8QgxAT2YhNMdgF8J0izvHBN7aBls2W+ZIEGvhcebpwHHZ7dX/owMAqRvCGlRLUmFEikULt+0HWzDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO9P265MB7585

On Mon, 22 Apr 2024 11:06:44 +0200
Miguel Ojeda <ojeda@kernel.org> wrote:

> If one attempts to build an essentially empty file somewhere in the
> kernel tree, it leads to a build error because the compiler does not
> recognize the `new_uninit` unstable feature:
> 
>     error[E0635]: unknown feature `new_uninit`
>      --> <crate attribute>:1:9  
>       |
>     1 | feature(new_uninit)
>       |         ^^^^^^^^^^
> 
> The reason is that we pass `-Zcrate-attr='feature(new_uninit)'` (together
> with `-Zallow-features=new_uninit`) to let non-`rust/` code use that
> unstable feature.
> 
> However, the compiler only recognizes the feature if the `alloc` crate
> is resolved (the feature is an `alloc` one). `--extern alloc`, which we
> pass, is not enough to resolve the crate.
> 
> Introducing a reference like `use alloc;` or `extern crate alloc;`
> solves the issue, thus this is not seen in normal files. For instance,
> `use`ing the `kernel` prelude introduces such a reference, since `alloc`
> is used inside.
> 
> While normal use of the build system is not impacted by this, it can still
> be fairly confusing for kernel developers [1], thus use the unstable
> `force` option of `--extern` [2] (added in Rust 1.71 [3]) to force the
> compiler to resolve `alloc`.
> 
> This new unstable feature is only needed meanwhile we use the other
> unstable feature, since then we will not need `-Zcrate-attr`.
> 
> Cc: stable@vger.kernel.org # v6.6+
> Reported-by: Daniel Almeida <daniel.almeida@collabora.com>
> Reported-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
> Closes: https://rust-for-linux.zulipchat.com/#narrow/stream/288089-General/topic/x/near/424096982 [1]
> Fixes: 2f7ab1267dc9 ("Kbuild: add Rust support")
> Link: https://github.com/rust-lang/rust/issues/111302 [2]
> Link: https://github.com/rust-lang/rust/pull/109421 [3]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---

Reviewed-by: Gary Guo <gary@garyguo.net>

>  scripts/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index baf86c0880b6..533a7799fdfe 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -273,7 +273,7 @@ rust_common_cmd = \
>  	-Zallow-features=$(rust_allowed_features) \
>  	-Zcrate-attr=no_std \
>  	-Zcrate-attr='feature($(rust_allowed_features))' \
> -	--extern alloc --extern kernel \
> +	-Zunstable-options --extern force:alloc --extern kernel \
>  	--crate-type rlib -L $(objtree)/rust/ \
>  	--crate-name $(basename $(notdir $@)) \
>  	--sysroot=/dev/null \
> 
> base-commit: 4cece764965020c22cff7665b18a012006359095