Received-SPF: pass (google.com: domain of linux-kernel+bounces-158726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1ce0b581-4613-4899-ada1-5d322f006890@amd.com>
Date: Thu, 25 Apr 2024 07:40:46 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: Fwd: [PATCH v3 0/3] mailbox: zynqmp: Enable Bufferless IPIs for
 Versal based SOCs
To: Tanmay Shah <tanmay.shah@amd.com>, Michal Simek <michal.simek@amd.com>,
 shubhrajyoti.datta@amd.com, jassisinghbrar@gmail.com,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 gregkh@linuxfoundation.org, ben.levinsky@amd.com
References: <20240410170825.1132324-1-ben.levinsky@amd.com>
 <24bd320a-ba89-4ad0-a905-6915e00b705d@amd.com>
Content-Language: en-US
From: Ben Levinsky <ben.levinsky@amd.com>
In-Reply-To: <24bd320a-ba89-4ad0-a905-6915e00b705d@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVlsSVBOV1BGL0lCWkZvblEzaGxqc0I2NmdoL296NmlpcWhHdWJSOWVneFh3?=
 =?utf-8?B?UGpWeVEzNjkvWVZ4a1YxdW1taTUxK2NZc1lrZ1JxaHhjbmZ3NnpZcEtpS1Jh?=
 =?utf-8?B?dmJueDlGS0cvblZMdmRPZVBnek1OeUZ3NDJ6dTY3UTdGYXVEeXQrNkM4dUVT?=
 =?utf-8?B?SEJ6QzBTa3Nmb3ovZ2Z1Q0RsQ21OdVJvNWRQd3NsWC9rdStHSHgyYlc3OGxp?=
 =?utf-8?B?c0k1dThra0xhZzBGNXduRURUWHJmMUpJWXBvdWM5alZ0cXVKS2NJZzZwb21V?=
 =?utf-8?B?QU5qOWNIZm1TYUFTK1hZTm1JS2FYejBPcUlhS3lUWDlQNDNmUm9IZXJXcWIy?=
 =?utf-8?B?anRFYkRmRmNMYVVqbHY0VkNJdnN3UmY1anpjNHFiNUdqbUo4MHQ4dG5jSUFl?=
 =?utf-8?B?ZDU3aUdVU1FUWm1yTEEwR2NndW1zVjhET3pranB5QndjOXpKckVpNEZHbVpq?=
 =?utf-8?B?TzBtQ1VZWEZhdjFPZlJ0eWU0UXlRSVRVbHA4RjJLV1Bsa2R5TFowSmNBU241?=
 =?utf-8?B?NzNQUHl6eFkvUmlpcTU3OVJpOWFtV0UxOWVteUY1UzY4YjdWNElBMTF4bDlS?=
 =?utf-8?B?aVNSclBPcllqMkJEVE51a3kyb2VXTk9JQlRyRXNoU1VKQXVnbkJCclJ3UzhS?=
 =?utf-8?B?UVd0N1IvN1RyM0JZNnAzZFpYSGlhK1U4ZW1PcUVBOWhDcmdXUS9xcUF4NEZ0?=
 =?utf-8?B?dXh1SkdEenVYejVsRWd5NXMwZUpIY01tWW9aNjFoejNYclk4KzdnV01GRUdn?=
 =?utf-8?B?WlVwOEtkcXBjaWV2NnFaTGhUMG1YQm10ZEtDbHkwakQyS2VUTzcvQW1zYkIr?=
 =?utf-8?B?S1dpRlRuOHZjRjZlOGlCVHNpSkVUMUl1RWF4dmZPR0FIM0FnR29XaFNlN1FZ?=
 =?utf-8?B?Q0o4ZkdJczR4cUVsd094OXdUY09aZ0h0ODZuampjOHdDMnJxUVlRQUUvVkd3?=
 =?utf-8?B?d25CYWhtRWxCSjdXNm94NGtyTDRsWllPWXgwYjFFenEwVzRJSUoxQXVLWnV1?=
 =?utf-8?B?cVA2MDROZjFVdExnMXNTVEhZLzZoWEd1TEJ2SnpqVnc4QTBaYVdJNGtRYjlm?=
 =?utf-8?B?bjlTRThoZnlyd1FsUktIbW5GRzd4b3p4T1lRODJRZjBjSHZVblVpeFl4Rjdz?=
 =?utf-8?B?RGVuMXZqck9DWkhxZUdsVDhMeHFaNlUrQXA1VWZ5Rlp0b09ISFNTTkE3cHU2?=
 =?utf-8?B?ZDRiNThPdHR1U0Y4c2NZYXVFYnhjUFgwcmtWYzN6eFhSVi9yeEdDcHNOcTRF?=
 =?utf-8?B?ZkRpOE1oKy95NG5XL0lHUDdFYlR1ekNTY2hzZCsxdDdBUTkvbzNSLzd1RFI0?=
 =?utf-8?B?N1hnbVlvd3U2aG15b0Vod29LNmhMZWxXU0Q1bXBjMjU0TnBDTDhMTW5rSUh6?=
 =?utf-8?B?elJydE9JYyt3allmemxkaU9ucStSS3RUNDFLL0JjMmYrQXVrR1ZEYnl6ZC9a?=
 =?utf-8?B?TklYU0RTQVlqdHdyWHo4dE00MVZFektqZy9uYWdiMm9pdzJzVDZmUGNzMWlK?=
 =?utf-8?B?angxRUdYUmxRVFRZREFsdjk1bzFKcVRDMEg5b1RvWjFrYitGUmM2cEdDNG55?=
 =?utf-8?B?QUtLbkxQUHMyT2tMSmxLRkYvdGNzaVhaZlBRZWZXQmFMVENMWmFNdUdrQU9k?=
 =?utf-8?B?dmVtL1dBNEpOT2VqbkhUUzFvSkZxRW1WQ1hnUFE0bHMwZGUxV2xWaXRHZGhl?=
 =?utf-8?B?N1RlYzNRaFMvTDdKTHdJNmhGVDVEcWJIekJxeWtnemdlUHlUbkJBZS9EVU8y?=
 =?utf-8?B?dHRHVm1aK1BUQXNmTGRVM2RpQzZGOXdiWXYzenhJdGFlbEpHdGF0RlV6TXl6?=
 =?utf-8?B?VHpkNG80aTZYb3o1ZWE4Q1dMV1lGSjNabVVBNmRWTFJnUXA1Y01BcURhL0tl?=
 =?utf-8?B?Z2QrWk4wVlk3cFZUd05iUXZQOXVxeFZaUVpHdFA5MXpJc1I1eUtPNGZyK2Rm?=
 =?utf-8?B?b1lLMWsvWWN3MUVwRktESW1GK0FHcTlOOWlwckNzRElvQWs3NVd2Z3hmbEUy?=
 =?utf-8?B?Qjh4clo3TjlrWTRHdDRwaE5UUGFkYklqd1VsK29aaVBmUEROUXdWdnkyWEVK?=
 =?utf-8?B?Nks2WVcza0lQYWZKeFBoM0tzRzFWRHFaWndFUlVDS0EySWxJZFhHZFZhOGZn?=
 =?utf-8?Q?WStuhoOtkpJqwdl/a7hXL0gjM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7307370d-4e23-4fa1-02f4-08dc6535b507
X-MS-Exchange-CrossTenant-AuthSource: SA3PR12MB8021.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 14:40:52.5599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rbJxk7icmoIkXlC82tSpxUZB6PrIDQ1i3LRcjRcX+RYZh+jkCJMFGi0xxhWxdOiAlr8yEfuKALlU2MqAHA+9EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9186

Ping For Review
> -------- Forwarded Message --------
> Subject: [PATCH v3 0/3] mailbox: zynqmp: Enable Bufferless IPIs for Versal based SOCs
> Date: Wed, 10 Apr 2024 10:08:22 -0700
> From: Ben Levinsky <ben.levinsky@amd.com>
> To: jassisinghbrar@gmail.com, michal.simek@amd.com, shubhrajyoti.datta@amd.com, tanmay.shah@amd.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
>
> For Xilinx-AMD Versal and Versal NET SOC's there exist also
> inter-processor-interrupts (IPIs) without IPI Message Buffers. For these
> enable use of IPI Mailbox driver for send/receive as well.
>
> This is enabled with new compatible string: "xlnx,versal-ipi-mailbox"
>
> Original, buffered usage for ZynqMP based SOC is still supported.
>
> Note that Versal bindings are already present in xlnx,zynqmp-ipi-mailbox.yaml
>
> v2:
> - formatting in 2/3 patch
> - remove extra handling in 3/3 versal_ipi_setup()
> v3:
> 1/3 - removed additional newline to avoid
> ./scripts/checkpatch.pl --strict -f drivers/mailbox/zynqmp-ipi-mailbox.c
> CHECK: Please don't use multiple blank lines
> #434: FILE: drivers/mailbox/zynqmp-ipi-mailbox.c:434:
> +
> +
> 2/3 - remove unused variable dev
> drivers/mailbox/zynqmp-ipi-mailbox.c:565:24: warning: variable 'dev' set but not 
> used [-Wunused-but-set-variable]
>          struct device *mdev, *dev;
> 3/3 - remove unused variable dev
>                                ^
> drivers/mailbox/zynqmp-ipi-mailbox.c:666:24: warning: variable 'dev' set but not 
> used [-Wunused-but-set-variable]
>          struct device *mdev, *dev;
>                                ^
>
> Ben Levinsky (3):
>   mailbox: zynqmp: Move of_match structure closer to usage
>   mailbox: zynqmp: Move buffered IPI setup to of_match selected routine
>   mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's
>
>  drivers/mailbox/zynqmp-ipi-mailbox.c | 257 ++++++++++++++++++++++-----
>  1 file changed, 212 insertions(+), 45 deletions(-)
>