Received-SPF: pass (google.com: domain of linux-kernel+bounces-158813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: multipart/signed;
 boundary=914da399af0607f643709bc2fc1a510fd796868e26554216cfbbe1ea8aa2;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Thu, 25 Apr 2024 17:35:46 +0200
Message-Id: <D0TBBT7FZ3E0.14ZFOT5S4QZPR@gmail.com>
To: "Miguel Miranda" <mmikernel@gmail.com>, <jonathanh@nvidia.com>,
 <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <skhan@linuxfoundation.org>, <javier.carrasco.cruz@gmail.com>,
 <julia.lawall@inria.fr>
Subject: Re: [PATCH] drivers/soc/tegra: Replace dev_node refcount management
From: "Thierry Reding" <thierry.reding@gmail.com>
References: <20240424015306.1796838-1-mmikernel@gmail.com>
In-Reply-To: <20240424015306.1796838-1-mmikernel@gmail.com>

--914da399af0607f643709bc2fc1a510fd796868e26554216cfbbe1ea8aa2
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Wed Apr 24, 2024 at 3:53 AM CEST, Miguel Miranda wrote:
> Remove the manual refcount management of device_node
> and instead, use scope-based resource management.
>
> While the pointer never gets out of scope it reduces
> somehow the risk of missing the of_node_put() call.

I don't understand what you're trying to say here.

> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: Miguel Miranda <mmikernel@gmail.com>
> ---
> I only have a deprecated jetson nano dev-kit, but need
> to test this on hardware. I am exploring options to
> build a rootfs to test this using qemu-system-aarch64.

It doesn't look like it'll be necessary to extensively test this. Just
by inspecting this we can see that it doesn't change behaviour. There
isn't really a big advantage to employ the __free() mechanism here since
we have exactly one of_node_put() to clean up, but I guess why not. So
maybe reword that commit message to be less confusing.

Thierry

> ---
>  drivers/soc/tegra/common.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
> index dff6d5ef4e46..94d11102d90f 100644
> --- a/drivers/soc/tegra/common.c
> +++ b/drivers/soc/tegra/common.c
> @@ -28,14 +28,12 @@ static const struct of_device_id tegra_machine_match[=
] =3D {
>  bool soc_is_tegra(void)
>  {
>  	const struct of_device_id *match;
> -	struct device_node *root;
> +	struct device_node *root __free(device_node) =3D of_find_node_by_path("=
/");
> =20
> -	root =3D of_find_node_by_path("/");
>  	if (!root)
>  		return false;
> =20
>  	match =3D of_match_node(tegra_machine_match, root);
> -	of_node_put(root);
> =20
>  	return match !=3D NULL;
>  }


--914da399af0607f643709bc2fc1a510fd796868e26554216cfbbe1ea8aa2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmYqeFIACgkQ3SOs138+
s6H5zQ/9EMK+VQev1WAylRx3Sw+siqhIpJzdjWxcth+ARRVneIbGasJY05wGnXK/
DcQAbz5jtlTxh55f5VfwqpmU1KCmnnhmI8k1M5pgFUVgBzXhotHuGtSOs7efo0H/
2NmQirCL+fYZhhEhwWGbXVQ24zTISAeWPKIk6W9nOihc/3nyz1/MMLwMNL8XWbSX
tavXXFvNx4u86RF7RBDmFO0uK1AOutz21TfOzpCieTliS/O67O3Utgko3/Lgr6ze
2HuCQN6ex+wHguYlYWYccFGhyb94O/w8krQWrU6q9KlLkf5vtRQtJDaFHlHy8/vM
fzD+JCNWg2eyuIZl7PdxcDkBZCC9k6hjGucJ96VzCo+Y4Rhi+NLo1lQodGAuwc/P
xh9H9cs8vC3wk09i9zzecRIeIUZTJbFO+H96R4HWbLnwL/IFxfWA3Y2y42ma5RtU
9x3A6TO6NEVZsWs6VPF0qSaEydWbk+PRxMXYEmvCEAghbLh3F7zGIASkNJm8vfv+
5b3eW+G9SaQAJzEZ56jRDiBF6ckEYq0aSuLGaPOhPizS2uH04bFpxbJnaYb3Qe4U
MPjoqA8f3FVIn5fxsVMTRgdSL5zF87KaRZDpAipumrlVjnHzyqiryVrlr35XZ3vt
F6mYy5jTrUqJHNr+ymUx9R+V4VI+U8cithp4pEwK1QulCm9m/co=
=Qpbs
-----END PGP SIGNATURE-----

--914da399af0607f643709bc2fc1a510fd796868e26554216cfbbe1ea8aa2--