Received-SPF: pass (google.com: domain of linux-kernel+bounces-158770-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e0fb41f3-3080-c1b5-ab7c-bcff8bbbe754@quicinc.com>
Date: Thu, 25 Apr 2024 09:07:37 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v5 1/3] bus: mhi: host: Add sysfs entry to force device to
 enter EDL
Content-Language: en-US
To: Manivannan Sadhasivam <mani@kernel.org>,
        Qiang Yu
	<quic_qianyu@quicinc.com>
CC: <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_cang@quicinc.com>,
        <quic_mrana@quicinc.com>
References: <1713928915-18229-1-git-send-email-quic_qianyu@quicinc.com>
 <1713928915-18229-2-git-send-email-quic_qianyu@quicinc.com>
 <20240425145450.GH3449@thinkpad>
From: Jeffrey Hugo <quic_jhugo@quicinc.com>
In-Reply-To: <20240425145450.GH3449@thinkpad>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 4/25/2024 8:54 AM, Manivannan Sadhasivam wrote:
> On Wed, Apr 24, 2024 at 11:21:53AM +0800, Qiang Yu wrote:
>> Add sysfs entry to allow users of MHI bus force device to enter EDL.
>> Considering that the way to enter EDL mode varies from device to device and
>> some devices even do not support EDL. Hence, add a callback edl_trigger in
>> mhi controller as part of the sysfs entry to be invoked and MHI core will
>> only create EDL sysfs entry for mhi controller that provides edl_trigger
>> callback. All of the process a specific device required to enter EDL mode
>> can be placed in this callback.
>>
>> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
>> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> 
> All 3 patches are applied to mhi-next with my reported changes! Since you are
> doing upstreaming for some time, you should know that the changelog _must_ be
> present in the patches itself or in the cover letter.

It is/was in the cover letter.  Was the format not to your liking?

-Jeff