Received-SPF: pass (google.com: domain of linux-kernel+bounces-158880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 25 Apr 2024 09:18:53 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Dan Williams
	<dan.j.williams@intel.com>
CC: <linux-cxl@vger.kernel.org>, Sreenivas Bagalkote
	<sreenivas.bagalkote@broadcom.com>, Brett Henning
	<brett.henning@broadcom.com>, Harold Johnson <harold.johnson@broadcom.com>,
	Sumanesh Samanta <sumanesh.samanta@broadcom.com>,
	<linux-kernel@vger.kernel.org>, Davidlohr Bueso <dave@stgolabs.net>, "Dave
 Jiang" <dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	<linuxarm@huawei.com>, <linux-api@vger.kernel.org>, Lorenzo Pieralisi
	<lpieralisi@kernel.org>, "Natu, Mahesh" <mahesh.natu@intel.com>
Subject: Re: RFC: Restricting userspace interfaces for CXL fabric management
Message-ID: <662a826dbeeff_b6e02943c@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240321174423.00007e0d@Huawei.com>
 <66109191f3d6d_2583ad29468@dwillia2-xfh.jf.intel.com.notmuch>
 <20240410124517.000075f2@Huawei.com>
 <66284d5e8ac01_690a29431@dwillia2-xfh.jf.intel.com.notmuch>
 <20240425123344.000001a9@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240425123344.000001a9@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nx96QE+gB17Xw8eXcjk3fO3WJ4k3VU1LB1YntVBVgeKCHaKWKPdofUW1gax0?=
 =?us-ascii?Q?GK7dEyzDlI9yt8y3G8VSg3xjreH18zbgsU/IIYmDmwJLtKN6/IlWi1Mix5BI?=
 =?us-ascii?Q?vMSahMI2cy3J0JIPKdUFr32xKEfD/v5CSp0gUsHh6bAW+t/FaHgddhj3Cie6?=
 =?us-ascii?Q?vUlaoTnPwRRC4duSdGfhM4xe7t+Ft5yoTNI5Jxt/fWlESEPZ1FtS6n6epyWS?=
 =?us-ascii?Q?L8f56CCxPgKQDC7vgdyB+8qQbMr5X+hCVbxozDigOkBHfc5yEmGIp+emoEXn?=
 =?us-ascii?Q?HZ/SmxhT2KZbeIDWQTEfOw+0Mqp/UhqdhnFSaNki3ACMvZCDENpB8cEF34lM?=
 =?us-ascii?Q?6ufIssvqx4v5ezVqiRTeNCpvmx0oOAfHmC9olPV1paV9RYZ9apwNL99yoSA9?=
 =?us-ascii?Q?+u5lsFH9pQopk5zTwVGKv8Gw+y2fVK5PLkaRDNO2NUba0g5SCNxcFh4T5HlX?=
 =?us-ascii?Q?X4Vi85ZdaWZvb7L0zBwQ7MKm3+DWrFNcEFEK162fsYM2C/HnvhmZkLAQCB/J?=
 =?us-ascii?Q?7Ds4DOWMZRdujonoSbpD7q3a8B7zlZ6GorxI6ITxhRM3hZdCGisSA5Gpvkjp?=
 =?us-ascii?Q?LF4IafNv8lh3xBKW2oqudnZJVZYDW2JNHYspEFHY4M8J8MvDIKqtFjq+O52r?=
 =?us-ascii?Q?aYvycAI3SgV42PeRzWfDzne07VOL4t3MxFwI5+QAAuKXxGQ+iPhiAqt0IPAS?=
 =?us-ascii?Q?0vG14SDpijR9eepIEWQX4SXdc0dKs/l1hiouFkwk/BOIr6x9WOvQClxx4NLs?=
 =?us-ascii?Q?bQJT9DkMIuyLhrEQ0pRsf8dyAMnaJza3vSdfegG9ZhNxO5Z1V4VcQPheypc/?=
 =?us-ascii?Q?OiLdPBQymWqGLX77V7lwwolYj0Z8mwPXn2k1Pajs1KwmzJ+A5rqSiTcRRvUR?=
 =?us-ascii?Q?sXds9frpzUN6+SvVwcovMzj/SmYsdbyRP16doFUMuRPGjmpsodSKURtDEfgC?=
 =?us-ascii?Q?qno9fwQFhbEjqKFV4007vtHsmUXdCsyJi28rMpZqo8WcR0zL/L+aLfpbtKQ1?=
 =?us-ascii?Q?vwgdbtbEJuZ3yFL91S8ofNf7i+CCc0Ey7Tg5nFy9rWWHxsWHNFefJponduGe?=
 =?us-ascii?Q?nPFeYY7NJprKSHY0yMXH+7BnCeMXL1OaswNyuDql0U3r396ECgXz++ft+13M?=
 =?us-ascii?Q?DP25mb+Yze4cASz+bqOSNKJ6Uus/z2Bsmj/Mb/Sp3Ko7WhyiptllB1F9iEcB?=
 =?us-ascii?Q?2GE+6ATO+tqwiOyOsfbJayoWX7dXxrFtJD8VFuywP5Fn5V6OTVtoLHj/0+bY?=
 =?us-ascii?Q?FrnkUbxpjixruYn+MiLGAE6QLxuprr0m0sR9Bq1/sfB5F3NJrRax0TKUZRMq?=
 =?us-ascii?Q?5zZ5E+zH55mwJzi9958hpsUJBjGuVpMZO/rMKaSRARtKXY11zz6twq1odmmZ?=
 =?us-ascii?Q?5g6wwM+SvNVHIH/Gnn9wzOM78cj4u5zUaqFvyDtmaW0eEW0FTwLZayR3BzKB?=
 =?us-ascii?Q?1E5JokSAzxdynoLqhU5kW+1Ni0u64Pp7bDLvriSHSdpWi5jDXo5kI1BcK/SD?=
 =?us-ascii?Q?BYgH+XznBPKRPS6ljOXxprowiX9NGfR/wgGHxfPPuoXzVCGQ6QzjrH2fdeAw?=
 =?us-ascii?Q?fNM4ppP6P1WORo5sizRmciw8mp0eiBeiCW3WiEFbfyx3LC7gx+IHJ8pqps4+?=
 =?us-ascii?Q?Ng=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf106bb6-b8b0-430b-7aff-08dc6543685b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 16:18:56.9945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lD3i8NmPFAlB9MctKHMcvr506gjKtr9FST2BemrpTB3M13d+Ny/NfS61dmjBqRGT/hBb9SpKdFMMYnBqZm0yi5qQBgMM+YOiB5RPDbE72XM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7063
X-OriginatorOrg: intel.com

Jonathan Cameron wrote:
[..]
> > Also, the assertion that these kernels will be built with
> > CONFIG_SECURITY_LOCKDOWN_LSM=n and likely CONFIG_STRICT_DEVMEM=n, then
> > the entire user-mode driver ABI is available for use. CXL commands are
> > simple polled mmio, does Linux really benefit from carrying drivers in
> > the kernel that the kernel itself does not care about?
> 
> Sure we could it in userspace...  It's bad engineering, limits the design
> to polling only and uses a bunch of interfaces we put a lot of effort into
> telling people not to use except for debug.
> 
> I really don't see the advantage in pushing a project/group of projects
> all of which are picking the upstream kernel up directly, to do a dirty
> hack. We loose all the advantages of a proper well maintained kernel
> driver purely on the argument that one use model is not the same as
> this one.  Sensible security lockdown requirements is fine (along
> with all the other kernel features that must be disable for that
> to work), making open kernel development on for a large Linux
> market harder is not.

The minimum requirement for justifying an in kernel driver is that
something else in the kernel consumes that facility. So, again, I want
to get back to specifics what else in the kernel is going to leverage
the Switch CCI mailbox?

The generic-Type-3-device mailbox has an in kernel driver because the
kernel has need to send mailbox commands internally and it is
fundamental to RAS and provisioning flows that the kernel have this
coordination. What are the motivations for an in-band Switch CCI command
submission path?

It could be the case that you have a self-evident example in mind that I
have thus far failed to realize.