Received-SPF: pass (google.com: domain of linux-kernel+bounces-158922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9c96cf16-73a5-46c1-b4ce-de4e0561ba1c@amd.com>
Date: Thu, 25 Apr 2024 11:45:01 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/3] efi/x86: skip efi_arch_mem_reserve() in case of
 kexec.
Content-Language: en-US
From: "Kalra, Ashish" <ashish.kalra@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
 x86@kernel.org, rafael@kernel.org, peterz@infradead.org,
 adrian.hunter@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com,
 jun.nakajima@intel.com, rick.p.edgecombe@intel.com, thomas.lendacky@amd.com,
 michael.roth@amd.com, seanjc@google.com, kai.huang@intel.com,
 bhe@redhat.com, kirill.shutemov@linux.intel.com, bdas@redhat.com,
 vkuznets@redhat.com, dionnaglaze@google.com, anisinha@redhat.com,
 jroedel@suse.de, ardb@kernel.org, kexec@lists.infradead.org,
 linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org
References: <cover.1712694667.git.ashish.kalra@amd.com>
 <cover.1713222642.git.ashish.kalra@amd.com>
 <a3032e4b7a5406c26aeb66e9380043c410d07e3d.1713222642.git.ashish.kalra@amd.com>
 <20240424144807.GEZikbp0NjFP5AM_ms@fat_crate.local>
 <16b34494-7e5f-4feb-8a21-58e7b8fa97e2@amd.com>
In-Reply-To: <16b34494-7e5f-4feb-8a21-58e7b8fa97e2@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2xqNlJFbzhSd0pjZXJVRmN4MHh2ZmNwVlRsQnJNcnNCS1daMHk2ZjhBUGhy?=
 =?utf-8?B?ZjBZTGhxSDlKeUdnR3h2d3N1MW9ZRTJBeDVwNE5Jem5hZDlRS1hQOEVpUWFD?=
 =?utf-8?B?SUZhVFFzSlNnd3ZWU0s0eFRWNVdHWnJnU1pUTlVVRGJiaGNDWWRJdThCU0lI?=
 =?utf-8?B?SjU4V1NEOVlDTE5IL1E5eDVrbjRiSm5HcmJlcU44ZTcwSlNOK1VPWUlKZUFk?=
 =?utf-8?B?NW5zWk5Ec1J6cTVwYlpTVFE3TmZkNjBXcmVqdER5NDZURHNtTm9DZjQvSWoz?=
 =?utf-8?B?REU4dW9yS2ZCd0RId1J5aVRJS0pDdXBRSDhrWTlVWDVYSS9RRmNWazU1dkxG?=
 =?utf-8?B?aTVmNUt4blpIcjBLdjRJTjRPcC9PZ3Z5MzJsQkhxNWZtc21PQlZ0Skt0bFZa?=
 =?utf-8?B?UFFEZzArY2NNbTZSS3VyQWduL3ZuL0J4Tm9Fck4reXlzTElWS09tWU85Ym5X?=
 =?utf-8?B?cTRocGpsQmZHeVlvNnFadEE0dk1ZSzVLREpqK0c1VTBIY285dFB6Z3FVSDIw?=
 =?utf-8?B?MEM0Nk43Y1dZcngxY2huakFnOUFtNWUxWWFxUXBETG9zTTl4dG8rOFJRbW12?=
 =?utf-8?B?Y1hDZWtKN2lYZFBIMmdEd0Q4WXhjWDFKU2dnRUJVcUk5NlZZclU0cmhtc3hM?=
 =?utf-8?B?TWdtWUJkVzhrRnhObGR3NnJGUDRldG0rdVhyMFR1Y1N4UHlOZTQyaG9YOHA5?=
 =?utf-8?B?Z1FEcTAwZm9MVXprQm9WMVJ4ay9aS0ZKWVhOUkZvQ0RkTDJhVFZqaENNNDc2?=
 =?utf-8?B?L3VhK1BNbzI0LzV0ait6TG83TDV1TVgvWFRheWZkM3BienBCZlNFVzZlRjhh?=
 =?utf-8?B?bkIrZHJkcnNLZWs4bFZUZHB5Tk16VW5oVmRwdStJSEVmZ0pOa2c0MHJEbWZF?=
 =?utf-8?B?TEg2T2d0dkltWGRyenFhUlVDekowMnpHb1hYbFIyUCtsZGNaQkpWenZKeDFs?=
 =?utf-8?B?czVYZUR0WEh2SW9EQjROdU4wTTY3YlpYeEtscFhLQ0xoNEFHeEVTMmhTV3ZY?=
 =?utf-8?B?dWlnY210M0lvWWxTbmJZMVU0VXZjdUZOVklCUEJSVWUxM0FINWl0aGxYRlRi?=
 =?utf-8?B?NjdRejh4RGVpVzUvR0FYemcxNXdnUU9hNGsyNmQrUXliUDBZaTUrUVdXckVs?=
 =?utf-8?B?eFdwUm1mNUhoeXFIMUF5ZG1oWW9HSWlrcm9ZNlpGMTJRem9lUXRXeXhBUFFT?=
 =?utf-8?B?R0tSdXQyN2Q5SVZWRlVsajIzRWVmZy9nd2x4cVpra2tQSERYMW4wWU1ZMzht?=
 =?utf-8?B?YTI4YTNtclZrQUo5S2l5MzFyUVlQdFEvOThWMGJ4clU5Y2dQeE1ueHk0am9Y?=
 =?utf-8?B?ZXg4STdTSWZqencyZldWckg2Q1pFanV3eVlqV2M3MlV6SkZpMFJiaEs1bGlo?=
 =?utf-8?B?cFVXZEViUlhyaXErU0tUUm94b0d3UERyMGxwZkliSWRxUURwcjRnK0REa3dK?=
 =?utf-8?B?WllScTJFS1dJN0luMDdpM2g2d3NBeTU3VnE3NSsvWHhZbzZjQWMxUEpHUlhj?=
 =?utf-8?B?ckRocjZuNUU5VEhmblU3S1lJanpuSG9xLzVUN0pGalVzSHNFeXQxT2pZak5Y?=
 =?utf-8?B?c00xT1ZRRVJoRG9QcWtOVkUxZURacExTcXowQXdKRmIvT01rWjB0eHZ2OFhR?=
 =?utf-8?B?RWRaNWNmV080ZGFUK3dBOEJIWlBxOFZrY09EdkhxbDJPNS8xQWRWMVlSekgw?=
 =?utf-8?B?elhYLzEwMDNyN3BPUnZoSlMvU2szaENudEZlc3Z5T3E2ZXA2VFZucEp0ZE4r?=
 =?utf-8?B?QTVwTEhGRlBpMDE1N1dTM0N6VDd6R2dxTnRsaTFWSnJjN1M0T29ydEl6Zmth?=
 =?utf-8?B?d2RtUGx3aXNla0VKbzZHdzZndFl4MUFaL055OURpR21TbENOMXZNZGQ0TWNr?=
 =?utf-8?B?Zk52OHpaNWZjUlRXbm81MDVBM21IQ084ejVaMUE0UGRKQTJRb1ZsZHI0bmhH?=
 =?utf-8?B?dm02U0IwVi9wTkJyK05abExQWDY5N1ZRZVVPUlJjaEwrakh2cHo3UlFxcFN5?=
 =?utf-8?B?eHFNbXJFeGFUQS9jTmRVT0dLUVpDSlFITEFoSG9TK0hlT2t5dUZjR1VEQndP?=
 =?utf-8?B?VDlXZjJhb3hlOG96S09zdDFsUWQwbmdzdktEYlgrSHc1QW5LbXpHTzhHNjZp?=
 =?utf-8?Q?s6tJv8iNIXKeBWLALtLAEj4/O?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8119dc75-8e6f-4820-f638-08dc65470f73
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 16:45:05.8414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dcIYVy+eFTejDBVSvUgFSseVH9a02PLZO6tJqV1xO98zB+d7VllaC6GZean68G1kAidL2oiVLMTSHQsH3GCcoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4375

 >It sounds to me like you need to go back up, to the 10000ft view and
>> explain how exactly this efi_mem_reserve() causes trouble for the
>> kexec-ed kernel so that we can think of a proper solution, not some
>> random hackery.
>
> The above details explain why and how efi_arch_mem_reserve() causes 
> trouble for the (nested) kexec-ed kernel, additionally, there is a 
> another reason to skip efi_arch_mem_reserve() altogether for the kexec 
> case, as for kexec use case we need to use the EFI memmap passed from 
> the 1st kernel via setup_data and probably need to avoid any 
> additional EFI memory map additions/updates.
>
> Therefore, the first revision of this patch had the following code to 
> skip efi_arch_mem_reserve():
>
> void __init efi_arch_mem_reserve(..) {
>
> + if (efi_setup) + return;
>
> But then based on upstream review/feedback, the second revision of 
> this patch, updated the patch to check the md attribute of the EFI 
> memory descriptor instead of checking for efi_setup for detecting if 
> running under kexec kernel and the checking of the md attribute of the 
> EFI memory descriptor introduces these additional checks and pr_err() 
> which you commented on above.
>
> Hopefully, the above detailed explanation captures the reason to skip 
> efi_arch_mem_reserve() in case of (SNP) guest kexec, looking forward 
> to your comments/feedback on the same for me to rework this patch 
> (especially the commit message) and post it again.

<snip>

I am actually going to rename this patch to something more appropriate like:

Fix EFI memory map corruption during SNP guest kexec

And in the patch itself, go back to skipping efi_arch_mem_reserve() by 
checking efi_setup to check for running under kexec kernel similar to 
how it used by efi_enter_virtual_mode().

Thanks, Ashish