Received-SPF: pass (google.com: domain of linux-kernel+bounces-159128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i1719461a:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-386-g4cb8e397f9-fm-20240415.001-g4cb8e397
Precedence: bulk
MIME-Version: 1.0
Message-Id: <24c7a9ea-7755-4270-a338-4701c8e262e2@app.fastmail.com>
In-Reply-To: <a6009bed-aa34-4a3f-91f5-23937e915132@amd.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <a6009bed-aa34-4a3f-91f5-23937e915132@amd.com>
Date: Thu, 25 Apr 2024 14:24:45 -0600
From: "Lyndon Sanche" <lsanche@lyndeno.ca>
To: "Mario Limonciello" <mario.limonciello@amd.com>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
 =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
 "Hans de Goede" <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Dell.Client.Kernel@dell.com,
 "'Srinivas Pandruvada'" <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] platform/x86: dell-laptop: Implement platform_profile
Content-Type: text/plain

On Thu, Apr 25, 2024, at 2:07 PM, Mario Limonciello wrote:
> + Srinivas
>
> On 4/25/2024 12:27, Lyndon Sanche wrote:
>> Some Dell laptops support configuration of preset
>> fan modes through smbios tables.
>> 
>> If the platform supports these fan modes, set up
>> platform_profile to change these modes. If not
>> supported, skip enabling platform_profile.
>> 
>> Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
>> ---
>
> When you developed this was it using a Dell Intel or Dell AMD system?
>
> If it was an Intel system, did you test it with thermald installed and 
> active?
>
> I'm wondering how all this stuff jives with the stuff that thermald 
> does.  I don't know if they fight for any of the same "resources".

Thank you for your response.

I did my development and testing on a Dell Intel system. Specifically the XPS 15 9560 with i7-7700HQ.

I do have thermald running, though I admit I am not really aware of what exactly it does, besides being related to thermals in some way.

I normally set the thermal mode with Dell's smbios-thermal-ctl program. I am not too sure all the values that the bios configures on it's own depending on the provided mode, so I am not sure if thermald conflicts. But my understanding is that would be out of scope of this driver, since we are only telling the bios what we want at a high level.

Lyndon