Received-SPF: pass (google.com: domain of linux-kernel+bounces-159137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ae6a5b66-86e9-44cd-8484-1d218e7bc72c@amd.com>
Date: Thu, 25 Apr 2024 15:28:18 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: dell-laptop: Implement platform_profile
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>, =?UTF-8?Q?Pali_Roh=C3=A1r?=
 <pali@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Dell.Client.Kernel@dell.com,
 'Srinivas Pandruvada' <srinivas.pandruvada@linux.intel.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <a6009bed-aa34-4a3f-91f5-23937e915132@amd.com>
 <24c7a9ea-7755-4270-a338-4701c8e262e2@app.fastmail.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <24c7a9ea-7755-4270-a338-4701c8e262e2@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RGE5U0hhSGFTTXFZS0I5Sk1DSkJhaEVhM2oydzNEb21tVnZKUFdRNE9KeE5q?=
 =?utf-8?B?ZXhNZmNObnUwZXByM216NExuN2M2S1pIcGdCUi9RU3VRSnFxYlBzSEZ5aXR0?=
 =?utf-8?B?QlJFcjN3aWcxZVF2dDJBRkM1MnZmb2phRnFCSXV5dEdXQW0yTFZrcW8waE5J?=
 =?utf-8?B?dDJYekVXL21NcUtLdmhKVGFaV1VHWXpwZGxlaUhrdTZlN3JseWhsTHNGMzZK?=
 =?utf-8?B?bUVoUi9kYTZCV0t2VGJvTXlpOExlZE9SSFVqZUhMc2x5Ti85N3JNZU5qRjls?=
 =?utf-8?B?T1A2cks3QjJYN1Q2OE11UWVKUnc2UkJRcDFhNXhteExIVVY2ckUwWStEcmc0?=
 =?utf-8?B?UEhCTkJlN3NLOUtyOXBjUXhncCtTek1oQ2hkNEZOVCsrTm8ycXBrNkJVbEg5?=
 =?utf-8?B?WXA4cHF6VUlRZ1Vka01qeFVibm0yRnVGUitHKzlOZnFRMklVTXhKbTQ2NGZP?=
 =?utf-8?B?Z2loOHE1eEN6YjJWUXE4VklzQnF2SUhDU2Q2Y280UXkrVG4vVk9RYkZvNXBX?=
 =?utf-8?B?MzV3TU5vSUV3QmY2WTdSZWNlM2VkRk1iUU40aXU4Y2J3UmJ6N2VIUFFZTVRR?=
 =?utf-8?B?M1NyZi94L3RONFhCWHMyRzhvL3hJblRhak5rZnpEV3p2cjN6Q2xRZnh4VEs1?=
 =?utf-8?B?d1JYY3FWN3ZXcks3bGVPL3ViV3BoMXFPQ21VQm1udFVPSjVDZmFxWDB0bnIz?=
 =?utf-8?B?QVpNZ0FIa1VIUEVVRmwzRUpSbldMUDNCTS80dWV5a2NHdWZUMytiMVBSbHFj?=
 =?utf-8?B?V1lkcDdGUVJ5ajE2VjZFZ0JWZmVYWWhubHdOdE9KNTRHZU83S3pxNnBkWTZh?=
 =?utf-8?B?YlhXaGo0d0ljV3FTaVlVY3E5aURsY1kwZC9vVkRja0RWVjNPOGdZQXJUZnJ1?=
 =?utf-8?B?TTkzTnRGWVA3M1JFS21mWnI0eUpjNGppWXMzMDBxQU11NWVmelZPYjBTLzVM?=
 =?utf-8?B?b3NyUHZGV3NKNWhwRUF3bGZvU3N0OHBZRG9TUHE5d0tEazNYeXpZa1R3UmJ3?=
 =?utf-8?B?NTdYYmFlOVpVeDMxUEhqSjRjMHBuUEp4WEh4NkZCaGE4YUFZWFNKa1lnVkRi?=
 =?utf-8?B?UVUrYTd4bUl6VC9OeFQ2c3JDeFhhOER6MlNxOVd5aC9MeVNMRzBSRVhPelpH?=
 =?utf-8?B?aXVZaklNdHVWS2VjV3RVSnZrMnNaa0JHZ2JobHVrZURUczFBNGNoaVpTQkpm?=
 =?utf-8?B?RXVVRHQ0VzVjS3J1VjNOc2RhU3hDbEVhM215TlRTdDBUYkNPeFlqVlRpWHVG?=
 =?utf-8?B?bkpPL1ZNeWhKZjBMY29GYTc5MWh1ZTcrZ2s1L1M5ZkJFQ0pUM3pDVkZHZC8y?=
 =?utf-8?B?TC9CRHl4NW9iTnV2T1pEZlNTZGJWZzA3K3F1Vk5XWS9tSnRCZkxmb1ZWbUdn?=
 =?utf-8?B?WFJ3RWlka0tEZldVSzNyT0ZWcUhCK3RXUG1YZHhORzlWbUhtdDJPS0ZIUG9H?=
 =?utf-8?B?UzgvY3l4UVVDZ3pGNENqMDdzWkxCK0VtcnVITnVyVVdQRmdLOUhnUk9oV21z?=
 =?utf-8?B?YjYxTlpXV2xSaUU3cFYvYzdwNzdmNlg1LzBudHRHKzh5OUZGRitWaGhIZmR1?=
 =?utf-8?B?VE1BZjEzUWxhTkNnV3FFUUFYWHNheXJPYVhwWS9MU1crSlNKckF4a3I5ZS9O?=
 =?utf-8?B?Unovck03bnJOYllZRVlpS0E0QUpoYkJGNzRBMHV0cEpOTzEvN0VMdjRnY0hC?=
 =?utf-8?B?YUhFTzM4VW1XQm9MMHZwcXhBZEY2Tks3V0NJMlhKYnhoMEFpNzdkYWUzZS8v?=
 =?utf-8?B?VEZKQkg5Uy9ZSlBMQUNCZ09BU1JZY1pGYy9IKytqWERMbVhteS9jZkc4S0JT?=
 =?utf-8?B?MnRmS05aWjNtZ1cvSjhwWWxmQjB5NXFSa0ordmgzQ291U0ROY0J1YVNsV1h0?=
 =?utf-8?B?c0NuSE5kWTJSZ0VlcmJNa3ZzMlBIR0xMNG1IVUFta3ErNzBGRldrNUlUUFQ1?=
 =?utf-8?B?aUlkcjBEcXkxSk5UQWRiQ2pvTUlnRTZ1WkY0WHpEVUExZDJuV0N6bG1OeUc2?=
 =?utf-8?B?YktweUVrMU9EMktVNGVFWXFJUzUwUWtXaFBIOFI1cG05MVFNOGx0WDJHTEU4?=
 =?utf-8?B?OWplRzZRUC9tT0MrYVpQcjZBQXdUYThncThMeWNuaVFnY2Fab1FIdVhhSTN4?=
 =?utf-8?Q?P16/3XagIZM/1kQeP8UijyzWC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d0edb27-f8b1-40ad-6dad-08dc65663fd1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 20:28:21.2512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yg0XsWMYrMIWdNPiP/Bzp10CDei1l4VUseq34XeFVY3DX3PaC3KU2/jsHsWe5JkdXQ+T8FuL8+4PzdNGg+dGFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8924

On 4/25/2024 15:24, Lyndon Sanche wrote:
> On Thu, Apr 25, 2024, at 2:07 PM, Mario Limonciello wrote:
>> + Srinivas
>>
>> On 4/25/2024 12:27, Lyndon Sanche wrote:
>>> Some Dell laptops support configuration of preset
>>> fan modes through smbios tables.
>>>
>>> If the platform supports these fan modes, set up
>>> platform_profile to change these modes. If not
>>> supported, skip enabling platform_profile.
>>>
>>> Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
>>> ---
>>
>> When you developed this was it using a Dell Intel or Dell AMD system?
>>
>> If it was an Intel system, did you test it with thermald installed and
>> active?
>>
>> I'm wondering how all this stuff jives with the stuff that thermald
>> does.  I don't know if they fight for any of the same "resources".
> 
> Thank you for your response.
> 
> I did my development and testing on a Dell Intel system. Specifically the XPS 15 9560 with i7-7700HQ.
> 
> I do have thermald running, though I admit I am not really aware of what exactly it does, besides being related to thermals in some way.
> 
> I normally set the thermal mode with Dell's smbios-thermal-ctl program. I am not too sure all the values that the bios configures on it's own depending on the provided mode, so I am not sure if thermald conflicts. But my understanding is that would be out of scope of this driver, since we are only telling the bios what we want at a high level.
> 
> Lyndon

Yeah it's not say it's a "new" conflict, it would just become a lot more 
prevalent since software like GNOME and KDE use power-profiles-daemon to 
manipulate the new power profile you're exporting from the driver.

If there really is no conflict, then great!
If there is a conflict then I was just wondering if there needs to be an 
easy way to turn on/off the profile support when thermald is in use.