Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1374704lqd; Thu, 25 Apr 2024 13:37:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV6n6/BhwcEOaQA7C88RHbg7B4JDKxBkAUK/ZHYhd6VmFbBDGu7kNaZC8Ukep8iSCZCr1OBJTZgw1ZYAtGfY1Rn8q6ZXAQ9kfmt+mtFvw== X-Google-Smtp-Source: AGHT+IG5N8KVYJqWcOIkW7xLA9SNez+o6/06uzdkbbWTBNtKdUU3/3VrfuRnTxWicu25MJMxv9JF X-Received: by 2002:a17:903:8cd:b0:1e5:5be7:be86 with SMTP id lk13-20020a17090308cd00b001e55be7be86mr735581plb.52.1714077474934; Thu, 25 Apr 2024 13:37:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714077474; cv=pass; d=google.com; s=arc-20160816; b=YV+XNBxQcbJUov9LC3Nzu1Cbd5h9QG8GrScZQLRGRDpK5xHf4ba/R87v3yoqGPrnZ7 pGU/8Bpu/cRIJuXgi9Ca/O4+EjLoxkRf7qATNWLXTZCZnCNdASKqRWfx/9bZyPFjnicg O+YTyxs3k0NYxjyJ+Ql6WyByZSH8W3GGq+0CxO8sySiOgNuCnrqP2zryjo6D8eiWNnn2 zM7J0HNej6SK/hjqjzRsk3EwvzTfs/GGqWTDwxbVkPRsBrIjsZIPyVaGtI43bw9yZcJ+ tnn8CI5T27oDiK7kYdgNAQvi54bNhASRAkCX+NrvutlCrvKpn31aM/UxBaaQS5bAQvL9 15ZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=FWRrIaDTBr+A5ivDmMtcx3DtIoyngzEEto3HCvPz6IM=; fh=GZNIbPPqHEB934OA6rkgnfVlBqwZWxxUk+Vltw9/DbY=; b=ZKF/Ux/uR3QMOXKz9F+BwJNtwfjhzYpOgqwgKFibIy0AIWOT27o6D5zmuAkW5+W6iC nkCSSrRtwlzWQbvg0qxO5QZWKSjostKSz49I86qpIyLdbUPhLSKCq8YfEp46ZRxrpqlj NzFROjvtyPRYSv9v4TW/TY3IeFaRiVLyjDWMvwWGDfRPkNTMQwYB3VlSTKUc5qHWf5xV 8WCrxL3zumh84ncw9revghUAw6ITvwTzCv64n/d4cCdgcdEB79ObBB2WKLA/J45g5Jcb /Io0LbFtIXOpZoqJW5Km9SLbZx2EY+J30vFCALIBusbp+xvq+6sLDjocN1AnzY/zeBuU wDtA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=2rffjAJ2; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-159143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159143-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id lq6-20020a170903144600b001e29bb124easi14064366plb.103.2024.04.25.13.37.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 13:37:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-159143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=2rffjAJ2; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-159143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159143-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A9B1A286F11 for ; Thu, 25 Apr 2024 20:31:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE19B153BC7; Thu, 25 Apr 2024 20:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="2rffjAJ2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0250B18EAB for ; Thu, 25 Apr 2024 20:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714077083; cv=none; b=Ld8V/9Kg0su6Tc2I5xRIC1K3JJR+hgGKFzFMjwjaoC8dpYizTKII8OprCPaBuDZ1x7x0JHgQCYj49XsYtuje1Woq1DC9pprE2Ocfge5RHAv2AlVJNZZqytohvmMPOXT0Pyd1CWmt+xiuaT/yW8JNMJ5yO7aA3FsKaGxp0ek7ejQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714077083; c=relaxed/simple; bh=yQtpb8KZ0XV1IAw2iLybrQtu/RFQGtz9q1DGWOkv7s8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=QJKtjbfkIM6oV4FHLlRrYy3HST5OVPKfAjee4EJkLwVkm7ddOsHiNpauviEMK+GKQcSBdHmZtWZEvJ6Q7G++fwS23Jcq9QQfJwAXCFw/cc4jpngkaj+ZwDweBZVUnU6+iU80asMDoDSwCnR5FZTtjik9HCvzbSDa326t1XsxJqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=2rffjAJ2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36EBBC113CC; Thu, 25 Apr 2024 20:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714077082; bh=yQtpb8KZ0XV1IAw2iLybrQtu/RFQGtz9q1DGWOkv7s8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2rffjAJ2EQPwVvmxmdfSPdf20O+ADL2Tt8xyAy43S1hxG+hakDIU7QIsuQ+ueNsU5 hOJesWEqmuDJaXW676KIE79iVf2KmSxZId2bh6QtW39gL9qRnmBG7Hw9Z/bnWE5A81 92p7wTwKhXQ/OC3YL525SOvZDQZ56xgTj3GspBck= Date: Thu, 25 Apr 2024 13:31:21 -0700 From: Andrew Morton To: Alexander Potapenko Cc: elver@google.com, dvyukov@google.com, ojeda@kernel.org, linux-kernel@vger.kernel.org, syzbot+355c5bb8c1445c871ee8@syzkaller.appspotmail.com Subject: Re: [PATCH] kmsan: compiler_types: declare __no_sanitize_or_inline Message-Id: <20240425133121.efd1f9da094be454a6366cf2@linux-foundation.org> In-Reply-To: <20240425092859.3370297-1-glider@google.com> References: <20240425092859.3370297-1-glider@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Apr 2024 11:28:59 +0200 Alexander Potapenko wrote: > It turned out that KMSAN instruments READ_ONCE_NOCHECK(), resulting in > false positive reports, because __no_sanitize_or_inline enforced inlining. > > Properly declare __no_sanitize_or_inline under __SANITIZE_MEMORY__, > so that it does not inline the annotated function. > > Reported-by: syzbot+355c5bb8c1445c871ee8@syzkaller.appspotmail.com I'll add Link: https://lkml.kernel.org/r/000000000000826ac1061675b0e3@google.com And I think a cc:stable is justifiable. A Fixes: target would be nice?