Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1379719lqd; Thu, 25 Apr 2024 13:50:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVzy2L9qIvx/RTRwsW5aIsEEOAE2NjddFEbompqzP/yrArAOUpRadEeExS8LkbiV3Ew1lw4XX+D/52ttVCvYunHBSgpC6AJeQ/m42kLwg== X-Google-Smtp-Source: AGHT+IHZ86/E8EtfpDEu9SLG9hH7uRRZddyfgmyMe0pdV4cB/+C/xdoNPauRFQLTiIB4Z8wS4y7g X-Received: by 2002:a17:906:3102:b0:a58:9707:6857 with SMTP id 2-20020a170906310200b00a5897076857mr535787ejx.12.1714078239074; Thu, 25 Apr 2024 13:50:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714078239; cv=pass; d=google.com; s=arc-20160816; b=EQZik80P1pBot6/V17mmSfsKWLrF4ySDcQuAwCz3kT9VRKcMr8gDPmnDMmhNmZ2IGq H+YBxLJSTBi2OlLZxCgUQipYvsiyxfrmxn3IqNa6SWPNo4q8/eLWvcNQT+XT8aGalMRF o4z4okasMa+J/xuigXCPncr1csl0Tef9vPpcyffmKvKNuUaCrWfYRvK8glI5ld/wxbj+ oX1gA1UsCSnIxPbNPnXQ1jTNowOrQh09c61eAv0F4O8M6DJoqMbN9nfvmOl6LH0KKBu9 S1+jyqxmlu6b7PN+hZpg98KaH+5wPOTnuqTuPtdRohFKvI9Mz9qPv+tpayTsQEoOlj+2 kQlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=4s7IIhBzS14o3ExatZAFh8ImkYpLZSFudb9CArLmaFU=; fh=EpJWbJr1PF45t9HOQyUM7DKkWMWB6lvxnpZuoSBNWeA=; b=fanXnVmRyXghMKX4PPqCaB8qgU0+SpJthyKIJGBHLG07M8G2xMKFoH32G0IGrNN3Zz RQpM7KaEmpwQTu/rQ59VEedNmTxC21oAshJoyheFFfSJusasftMBrreK3BF8KtiBaW/5 2GKuWAvB1wl+1GYktz5nU1gX4Bp/FnK4QNViUCCg1UkKoTd3ZGvBNl7J9C2m4yNKF73R ZP26P7yEIBHSwKRbfsYIQgQfFN8GSfQNF0qY6k3JbsxkN6+Rfh1fnHdzXfvL13j+aQy3 AryG4M4V0Vl7q2+HzBSFFSjlsf8qxSoVYlbTODP0Wznk1tD/jVnwTaqP2cJquFevIIRr oXIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=netfilter.org); spf=pass (google.com: domain of linux-kernel+bounces-159163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159163-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id hv18-20020a17090760d200b00a4750a71d49si11493859ejc.931.2024.04.25.13.50.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 13:50:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-159163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=netfilter.org); spf=pass (google.com: domain of linux-kernel+bounces-159163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159163-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A97161F24305 for ; Thu, 25 Apr 2024 20:50:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BBEBD155398; Thu, 25 Apr 2024 20:50:19 +0000 (UTC) Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52809152E13; Thu, 25 Apr 2024 20:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.188.207 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714078219; cv=none; b=jRIZLt5yxZ2jyHlLQ0WLnJBuuX3h7iDl3FZqwHQmDbG3vy8v2esLYIEYCXDTHAc9JNK5HIxF9oqHR3OqnC+Of9dHI3JjwPoAg/qwwunp3rNgHY/o7gCKFJRZp6yP9JQzha7MGEFnxBes19CWeuSEmvP44mMHRsZvQSglZJUcFzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714078219; c=relaxed/simple; bh=J0qO3MJ0+uKqJInfu7cnRjx6k5KHUkRHuoq6Q5hbvcY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GNEiKFyK2/8joMZYzy8nGWx9OihWFMMi5VPbtdkL4Nk7SI8dKOAbVDUy9tSLl27QjaUiZV/bDlQ9Y0I/G0b6hCtJDpYSt4QiHRbjpOqY3EF1p4NDSm+tGw65Ri4/t5CZIbbRERQW19zC/8aekAglRxKDj0OKtSk5wADuF5UPPyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; arc=none smtp.client-ip=217.70.188.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Date: Thu, 25 Apr 2024 22:50:04 +0200 From: Pablo Neira Ayuso To: Ismael Luceno Cc: linux-kernel@vger.kernel.org, Firo Yang , Andreas Taschner , Michal =?utf-8?Q?Kube=C4=8Dek?= , Simon Horman , Julian Anastasov , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH v3] ipvs: Fix checksumming on GSO of SCTP packets Message-ID: References: <20240425162842.23900-1-iluceno@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240425162842.23900-1-iluceno@suse.de> Hi, On Thu, Apr 25, 2024 at 06:28:40PM +0200, Ismael Luceno wrote: > It was observed in the wild that pairs of consecutive packets would leave > the IPVS with the same wrong checksum, and the issue only went away when > disabling GSO. > > IPVS needs to avoid computing the SCTP checksum when using GSO. This patch went already upstream. It was no clear to me that a v3 was needed. You will have to post a follow up.