Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1384186lqd; Thu, 25 Apr 2024 14:01:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU2u0bzrNX+/pwkXy2e4DK0wsQkx+GEQuruZi4anNUrt2dY8EBTURAYpe5cDuYSOX7i06HpseNY01qCbTyQhaL7YXUuU2mARbScHcioJw== X-Google-Smtp-Source: AGHT+IEcGRjD5AmZdbt+emZdmQq+h5R045repIrAiiu6TOflqoMvsm44OLNAdz5SIHiY4yalMxSi X-Received: by 2002:a05:6a20:6a24:b0:1ad:80e6:5059 with SMTP id p36-20020a056a206a2400b001ad80e65059mr1227323pzk.11.1714078896802; Thu, 25 Apr 2024 14:01:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714078896; cv=pass; d=google.com; s=arc-20160816; b=DjnP06vDJ2aDx0dxQjSlDYB41q16HRZAyhokVE89sc5vBIuuSzRLeToVFynrmIgHCo Z3A+V659epQwfKcMjsxKCslDqOypDQjHWcVSvSHwakNyUz9dH2nhjXtaPvDQdL9dFmoc yx6PMiaC1xyWQ12mVpNOMCsMDJFreVg2axF8pLhgZE98qs8OydI+4/kdr6j8x7xweyWk 5BfWpH0kl1lkJ24a3UArfN/NH4fOyKwrMYdpDTqOUtelI1Nry3UBZWx6wXZRdwi9eZE/ rUG/y/nB9bpqtDV7NSvdXXcDDEbhrsAnlFHGLxtRyEkHxyeY2m3V5SbKGEGJ0oM3pSNq AThw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=rcTZeFfPARSRjujSSHOciln/ZRB7LavlI/8ik1RstSI=; fh=lXFsxB+2UAxK47sGplc7rl4z84P89BdSrXMs+7bg/Vo=; b=E5UZxIzN4uUxPFI6994ADW0d8MhsKcT16OZ+O0swvvA6Fg7GNXLC50l0IWQZdPm2DW 7cXdJi61XFnzl0CJzUcWphnOlb15VoiMh/Qn4O5xXkn1B3A7//sNATjstvKt4PsBG3ey n9fH6ElD86zW5cFg1fp0+l5VKOw3GyErgU+rq8bVl/HxtSAH968XBJzaVbByzqKuhkX+ E4AWZyyFIZQij74WD90Bb2ovh+9vNQKSB64iw9ouOvzUCCLpKqm97O+xuTfyxLyLx/2/ KZRnMyiLwQuM6M7+YxIZRvll6ULBcIa7asIa4dT/4yBXXwzL3Ztd7dKUxc09mBAR984G K9bA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=v3QTKtLT; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-159180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159180-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id km14-20020a056a003c4e00b006eae6e1252fsi13433574pfb.234.2024.04.25.14.01.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 14:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-159180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=v3QTKtLT; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-159180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159180-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6143E282223 for ; Thu, 25 Apr 2024 21:01:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3B1E4155336; Thu, 25 Apr 2024 21:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="v3QTKtLT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49D31631; Thu, 25 Apr 2024 21:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714078888; cv=none; b=N7v3b4C/eBRItoeRkQqKVEI9PtjaHeX4/Y4XNC8F/hMigyNb83ax3tsaXdow3T0Yae/xf2V31o/8CdFYsvAEKB5I8f5azOnwsRgV6xl9dWNTGenchFdIVW6kOWRkKQ/D6uaEQ2JOmjKYQU4bD6mkesjcZVYX4ncK+wJMEREPCYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714078888; c=relaxed/simple; bh=WddoWrRbeR1iHMtp/qfJ1PoQ1YAx1kckTTOIrZin9ZU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=RPw7MQnaqOHn5xBia+1s88iqxPIV7ofGrTIzHw9EOsu0d9KjET7i9jQp8b9Y6ZihTq2ku4uO9EOJA0iJflvvKWXhGZbkN+MdLAH+sOxQTQ6KRqRGyYb39Tk0h9D71PM++ULXlqh3JqFZ0atG2z52JUeFmywTC/wsRXjKHkCKb/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=v3QTKtLT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60154C113CC; Thu, 25 Apr 2024 21:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714078887; bh=WddoWrRbeR1iHMtp/qfJ1PoQ1YAx1kckTTOIrZin9ZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v3QTKtLTXH5dOykrJSj2tlJ/7MBrHwawwmkcuOxDVU1yB0fmMRU34CiMK70rfe95P 4hh/P4b5ruo+RX4VlrkSOdwBmeaWQIIjhS6884Mj4sYbChmT8Nyro8fcgcdmqK2WAL GH+nvOrLfYJtvey8FB5I1WWI8rfd1wG6C+HCRwaI= Date: Thu, 25 Apr 2024 14:01:26 -0700 From: Andrew Morton To: Luis Chamberlain Cc: ziy@nvidia.com, linux-mm@kvack.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de, john.g.garry@oracle.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH 1/2] mm/huge_memory: skip invalid debugfs file entry for folio split Message-Id: <20240425140126.2a62a5ec686813ee7deea658@linux-foundation.org> In-Reply-To: <20240424225449.1498244-2-mcgrof@kernel.org> References: <20240424225449.1498244-1-mcgrof@kernel.org> <20240424225449.1498244-2-mcgrof@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Apr 2024 15:54:48 -0700 Luis Chamberlain wrote: > If the file entry is too long we may easily end up going out of bounds > and crash after strsep() on sscanf(). > Can you explain why? I'm not seeing it.