DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-disposition:message-id:content-type:content-transfer-encoding;
        b=unQesASJ05FF8wg1TYXd0a/ATckI11UmknXNVDoELy4LeM1a0J1h2zoYi/skt9WTdR95bKEGB1ajSOvF+LsN5Ayg//aSz8H/d53v1mJD3ifqnHEbTM8tsP9q/e6XYRBRyk6CesdYPRsdnstdQ+DT6fbfZW52tzGWTKyG0fqFk54=
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Borislav Petkov <petkovbb@googlemail.com>
Subject: Re: [PATCH 24/32] ide-tape: remove unreachable code chunk
Date: Sun, 27 Jan 2008 20:41:52 +0100
User-Agent: KMail/1.9.6 (enterprise 0.20071204.744707)
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
       Borislav Petkov <bbpetkov@yahoo.de>
References: <1201427300-3954-1-git-send-email-petkovbb@gmail.com> <1201427300-3954-19-git-send-email-petkovbb@gmail.com>
In-Reply-To: <1201427300-3954-19-git-send-email-petkovbb@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <200801272041.52818.bzolnier@gmail.com>
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 855
Lines: 23

On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <bbpetkov@yahoo.de>
> 
> tape->speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
> value is tested for being 0, 1, or 2. Remove the if-branches where
> tape->speed_ctl != 1 since they are never executed.
> 
> Also, rename calculate_speeds() by adding driver's prefix as is with the other
> function names.
> 
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

This change is fine but it seems to depend on "ghost" patch #23. ;)

Please move it near the beginning of the series when resubmitting.

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/