Received-SPF: pass (google.com: domain of linux-kernel+bounces-159454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fef9f0e9-33d6-4e64-80b5-095b4794d7c8@vivo.com>
Date: Fri, 26 Apr 2024 10:59:51 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/page_alloc: fix alloc_pages_bulk/set_page_owner panic
 on irq disabled
From: Huan Yang <link@vivo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-mm@kvack.org" <linux-mm@kvack.org>, "kernel@vivo.com"
 <kernel@vivo.com>,
 "syzbot+b07d8440edb5f8988eea@syzkaller.appspotmail.com"
 <syzbot+b07d8440edb5f8988eea@syzkaller.appspotmail.com>,
 Wang Qing <wangqing@vivo.com>
References: <AJMANAB3D*gl9w79jvWlvaqZ.3.1626053734064.Hmail.link@vivo.com>
In-Reply-To: <AJMANAB3D*gl9w79jvWlvaqZ.3.1626053734064.Hmail.link@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eVZCMEFuSFl5RTZnb2UzMHh4a3JMQVhmbmE4bTdQemZPYk53N3dFZnhRTmJ4?=
 =?utf-8?B?QldmRmt5akRjRURqUi9DOG1VQTBYTUlIOVNMY1lXbmk3b28xV2VabEZiUXMr?=
 =?utf-8?B?S0RzRHJIbExaNTUxc1VENWtSd0swN3BES3FCOTIvSUhRSFlzYWd2VTBYcE54?=
 =?utf-8?B?Z2wzSkw0bHkwV2I3ZlpEKzBvcjI1VUp4VHVXSVdXMHk1dWdoczBzVEFMREY0?=
 =?utf-8?B?NjhtOXNadVN5MTNYRTdzR3RUMlgxNXhGUXpwQTBFWTFMRERrZmpJUHZyclV1?=
 =?utf-8?B?dDgzRjc2cTlCclkwYjhSSVE3bkVieDhjZWRDa3Z5d1J0SmljWUg1T3FIazF6?=
 =?utf-8?B?azRVVVZWaEpZcGJGeXRCMWh4bkZhMTV0MHRMb0x1dFVJblhPQzVuZm9QRG01?=
 =?utf-8?B?cUNHWStnNEluc0d1Z3VIMktKTXpTbjZLRGpqZTh6SVNBMFZNalFFa0h5dG03?=
 =?utf-8?B?U3NjNzdZREI5TVU2KzNRYTRBMDZzOGpJWHRyaXdYZUJzNnAybXVIazB5WjM2?=
 =?utf-8?B?RDhqc010MGQyR2NHY0NCOWFjcTRBN1VNZG8rNkszaU54RDdtMWJ0L2E0S1Ni?=
 =?utf-8?B?dU1qNXBlWjJaRXZUTlNhNXV3alFPOHMybnlPZkgveUR3V1IrRytWRmlQem8r?=
 =?utf-8?B?aG1tSk5hN2lzbEhIZU5uQWtlUnJ2MlladEFFSCtPK0Z3ajBZSnBWTFpUUWRl?=
 =?utf-8?B?MkYvUzZEdnYvaUtoQnhTTUFwNkExT3NUUUpldjlZa1V1ZnFpVVhNZUpwalA3?=
 =?utf-8?B?c0JZSXpoRGVrNXhIcjZVYVhmY0x3VE1YcEV6QVhPdVBINXlmTW16N0licUVU?=
 =?utf-8?B?Q2xXb3FhS2lSZzc5YTdzSGs2NVRmVHViK0ExM0cvbjVneGQyUE82bkJlNCth?=
 =?utf-8?B?M2hmbkFjRmJPVitoUEJFczRtdWp5TElBZ2pSZjZlYVlvR1BjNUdVOGh0Wmxu?=
 =?utf-8?B?RDdmREsrOTZxT3JldXlNQS9mOVVFRmZQNmZCQ0RGNFU2REZyVHpUbGRKeTlB?=
 =?utf-8?B?ejgrMnpTeThmejZaZGlKYms4VU53THRFMnBGeDM1N3BGNEY2Skx5WWtMWFdD?=
 =?utf-8?B?Q3dJcEQyd0VHSFlrdzYwY3lxOHVOeUdBNXZ4aytXOVJIWGYvR2VSSUlDanNQ?=
 =?utf-8?B?eDM4RVRsWkZpS21Ibi9nS21nNjlabkdZY01BMnZMV0JIb2l0TkdWbUxubHlL?=
 =?utf-8?B?NVc3TjQrS2FrcHo5Ym1XNnk5YTEyZTQ4bWwxOWpyUWRSLzBWd2p5a3FTN0tr?=
 =?utf-8?B?WlJuNVd5MHhwV0lrdHFaQTQvZXZhcklNcjE4d2hnN2U0UVNYTXA2b3pCTWhN?=
 =?utf-8?B?S1VXbVZNWUphOXlxNGRsLzdQVnhJaXN1SDNHRjE0MTc5anFXQUl3OUh5U2kr?=
 =?utf-8?B?b2FOR2ZnYlRJTlJsR0tFZWVZQVh2SERoNzVCSHVweGZsVmV5M2I4ZWI2blps?=
 =?utf-8?B?VGE5OUF2UU95QktwNTZ3eDJFcWdiVnc0RHlmYk9GWkVwTXlnQWgxcldlcVdF?=
 =?utf-8?B?aVdDRzYxNGJRcDVKM2QwQU5HSlMxUlNnb0d2Kzk0QlAvY2g1My9heGkweVVy?=
 =?utf-8?B?VE5ZSi9FMGEveUhadlU3aGJuY1ROTkFQK3lMQnF3aGFJRWk2WjVOWHkxRm1H?=
 =?utf-8?B?K0dmYXBkbjdVRytnaE1wZ2V2WjdQR1BnYUJDS0liaEZyUDROZjNDSmJlWndI?=
 =?utf-8?B?bmZXaHgwc24xVEM4SHdreDdXOXNwb09pb1lqVHZlQlc4dkJuS2pJNU1Dc1Yz?=
 =?utf-8?B?aFJ3NEs1dkZnYUhpcFBFVUl4Uk5iS0hJL0J5NVhObWtJYmlaQ0VvaFlNZEVP?=
 =?utf-8?B?QTRYeEZua2pGeXVBWUJmdVQvWmxPZ2lFKzBRT1Nrd2IvVDlhbGhPZC9WSVJS?=
 =?utf-8?B?VW5TYWplUDRCQS9VRW5zUWJNc1ZyZlhxMjlkNkNvQjNhUzJ5NHFldkVyMnhk?=
 =?utf-8?B?NkxEbWkyYzF6RjVSbXkxSGhDMFJGUWZjeUpxc3cyV3VTVk9TRmhnS3g5Q3p3?=
 =?utf-8?B?NzhTbzlJMTdwR1paZU0venNVcXZ2SlRKOUo5Nm9tMXk5NkxZT2NjVUpvOVdw?=
 =?utf-8?B?c20zQ0k1NTU3QVpqWm1QdnNabW1xcTJ2ek5kSjBWUVA0cEliblNEKzFDYVB2?=
 =?utf-8?Q?U70TRgYL2cJB2Ev8fhGs2iA5h?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4384ed1d-620a-422b-35ca-08dc659cf33b
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 02:59:55.1429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lCCCm4seYYg1ePqx5H4ejBgkSJ/2SB8XfQjN2Pn97PZQohYTuaoGYUFY/ChjFQixdVtPWmEKayBNIgzThmToCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5801

HI Andrew

在 2024/4/25 17:52, 杨欢 写道:
>>> The problem is caused by set_page_owner alloc memory to save stack with
>>> GFP_KERNEL in local_riq disabled.
>>> So, we just can't assume that alloc flags should be same with new page,
>>> let's split it. But in most situation, same is ok, in alloc_pages_bulk,
>>> input GFP_ATOMIC when prep_new_pages
>> Please more fully describe the bug which is being fixed.  A link to the
>> sysbot report would be helpful.  I assume there was a stack backtrace
>> available?  Seeing the will help others to understand the bug.
> Sorry, here is the backtrace:
> __dump_stack lib/dump_stack.c:79 [inline]
> dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:96
> ___might_sleep.cold+0x1f1/0x237 kernel/sched/core.c:9153
> prepare_alloc_pages+0x3da/0x580 mm/page_alloc.c:5179
> __alloc_pages+0x12f/0x500 mm/page_alloc.c:5375
> alloc_pages+0x18c/0x2a0 mm/mempolicy.c:2272
> stack_depot_save+0x39d/0x4e0 lib/stackdepot.c:303
> save_stack+0x15e/0x1e0 mm/page_owner.c:120
> __set_page_owner+0x50/0x290 mm/page_owner.c:181
> prep_new_page mm/page_alloc.c:2445 [inline]
> __alloc_pages_bulk+0x8b9/0x1870 mm/page_alloc.c:5313

Thanks for your reply, but this patch was submitted in 2021, at that 
time it was believed that bypassing

alloc bulk would suffice when page_owner is enabled, so this patch was 
not considered.

Have you recently encountered any issues related to this?

Thanks.

>> And if you are able to identify the patch which introduced the bug, a
>> Fixes: tag would be helpful as well.
>> Thanks.
>>
>
>
>