Received-SPF: pass (google.com: domain of linux-kernel+bounces-159501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 26 Apr 2024 12:28:00 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Marco Pagani <marpagan@redhat.com>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: re-enable KUnit test suites for the subsystem
Message-ID: <ZistUCl6hbRdhjKL@yilunxu-OptiPlex-7050>
References: <20240423162229.52023-1-marpagan@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240423162229.52023-1-marpagan@redhat.com>

On Tue, Apr 23, 2024 at 06:22:29PM +0200, Marco Pagani wrote:
> The core components no longer assume that low-level modules register a
> driver for the parent device and use its owner pointer to take the module's
> refcount. KUnit test suites can now be safely re-enabled even with loadable
> module support.
> 
> This reverts commit a3fad2e92c76 ("fpga: disable KUnit test suites when
> module support is enabled")

Don't wrap the commit reference.

Instead just keep the auto-generated shortlog & changelog auto-generated
by "git revert", then follow your description about the change.

Thanks,
Yilun

> 
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
>  drivers/fpga/tests/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fpga/tests/Kconfig b/drivers/fpga/tests/Kconfig
> index d4e55204c092..e4a64815f16d 100644
> --- a/drivers/fpga/tests/Kconfig
> +++ b/drivers/fpga/tests/Kconfig
> @@ -1,6 +1,6 @@
>  config FPGA_KUNIT_TESTS
> -	bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
> -	depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
> +	tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
> +	depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
>  	default KUNIT_ALL_TESTS
>          help
>            This builds unit tests for the FPGA subsystem
> 
> base-commit: b7c0e1ecee403a43abc89eb3e75672b01ff2ece9
> -- 
> 2.44.0
> 
>