Received-SPF: pass (google.com: domain of linux-kernel+bounces-159502-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 26 Apr 2024 12:37:24 +0800
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
	Lalith Rajendran <lalithkraj@chromium.org>,
	chrome-platform@lists.linux.dev, Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v1] chrome/cros_ec: Handle events during suspend after
 resume completion
Message-ID: <ZisvhAg5Jy_IE-AV@google.com>
References: <20240425143710.v1.1.If2e0cef959f1f6df9f4d1ab53a97c54aa54208af@changeid>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240425143710.v1.1.If2e0cef959f1f6df9f4d1ab53a97c54aa54208af@changeid>

On Thu, Apr 25, 2024 at 02:37:11PM -0600, Karthikeyan Ramasubramanian wrote:
> On boards where EC IRQ is not wake capable, EC does not trigger IRQ to
> signal any non-wake events until EC receives host resume event.

The sentence looks irrelevant to the fix.  Presumably, EC should send those
pending non-wake events after it receives host resume event.

> Commit 47ea0ddb1f56 ("platform/chrome: cros_ec_lpc: Separate host
> command and irq disable") separated enabling IRQ and sending resume
> event host command into early_resume and resume_complete stages
> respectively. This separation leads to host not handling certain events
> posted during a small time window between early_resume and
> resume_complete stages. This change moves handling all events that
> happened during suspend after sending host resume event.

The regression you see is probably not due to the "separation" but an unwanted
code reorder.

Before 47ea0ddb1f56[1], a resume is:
1) Enable IRQ.
2) Send resume event.
3) Handle pending events.


After 47ea0ddb1f56[2], a resume is:
1) Enable IRQ.
2) Handle pending events.
3) Send resume event.

If there are some more events pending between 2) and 3), they would be handled
further late.

[1]: https://elixir.bootlin.com/linux/v6.6/source/drivers/platform/chrome/cros_ec.c#L381
[2]: https://elixir.bootlin.com/linux/v6.7/source/drivers/platform/chrome/cros_ec.c#L438


I see what the patch tries to fix but the commit message makes less sense to
me.  Please fix accordingly.