Received-SPF: pass (google.com: domain of linux-kernel+bounces-159515-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To: "Zaremba, Larysa" <larysa.zaremba@intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>
CC: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>, "Tantilov, Emil S"
	<emil.s.tantilov@intel.com>, "Zaremba, Larysa" <larysa.zaremba@intel.com>,
	"Czapnik, Lukasz" <lukasz.czapnik@intel.com>, Eric Dumazet
	<edumazet@google.com>, "Brady, Alan" <alan.brady@intel.com>, "Michal
 Swiatkowski" <michal.swiatkowski@linux.intel.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, "David S. Miller"
	<davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH RESEND iwl-net] ice: Interpret
 .set_channels() input differently
Thread-Topic: [Intel-wired-lan] [PATCH RESEND iwl-net] ice: Interpret
 .set_channels() input differently
Thread-Index: AQHakXfVyi0r0mssvUKlzRshng6vHrF6CbNg
Date: Fri, 26 Apr 2024 04:59:45 +0000
Message-ID: <CYYPR11MB842959375B6268B314DA77D4BD162@CYYPR11MB8429.namprd11.prod.outlook.com>
References: <20240418095857.2827-1-larysa.zaremba@intel.com>
In-Reply-To: <20240418095857.2827-1-larysa.zaremba@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rwmwf7nsUFW1RDAC+5Ozdx2DwQeMOc2S4pFMB48McokCZHD5o6RqlCzYrmcw?=
 =?us-ascii?Q?cjoHDFVQJpIFVleeYtFKhwrnPrGGykCqDB9oSWLRB1kb9944tdQ5futdTMSb?=
 =?us-ascii?Q?bipoVNREz8a3E+usV2D7KH40ojrpSBKASXcHXIkMVy6iG9SSSQOHh8/NOD55?=
 =?us-ascii?Q?AF2GrpkVluyxHNO5xFRBtcEsmxv1EHbegdcZ4xD01LEDFvZQT29qT3cwJ3pU?=
 =?us-ascii?Q?Iz6Y3bX4FL4oBtKWZOiH6ua+MqkUBxiKNAZPJ3/l8dpD2iG2C3JPfSHNvVtz?=
 =?us-ascii?Q?QMFp5WaMmexqzsfM3J2dkEiWQ9rbrFW8TUjWWsnYIggmyhXV/bGxlar1ufgM?=
 =?us-ascii?Q?HoXtDs/vrUFbRw3WWndFGgYHgMmbhJLgcayuT06m7vOSf5eWfF5DrunKb0JS?=
 =?us-ascii?Q?++FoSQdRM3qkAiUnKlX+sCE8aWmHs+0MNPvJMtATFui5HKRrnvH9JR/zQp1F?=
 =?us-ascii?Q?HMxk1+YtGxfqL6JmMM5kKq4HRH1xu7q8SwuDGXbu/5pb972sHAn8GvxD/rQY?=
 =?us-ascii?Q?+Jh5oib02SRttCVqVMN/GBckV8UXguZL4IYvFFHVGn/KV3M21ybYSQU67H/8?=
 =?us-ascii?Q?yPPsbGrTEJkWea+k3SJU0qBhQiOq7lQhbFAct2Fa0nsmznE8zpUEZW1Jm42o?=
 =?us-ascii?Q?LbbEmsTOrtX23P3ES09w5O8goJNsQeQ9cLS6VTcl9+AQw8USbZjx0qYhdEVX?=
 =?us-ascii?Q?J1hK6B0QlYiNPvCXvE436JlDTcN61ozv+901rwezw6pevfOth1Ye3c6WOGgE?=
 =?us-ascii?Q?cXFAdQX7F92h2X3r5/zDOdklkmn/Bjwgyx9HpF/wnCUb580lyXFYgZvnNSTe?=
 =?us-ascii?Q?NTZ0S7N1fUYOYXIBPf88NZXDqvAugZIX2uvAXZAd+PukSuw+JyRjRvKdk9eU?=
 =?us-ascii?Q?07IsimAhNZdqGYy41E5ZZegTRqV1ceqYkJREcxYMsSSg3RP0lK2q04K0iFia?=
 =?us-ascii?Q?Pg7IekdsnK8qewgIe5APPYlQWkpXNVVNptSyjUWRgsfRREUTldVDiXollU13?=
 =?us-ascii?Q?VSsVz4K6IxUjWmkeCSeLxg/iD89scySNjpN3V9dv9QNdQaOvTZNKHVaoGtKG?=
 =?us-ascii?Q?wqwi7qOKqZ1ycwpHkmndfyBGtioqf7MB5pK+kA/K+HkoJeualnacnlxZxghV?=
 =?us-ascii?Q?UiZs5aCP1Zx5NkgVXlAWYS8M+JkXrgOUBDcJZFjd/JbI7mUKvWVsl4dBMeiB?=
 =?us-ascii?Q?z0IM3z8lUFnipS6gY8UYVj1J5w+b2zu4NYFjOP125FYNDn6dud/SreXLxL1f?=
 =?us-ascii?Q?l4BQNMBEe1uksANL8n4D2rM2AyS1YvgzteCQ5GZqSt/fcR5g5+4o8coUIRdK?=
 =?us-ascii?Q?0rm3hDcn8BLVh07leaE6o+Y94CCB/Cr6l99jSdJ7soljUMLsl9XfrSgteIj9?=
 =?us-ascii?Q?bMgayL+U1g6laZuF0e+Eo94kT1LCrYpAdqK0M5xwe022y2uGlXe+ang/J7x5?=
 =?us-ascii?Q?0ItJfCJDd3OnTGRqlkF8Tks4Vf8WwA2poDIWuDykFJWYObd4/Jj4ZyZrKy65?=
 =?us-ascii?Q?g51I3MAAIImlf5l1OFIHik0QXomWnUWp1gvnzio1n46kzNKPI4zEfGgDyJtq?=
 =?us-ascii?Q?fZ/292QdA/yOOocbity8iCN5W8/71CIIqfJOxLWwLBJ7IkXSNpYTSrrrL8lA?=
 =?us-ascii?Q?rg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8429.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75830649-703a-4cf1-75cf-08dc65adb11f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2024 04:59:45.4713
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Bc/f6XoXWjWc1hEzWWEGpaKRh0+s+Zeoy+++Fq745Xbpt5HPYPz+Z2ccEcN1qpWIvx1RcyKbOj1dWudBkVeczWLiuRM2Q0+aR0igpRgSlYvk4U/zhYViHvbdvrb4gNDu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4550
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of L=
arysa Zaremba
> Sent: Thursday, April 18, 2024 3:29 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; intel-wired-lan@lists=
osuosl.org; linux-kernel@vger.kernel.org; netdev@vger.kernel.org
> Cc: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>; Tantilov, Emil S =
<emil.s.tantilov@intel.com>; Zaremba, Larysa <larysa.zaremba@intel.com>; Cz=
apnik, Lukasz <lukasz.czapnik@intel.com>; Eric Dumazet <edumazet@google.com=
>; Brady, Alan <alan.brady@intel.com>; Michal Swiatkowski <michal.swiatkows=
ki@linux.intel.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@=
redhat.com>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH RESEND iwl-net] ice: Interpret .set_cha=
nnels() input differently
>
> A bug occurs because a safety check guarding AF_XDP-related queues in eth=
nl_set_channels(), does not trigger. This happens, because kernel and ice d=
river interpret the ethtool command differently.
>
> How the bug occurs:
> 1. ethtool -l <IFNAME> -> combined: 40
> 2. Attach AF_XDP to queue 30
> 3. ethtool -L <IFNAME> rx 15 tx 15
>    combined number is not specified, so command becomes {rx_count =3D 15,
>    tx_count =3D 15, combined_count =3D 40}.
> 4. ethnl_set_channels checks, if there are any AF_XDP of queues from the
>    new (combined_count + rx_count) to the old one, so from 55 to 40, chec=
k
>    does not trigger.
> 5. ice interprets `rx 15 tx 15` as 15 combined channels and deletes the
>    queue that AF_XDP is attached to.
>
> Interpret the command in a way that is more consistent with ethtool manua=
l [0] (--show-channels and --set-channels).
>
> Considering that in the ice driver only the difference between RX and TX =
queues forms dedicated channels, change the correct way to set number of ch=
annels to:
>
> ethtool -L <IFNAME> combined 10 /* For symmetric queues */ ethtool -L <IF=
NAME> combined 8 tx 2 rx 0 /* For asymmetric queues */
>
> [0] https://man7.org/linux/man-pages/man8/ethtool.8.html
>
> Fixes: 87324e747fde ("ice: Implement ethtool ops for channels")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 22 ++++++--------------
>  1 file changed, 6 insertions(+), 16 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)