Received: by 2002:ab2:3c46:0:b0:1f5:f2ab:c469 with SMTP id x6csp55062lqf; Thu, 25 Apr 2024 22:02:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUw0mFOxRis4tdjSNTi3AMsXYA34ztpOCL4w2kHoCez9XNBY/e7mTOAc7kziNjWQ9evejnTIcbUZVXO45de66/nnGnEUbDPXwtp7qo0/Q== X-Google-Smtp-Source: AGHT+IFw6MOWHeibcE+Hy9K20DpnSg2EOFdkjlPSXtI75SKPXUz/ErZS5YcuPACEbCTrw6p/xibn X-Received: by 2002:a17:906:eb14:b0:a52:3677:b0c2 with SMTP id mb20-20020a170906eb1400b00a523677b0c2mr1042450ejb.3.1714107772478; Thu, 25 Apr 2024 22:02:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714107772; cv=pass; d=google.com; s=arc-20160816; b=u8Vq/2jh3/1w/Ga5JvZ40zH8ZD8Gsqg4wVjlz5snMOlOE+VklqlTRcX+sDm/LPFtzs ZNbGr15iLn6TwW0By0SKS6OqPwX8ueYo4p/Ot7mlqZkKY8FHIVe+79GFPqrsOrK9aNe1 jYbDp+G82CIN17iG0E9zT/BOL2mG5MYHVvZufr75iyfb/uYd7Zug1B9Cf9DOc1vcvKGg a2j3XRF0WDjKukf0dF1LOP9eG2ee5FtJKMF75Kb7nzJqVSkvQlgRA+WQ065qa+nbBG3a rU+ywipE/UQun9mXCnpFdxtq9WIROajv7+AqIgshzlkNQawHRzKKSklt8c5muElHl/2P gPMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=hpATM5pm/nyT/JThxHBu5L9yyFU9PhpOOxAJ6PYqLAU=; fh=kR0OVH+1V767lkR3ViJCRmyoEIbAkx1meR12FF9gBVA=; b=EJ2YhoWjCPP3rNaUz3SaG9k5LcHVs0sHbUjbywkcHi3NxwTpMKDxG16Vl4PeBOyFuT 4mScKTBLgZamG97OsCrSwFfk/Fc7b8i8OCEexb4eYjk4qVmRmAKzhraCSC8TNNsr/Zqs 3itaICVGBluu7v/J+xgWcUtFZT0Pq4iGxy6NNN/CMeRm+bUbuTs2upmhUZ2XlWbyXdN9 8dCCUmYZ1AdbrqBah+4dGc3RKoJG+iAYvq1w3v/TeZuyjXuX3YcB2UUlUV0HhnsmJR0W nK83yiU/2BLSfmf3rO0mjvc6nvySU5KK6DhfAqO7Rhv+ty//6A3hoFBmm4QzE0Jq5TYy 4S/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-159516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159516-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id hr7-20020a1709073f8700b00a58af0654fasi2092493ejc.690.2024.04.25.22.02.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 22:02:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-159516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-159516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159516-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 392601F22E83 for ; Fri, 26 Apr 2024 05:02:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 772AE13A3E2; Fri, 26 Apr 2024 05:02:40 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7442F36; Fri, 26 Apr 2024 05:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714107760; cv=none; b=t6PB7I4/7TnaiU42VltRPMxnRPGt9Avu9O01ZpBlzoBJwPvgmINeoRIXEnlhk3qKuSr1MK/ZDmutGqLJycCKemlQl4sCdsPOokKnOOnwzfHEkSav2QhMKq3XjVbHSyPhSC3B6FuqmHBTRtUwlSZ7RpnCKLTqbqMSdhMc0dLrO7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714107760; c=relaxed/simple; bh=M63h01ngfO3MyMvYCVDmxUFcqBJ/vp/JP5oOD/9VEh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JDOx4t04ddfk+J423+8GFLjSn6enHRCGVvyR7QcZu5z2u9v304ZRHBkYbxOmxEk5xBkOlhJOTocTlrjHydSb/W7QwkycYwThHO4bk9mTxJGPAnpsX4KoJl7uNAYTNWmb1gpE3Lex+fJfcktzPhAPisCP9BqPrWpvswVOoHg3tM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 02490227AA8; Fri, 26 Apr 2024 07:02:29 +0200 (CEST) Date: Fri, 26 Apr 2024 07:02:29 +0200 From: Christoph Hellwig To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Joerg Roedel , Will Deacon , "Rafael J. Wysocki" , Magnus Karlsson , nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org, netdev@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 6/7] page_pool: check for DMA sync shortcut earlier Message-ID: <20240426050229.GA4548@lst.de> References: <20240423135832.2271696-1-aleksander.lobakin@intel.com> <20240423135832.2271696-7-aleksander.lobakin@intel.com> <81df4e0f-07f3-40f6-8d71-ffad791ab611@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81df4e0f-07f3-40f6-8d71-ffad791ab611@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Apr 24, 2024 at 10:52:49AM +0200, Alexander Lobakin wrote: > Breh, this breaks builds on !DMA_NEED_SYNC systems, as this function > isn't defined there, and my CI didn't catch it in time... I'll ifdef > this in the next spin after some reviews for this one. I looked over the dma-mapping parts of the series and it looks fine to me. So please resend as the fixed up version as soon as you fine time for it.