Received-SPF: pass (google.com: domain of linux-kernel+bounces-159556-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 26 Apr 2024 08:19:40 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>, linux-mmc@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
	Hien Huynh <hien.huynh.px@renesas.com>
Subject: Re: [PATCH v2] mmc: renesas_sdhi: Set the SDBUF after reset
Message-ID: <20240426061940.un6ezs3k4mdcalax@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
	Hien Huynh <hien.huynh.px@renesas.com>
References: <20240410135416.2139173-1-claudiu.beznea.uj@bp.renesas.com>
 <CAPDyKFovRYQOCM8UqFcsP+MiUd2ViKJhgHUMH6hgBiqtdBxmkg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vevnq5ydnb3hx7dg"
Content-Disposition: inline
In-Reply-To: <CAPDyKFovRYQOCM8UqFcsP+MiUd2ViKJhgHUMH6hgBiqtdBxmkg@mail.gmail.com>


--vevnq5ydnb3hx7dg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 07:08:10AM +0200, Ulf Hansson wrote:
> On Wed, 10 Apr 2024 at 15:54, Claudiu Beznea <claudiu.beznea@tuxon.dev> w=
rote:
> >
> > For development purpose, renesas_sdhi_probe() could be called w/
> > dma_ops =3D NULL to force the usage of PIO mode. In this case the
> > renesas_sdhi_enable_dma() will not be called before transferring data.
> >
> > If renesas_sdhi_enable_dma() is not called, renesas_sdhi_clk_enable()
> > call from renesas_sdhi_probe() will configure SDBUF by calling the
> > renesas_sdhi_sdbuf_width() function, but then SDBUF will be reset in
> > tmio_mmc_host_probe() when calling tmio_mmc_reset() though host->reset(=
).
> > If SDBUF is zero the data transfer will not work in PIO mode for RZ/G3S.
> >
> > To fix this call again the renesas_sdhi_sdbuf_width(host, 16) in
> > renesas_sdhi_reset(). The call of renesas_sdhi_sdbuf_width() was not
> > removed from renesas_sdhi_clk_enable() as the host->reset() is optional.
> >
> > Co-developed-by: Hien Huynh <hien.huynh.px@renesas.com>
> > Signed-off-by: Hien Huynh <hien.huynh.px@renesas.com>
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>=20
> Wolfram, when you have the time, can we get your opinion on this one?

Sure, I'll try to squeeze it in today. Thanks for the heads up!


--vevnq5ydnb3hx7dg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmYrR3wACgkQFA3kzBSg
KbZ8TQ//XcvAOylYC6tL3yAmwT3eiXpVg8Q0YiaF2QkrLHEM7U202OFUcYGcPl/h
0h5jYLGD7qX+MZ/HNL6wBKJakijdALpehMwMZMEqPNCTUMHgldjUxjnmB+WVr3Fz
wquaxnbNr4+kDrBhBGQgmoSwLerfWvBnV4moCrCX95JTP+Ze9ASyrYHpLg+TP/Dw
PbnA5RxZoCgBukA+hSs8NOUDNRSlX669Stt79v90UEuK/AuEbDTflUdGpRYZSaP9
elBQBCDxpWAuXDEhXohSkdUSsx8GBx1GNezhz1CuFJI5XeBdczq/y9M3c7BC3D9t
9AXRozdCTMFJY+njJYMTgi5D7fl2EcrVy8ix1iqDq9NMUswBOX0NFUcPnKN7JMay
qOI4c7C9Zx1Zjo8m4dfI+yR5vWThyxD0MpWkKXG0igNJv0yje8GrMn8l8/iqqbvi
M8JHVYjdeDR2JzT95cvfTw15wugqa6Da1m65vnQ5MPqV5jcdYh/e2qEjfb7AjkZN
9Z4yJa2bLgag2VYnD82PiymRJ1buz25XANMGuMiYeUy7CekGI3ljFRQk3d9KFjAW
kI3QcihUGNvjYrgxpdtnnE67XPv2p/Hacjr0QDbSQAgeaWBfvwvTG09xNI4bKLys
S4Bbq31DUyKeYrCElXIn10T9/Im4fi4sQwUPV77wif2j6Y4tacg=
=zYpH
-----END PGP SIGNATURE-----

--vevnq5ydnb3hx7dg--