Received-SPF: pass (google.com: domain of linux-kernel+bounces-159607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <ed625666-7934-4a7e-9b6c-f434ee0ae094@intel.com>
Date: Fri, 26 Apr 2024 14:58:30 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/10] KVM: x86: Rename get_msr_feature() APIs to
 get_feature_msr()
To: Sean Christopherson <seanjc@google.com>
CC: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>
References: <20240425181422.3250947-1-seanjc@google.com>
 <20240425181422.3250947-6-seanjc@google.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20240425181422.3250947-6-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnFEMHZTVGx1QTNhbS9DMDVCYVRCYmUzNm5KakR6M2lFZUt5UE1KazFiNWNE?=
 =?utf-8?B?N2JNb2tqL0h3MXFhMlFwVG5IZ21VNi9VWDd0MnN2Z2Q5ZUhHenFmTkhXeEVk?=
 =?utf-8?B?NFdkcThqS3FoNm9EanlkSEd4TytRVlhUMndHNHpPMDBUWVprcjBFc1lSL3ZR?=
 =?utf-8?B?TDRPeUpaWU1lbjVSWXc1and5TjN0NnJQVzBhYms5cXRWWm03NGtaNy9LVXVM?=
 =?utf-8?B?Vm9iMVBvT0xWN1FKL2JSYXdQOW82M2o2aGVOSDVIb0RrSXdjellha2Rtd1hu?=
 =?utf-8?B?bjRFNnh2TysrTFJtRi93akFBRGo2Mk5kN013WDdOajR0ZHVGRnRETkZGTkhi?=
 =?utf-8?B?M2laYnhQRU5uYzNNUnVnOW05UmtzUjkyUGdPSHAwaExpeElkSVh6blY1dkty?=
 =?utf-8?B?cjBWTitzNEIxeVYzSncvbTNkeG5Ec05zbmdnbk51OFpWSUgxQ250dERDOUM5?=
 =?utf-8?B?TzYyNjVCMjJDbHdQSTJQTnpxTjVGT3BJYjVoL2lNTmNDbk5Fazg0UzFNNURJ?=
 =?utf-8?B?MEJlVUh4TVFyb3g1c1NyQkE5aGF3ZEZCQjRhbkNSaHJMSXlIWUdrUTVYQWhX?=
 =?utf-8?B?QkdyMENKbnVTcjd6bEp1K2VqU29KWW40eENvRk04UDQ0ZGd4S21yYXBpNGQv?=
 =?utf-8?B?NWsxMFUwakpacXdSMEQxVnY5NVV6Rk0rQ0tydjQrUGkrazVoVTgwT0dTUk9E?=
 =?utf-8?B?enZaUzVtWHRIRUlSU2lWMnlvd2hQT25vd1p0L2VxTE5TRnRjQ2JJaFJudUxN?=
 =?utf-8?B?SllnQjVScDN1c0VZSmMvQWQ3R2JJaGRxdGlyTnRTSEMySHRHMEtPNWtLTmF6?=
 =?utf-8?B?ODFCb3ZwTE1oc3puT2R4WTB3VzFFSVpNTHJXWVhDUjUwVldCNitFa0QrdUlI?=
 =?utf-8?B?d3E4R0N5U1JlL1lZYytIMDdvMEIyWnBIdEsyN0tJVXJUVjlTVVFLQjRneG1p?=
 =?utf-8?B?Y0g3SFdlRE82RUsyTnVyK000UWtCNENZVkNWMWc1Skg1dC9qZ2VNU1gwNkRk?=
 =?utf-8?B?eGY5VytFVm80QTdsVUFCQlQyQmk1eEpjUFptOXBhWGc1bVJ6Sk95OGF4WThs?=
 =?utf-8?B?cXFmZ2RqcEdzeHlIN0U1YXZZZHdlOVdlaW15T2JPSTBXMldRM0ROeXdHYmlX?=
 =?utf-8?B?MVRjNC9TQ2JHVlFmVklHQ0I3U0cwWTNHWC9Id0VHVEo1Qk9TdmJPYU5QWXNQ?=
 =?utf-8?B?Y3BYaFRnRmFwNlczZWZTL0l3bmoxUElSaXB4VWpWMVFlV3ZkVjFWNGNISXVS?=
 =?utf-8?B?ZkdrQUgyS1dIc0VLeUJpRjBITzhvdmtMbW1mbkVvK0Qwb2l6VTNFMHJuMDZY?=
 =?utf-8?B?aHVJWTIxTUMwcmtobHJnUm9JanpUSDZWZkFQbmhRQVZ0VFlBZUxWVFRkcys0?=
 =?utf-8?B?a2NBam9PekowVElpanRGbmlIUjlTVzV0dUw0cTBHYnFTaHBLQWV5MTBRcDZS?=
 =?utf-8?B?R1ZxMjliVll4WnZtdWdjYVFmWERlVFNKT2U4WTRrMlNkdzRhQmZieUozQ0M2?=
 =?utf-8?B?SkVWRlE2OUVHT25YYUMzZWQ4bnFlREIwVnJZVTlNZFgxYzl3V2t1MEpCS1lv?=
 =?utf-8?B?R0Nnc0JYSFN5Uk1ENlY3WjdzdFVVaGhXbmNRR3dybjJHUElMSkxONVRDd1dh?=
 =?utf-8?B?N0RlTTh0VjI2TEI2aUVCQWt5QkJ2d2ZCOGt0cHBOV3ZYbGlNMWxlK3JDL0Ja?=
 =?utf-8?B?QXBOcHVoNlRaT1hTVkpsOHgzK2Q5TkZ3NnFNWCtNTm11dnhlUTVyVEJLUDlG?=
 =?utf-8?B?aXFPWGQ1VXhBaXFiMjZiaXF5Uityb0YydnFFa1ViOGdBL0p5Wk5RVy9HT1pR?=
 =?utf-8?B?WkNFTnMvWlY3aTVxTHNtR0k5QXc3WEg4SGxTaUE1ZktyRVdObGRqR2s4V01l?=
 =?utf-8?B?Ymp1NW5WNU9jQlhqNjYvQTJhTzNqQUVQdHYybmpFNTRIcXFPaHR1N1hrUmdZ?=
 =?utf-8?B?OEEwVUN1QS9GZUc0bllxSnkreUVQMzAyeGpMS0dVMHdBU0YwTjE0T0VMNzdK?=
 =?utf-8?B?bGNUSFh3dmN6T2NpY1ZLd3VPS2crZ3R4WHEwZkVGRWd6c3ZUV091QlFJeEFW?=
 =?utf-8?B?SnJQMWhEMVhrSDE5MEZjOEpvNG80SG5MREVtZHpNOHFMNWEvdU1TUndIV0Jl?=
 =?utf-8?B?NVlzRkV5L1VBbSs3QmxlcHc4V1ZURzMxWnkrVlNyNHdaWVJnV3pXRFZ3Nml6?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e01f0a49-006f-4dfa-838e-08dc65be4d32
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 06:58:39.6670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HKfL/Zg3P9BY6QJaXrpZU7vupIBBTKDbchLeIAk4laJKcGOs4WaPS2ZBL142+hiqqmOWaZX4dS4MjoO+6BOASA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4628
X-OriginatorOrg: intel.com

On 4/26/2024 2:14 AM, Sean Christopherson wrote:
> Rename all APIs related to feature MSRs from get_feature_msr() to

s /get_feature_msr()/get_msr_feature()
> get_feature_msr().  The APIs get "feature MSRs", not "MSR features".
> And unlike kvm_{g,s}et_msr_common(), the "feature" adjective doesn't
> describe the helper itself.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   arch/x86/include/asm/kvm-x86-ops.h |  2 +-
>   arch/x86/include/asm/kvm_host.h    |  2 +-
>   arch/x86/kvm/svm/svm.c             |  6 +++---
>   arch/x86/kvm/vmx/main.c            |  2 +-
>   arch/x86/kvm/vmx/vmx.c             |  2 +-
>   arch/x86/kvm/vmx/x86_ops.h         |  2 +-
>   arch/x86/kvm/x86.c                 | 12 ++++++------
>   7 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm-x86-ops.h b/arch/x86/include/asm/kvm-x86-ops.h
> index 5187fcf4b610..9f25b4a49d6b 100644
> --- a/arch/x86/include/asm/kvm-x86-ops.h
> +++ b/arch/x86/include/asm/kvm-x86-ops.h
> @@ -128,7 +128,7 @@ KVM_X86_OP_OPTIONAL(mem_enc_unregister_region)
>   KVM_X86_OP_OPTIONAL(vm_copy_enc_context_from)
>   KVM_X86_OP_OPTIONAL(vm_move_enc_context_from)
>   KVM_X86_OP_OPTIONAL(guest_memory_reclaimed)
> -KVM_X86_OP(get_msr_feature)
> +KVM_X86_OP(get_feature_msr)
>   KVM_X86_OP(check_emulate_instruction)
>   KVM_X86_OP(apic_init_signal_blocked)
>   KVM_X86_OP_OPTIONAL(enable_l2_tlb_flush)
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 7d56e5a52ae3..cc04ab0c234e 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1785,7 +1785,7 @@ struct kvm_x86_ops {
>   	int (*vm_move_enc_context_from)(struct kvm *kvm, unsigned int source_fd);
>   	void (*guest_memory_reclaimed)(struct kvm *kvm);
>   
> -	int (*get_msr_feature)(u32 msr, u64 *data);
> +	int (*get_feature_msr)(u32 msr, u64 *data);
>   
>   	int (*check_emulate_instruction)(struct kvm_vcpu *vcpu, int emul_type,
>   					 void *insn, int insn_len);
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 15422b7d9149..d95cd230540d 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -2796,7 +2796,7 @@ static int efer_trap(struct kvm_vcpu *vcpu)
>   	return kvm_complete_insn_gp(vcpu, ret);
>   }
>   
> -static int svm_get_msr_feature(u32 msr, u64 *data)
> +static int svm_get_feature_msr(u32 msr, u64 *data)
>   {
>   	*data = 0;
>   
> @@ -3134,7 +3134,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr)
>   	case MSR_AMD64_DE_CFG: {
>   		u64 supported_de_cfg;
>   
> -		if (svm_get_msr_feature(ecx, &supported_de_cfg))
> +		if (svm_get_feature_msr(ecx, &supported_de_cfg))
>   			return 1;
>   
>   		if (data & ~supported_de_cfg)
> @@ -4944,7 +4944,7 @@ static struct kvm_x86_ops svm_x86_ops __initdata = {
>   	.vcpu_unblocking = avic_vcpu_unblocking,
>   
>   	.update_exception_bitmap = svm_update_exception_bitmap,
> -	.get_msr_feature = svm_get_msr_feature,
> +	.get_feature_msr = svm_get_feature_msr,
>   	.get_msr = svm_get_msr,
>   	.set_msr = svm_set_msr,
>   	.get_segment_base = svm_get_segment_base,
> diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
> index 7c546ad3e4c9..c670f4cf6d94 100644
> --- a/arch/x86/kvm/vmx/main.c
> +++ b/arch/x86/kvm/vmx/main.c
> @@ -40,7 +40,7 @@ struct kvm_x86_ops vt_x86_ops __initdata = {
>   	.vcpu_put = vmx_vcpu_put,
>   
>   	.update_exception_bitmap = vmx_update_exception_bitmap,
> -	.get_msr_feature = vmx_get_msr_feature,
> +	.get_feature_msr = vmx_get_feature_msr,
>   	.get_msr = vmx_get_msr,
>   	.set_msr = vmx_set_msr,
>   	.get_segment_base = vmx_get_segment_base,
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 25b0a838abd6..fe2bf8f31d7c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -1955,7 +1955,7 @@ static inline bool is_vmx_feature_control_msr_valid(struct vcpu_vmx *vmx,
>   	return !(msr->data & ~valid_bits);
>   }
>   
> -int vmx_get_msr_feature(u32 msr, u64 *data)
> +int vmx_get_feature_msr(u32 msr, u64 *data)
>   {
>   	switch (msr) {
>   	case KVM_FIRST_EMULATED_VMX_MSR ... KVM_LAST_EMULATED_VMX_MSR:
> diff --git a/arch/x86/kvm/vmx/x86_ops.h b/arch/x86/kvm/vmx/x86_ops.h
> index 504d56d6837d..4b81c85e9357 100644
> --- a/arch/x86/kvm/vmx/x86_ops.h
> +++ b/arch/x86/kvm/vmx/x86_ops.h
> @@ -58,7 +58,7 @@ bool vmx_has_emulated_msr(struct kvm *kvm, u32 index);
>   void vmx_msr_filter_changed(struct kvm_vcpu *vcpu);
>   void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu);
>   void vmx_update_exception_bitmap(struct kvm_vcpu *vcpu);
> -int vmx_get_msr_feature(u32 msr, u64 *data);
> +int vmx_get_feature_msr(u32 msr, u64 *data);
>   int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info);
>   u64 vmx_get_segment_base(struct kvm_vcpu *vcpu, int seg);
>   void vmx_get_segment(struct kvm_vcpu *vcpu, struct kvm_segment *var, int seg);
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 03e50812ab33..8f58181f2b6d 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1682,7 +1682,7 @@ static u64 kvm_get_arch_capabilities(void)
>   	return data;
>   }
>   
> -static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
> +static int kvm_get_feature_msr(struct kvm_msr_entry *msr)
>   {
>   	switch (msr->index) {
>   	case MSR_IA32_ARCH_CAPABILITIES:
> @@ -1695,12 +1695,12 @@ static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
>   		rdmsrl_safe(msr->index, &msr->data);
>   		break;
>   	default:
> -		return static_call(kvm_x86_get_msr_feature)(msr->index, &msr->data);
> +		return static_call(kvm_x86_get_feature_msr)(msr->index, &msr->data);
>   	}
>   	return 0;
>   }
>   
> -static int do_get_msr_feature(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
> +static int do_get_feature_msr(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
>   {
>   	struct kvm_msr_entry msr;
>   	int r;
> @@ -1708,7 +1708,7 @@ static int do_get_msr_feature(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
>   	/* Unconditionally clear the output for simplicity */
>   	msr.data = 0;
>   	msr.index = index;
> -	r = kvm_get_msr_feature(&msr);
> +	r = kvm_get_feature_msr(&msr);
>   
>   	if (r == KVM_MSR_RET_UNSUPPORTED && kvm_msr_ignored_check(index, 0, false))
>   		r = 0;
> @@ -4962,7 +4962,7 @@ long kvm_arch_dev_ioctl(struct file *filp,
>   		break;
>   	}
>   	case KVM_GET_MSRS:
> -		r = msr_io(NULL, argp, do_get_msr_feature, 1);
> +		r = msr_io(NULL, argp, do_get_feature_msr, 1);
>   		break;
>   #ifdef CONFIG_KVM_HYPERV
>   	case KVM_GET_SUPPORTED_HV_CPUID:
> @@ -7367,7 +7367,7 @@ static void kvm_probe_feature_msr(u32 msr_index)
>   		.index = msr_index,
>   	};
>   
> -	if (kvm_get_msr_feature(&msr))
> +	if (kvm_get_feature_msr(&msr))
>   		return;
>   
>   	msr_based_features[num_msr_based_features++] = msr_index;