Date: Sun, 27 Jan 2008 23:01:04 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c
Message-ID: <20080127220104.GA3503@elte.hu>
References: <20080127223451.79718183@paolo-desktop> <479CFB62.1010808@gmail.com> <4d8e3fd30801271351p44818f64p27ca4ae897efbb81@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4d8e3fd30801271351p44818f64p27ca4ae897efbb81@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 961
Lines: 27


* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> On Jan 27, 2008 10:45 PM, Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:
> > > -  math_abort(FPU_info,SIGILL);
> > > +  math_abort(FPU_info , SIGILL);
> >
> > Looks like you're trading bad for worse here.
> 
> Should I make it read like math_abort(FPU_info, SIGILL); ?

yeah, that's the correct one.

> > While you're at it, please think about adding proper KERN_ facility to these printk() calls.
> 
> Yes, basically all the warnings are about missing KERN_. Do you want 
> me to add KERN_ERR to all the above printk?

Do that in a separate patch though, as it changes strings. (and hence 
the checking for 'did the object md5 change' misfires)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/