Received-SPF: pass (google.com: domain of linux-kernel+bounces-159651-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <672782e6-b143-42d0-9ed6-8c343d02e49d@intel.com>
Date: Fri, 26 Apr 2024 15:43:16 +0800
User-Agent: Mozilla Thunderbird
From: "Yang, Weijiang" <weijiang.yang@intel.com>
Subject: Re: [PATCH 10/10] KVM: x86: Suppress userspace access failures on
 unsupported, "emulated" MSRs
To: Sean Christopherson <seanjc@google.com>
CC: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>
References: <20240425181422.3250947-1-seanjc@google.com>
 <20240425181422.3250947-11-seanjc@google.com>
Content-Language: en-US
In-Reply-To: <20240425181422.3250947-11-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alRneHhGb0FBcWZIeUo5THFvTUljeGRWUGJncGFnTTNkWjl0QjFBZlAwV0x6?=
 =?utf-8?B?eGlEQzkxa1dLNUZzQmdabUJ6Tmc1OGJ4ZG1vVnZtc1MzUGlIU2IzRGpPdFYv?=
 =?utf-8?B?OGZzamJxSmptZEJkQmcveFphYnQ0Qkxzd1RLUEQxUE5EOGNVb3ZzYnhodDh4?=
 =?utf-8?B?V0UwZ0hlNVFBZzlKMGhNYnp5R1FZdzFXOEd6Unk3MGZ5UCtiU2cwWXczVjFJ?=
 =?utf-8?B?ei8zMEVrTUFLTzJ6N01VTmVtd1pKSG9sU0JXTzN1SWtudkwvOW9EK2w5cDdy?=
 =?utf-8?B?S0hKT3pSa0VRQzVzZUR3emV2aW1iOGJKd1hYdVFVOHJRbkFkOEZaUGk2dG9u?=
 =?utf-8?B?S0N3aEI3d3hua3BwbGI1b0N5MC91YmR4UzdXcE9tYytaZmFNbERtOVRtYzhG?=
 =?utf-8?B?MFNrUkFqY082MGkwZm9lT016ZVYvcjBVTHhMNzR5Z1lBVTN6ZXhYWHo0SkZl?=
 =?utf-8?B?Rm9UZS9WVzhDSUFIMjdlMWVmTENlSXlGR0ljanBpSjIyeDg5SHRIUTA5U1Mx?=
 =?utf-8?B?ZnhzaVhnb0hDN05nM3FkU1Njc0U0d2c4YnlnTHg4eEJydWsyRTNwNWZmRFdU?=
 =?utf-8?B?ZWI0ZXcxeldCcU5hZnF0NzFybUZHcWN2b1kvNWRZTlI5QWM4MFkyQTQ4NFMz?=
 =?utf-8?B?a3Fha29YQTlYY0JWVHZQNFdEaXRRbko2dEZKOUNKUGtGY1RTN2UremNkTCt4?=
 =?utf-8?B?UW1OdmFUYk1IdWFHZWJ4WjFFT3VNZ2YrQXhKYjhKRjNiYzJQeEVITkV2MDRV?=
 =?utf-8?B?d3hmZWdnQ3hGOVhvdkRPMDZTck5rd29JdGJIeG52WmZKZjV0ZmMwbHRTMnl4?=
 =?utf-8?B?Ni9IYWErM1VHSWU3L2ZsR1JQd0VXeDlIMlZ6b2JTSXNmUjJGTzA2Y3NtUFlh?=
 =?utf-8?B?OVZhVmlaMUFjd3BablJxbFpRRGxRSnVLc1lTcU5rZXQ3MDlDZEtnK1ppMXU2?=
 =?utf-8?B?YlFxTXBtTFZZbnBQa3dVV1RzN0k4L2E0dzJ2TVZqNzhQVzhNbnIzNFBkUE1I?=
 =?utf-8?B?Ukc1QXFZWVZmZGVmczJlS3gzdE1yeEhYYmpaNHRGQkxDS0c1ZGkxZ0FyR1JT?=
 =?utf-8?B?QTlmUzdhWWJGeWpTMVA1S25TM2hTd3M5TXZRUkRvTUgxVTBvYXkvWC9VVGtK?=
 =?utf-8?B?OXBQbDF1RXFacUl4bExCMTV2N3hBSGlvaG9RTTVGRENrRlN1WnZxYmcxNVA1?=
 =?utf-8?B?RU1uOW5JOUZaWGdUVnlUZTlxanMrNmNJenVnb25hcGpxQ09jVlMwalpiQ0l2?=
 =?utf-8?B?bkwzNzNyb0VsZkwxNWVDQmxFZ1ZkUXFZTnJ1R1ljRFQwYndZc1krY29ZQ3Bi?=
 =?utf-8?B?K1crWjgrL2NKVlFkMGlUV25IUzZPcjNTODZ5d0RiMG0rVm5vMVprcXBKV2Ew?=
 =?utf-8?B?dmlFZ2o2cUJpZkVldHRJTnY1OTZQNUU4VGdxd1YzZlNJcGI1OHYwS3l1bGVk?=
 =?utf-8?B?VHNXazZtQ2VUdk5iWCtTQ0lRVFErcFh4TFVSTkdEZzRZQkNHSWR0MzJLYUl4?=
 =?utf-8?B?S2hBMUpWbmdscSthZWFmZ2d6djAyL2FvZzMwdVdDckxNRDRSZkJ1TFdLb1VF?=
 =?utf-8?B?ZStHK2o5TVFHVG1WR0F6OVFkUHN1N1V1dnRocDBhNHJaMFdtUDR1UEwyeUw4?=
 =?utf-8?B?cy84SGMxcDBySVBKNzJoRHcwemRDRU04OEliejJHUjZrTVJVNHJTVWhFOXd1?=
 =?utf-8?B?TUo1cGg1VnZwN0cyZUkxM1NIZDUvQXZVd21OZm1PSzFlbk42ckg2a0pGeGEw?=
 =?utf-8?B?M051ODVZcHNTSERkU05oa2ovbFRkV0JmUlhGaWUvVWZoM0I1K2p4S3hVTkJ5?=
 =?utf-8?B?L1ZEM0NGbG96ZWtpWVFyMXcxSzVvWWhMWVlnUWgwdmxyZXRzTzE5dng1dVRC?=
 =?utf-8?B?V1ZNOHNrWEhRa09RQ3BOYk9rY2FJWWpENUhrR2VVbmNmZ3Y5cFFwaitWOTBy?=
 =?utf-8?B?RnJxRzhqQ0xIN3M5anNOdk50eG5nclJnYUVGZXZ4WTh6RGNRUk1RTmhMM3dk?=
 =?utf-8?B?Rjc3YkpZYjdRT1VQaDI0V3ROOUNOTmpMb2ZsNGZiTDl0bmhyRXRwSHAwaWxW?=
 =?utf-8?B?Y1Q3UTNjamRSTHZIaGtPYlBNSGJycWxXd2t6TDFpVmduc3cvenlQTm1heVRw?=
 =?utf-8?B?ZjZ5ekRtYVgrVFVVSk4vKzREMlhLNkpmYzhzVUppdmZTaDRzZWRIMDJ4MHJZ?=
 =?utf-8?B?MHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 17444bab-624c-46a0-9f2c-08dc65c48c75
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 07:43:22.6979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4G917FDAHVPmxIgUE7iCeONqRkv2PSZ7VV53rd2JxVbzQDIhVQx/uZ8RygtKjjO3RzdJKGA1HGDa0MavEJG1eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8605
X-OriginatorOrg: intel.com

On 4/26/2024 2:14 AM, Sean Christopherson wrote:
> Extend KVM's suppression of userspace MSR access failures to MSRs that KVM
> reports as emulated, but are ultimately unsupported, e.g. if the VMX MSRs
> are emulated by KVM, but are unsupported given the vCPU model.
>
> Suggested-by: Weijiang Yang<weijiang.yang@intel.com>
> Signed-off-by: Sean Christopherson<seanjc@google.com>
> ---
>   arch/x86/kvm/x86.c | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 4c91189342ff..14cfa25ef0e7 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -491,7 +491,7 @@ static bool kvm_is_immutable_feature_msr(u32 msr)
>   	return false;
>   }
>   
> -static bool kvm_is_msr_to_save(u32 msr_index)
> +static bool kvm_is_advertised_msr(u32 msr_index)
>   {
>   	unsigned int i;
>   
> @@ -500,6 +500,11 @@ static bool kvm_is_msr_to_save(u32 msr_index)
>   			return true;
>   	}
>   
> +	for (i = 0; i < num_emulated_msrs; i++) {
> +		if (emulated_msrs[i] == msr_index)
> +			return true;
> +	}
> +
>   	return false;
>   }
>   
> @@ -529,11 +534,11 @@ static __always_inline int kvm_do_msr_access(struct kvm_vcpu *vcpu, u32 msr,
>   
>   	/*
>   	 * Userspace is allowed to read MSRs, and write '0' to MSRs, that KVM
> -	 * reports as to-be-saved, even if an MSR isn't fully supported.
> +	 * advertises to userspace, even if an MSR isn't fully supported.
>   	 * Simply check that @data is '0', which covers both the write '0' case
>   	 * and all reads (in which case @data is zeroed on failure; see above).
>   	 */
> -	if (host_initiated && !*data && kvm_is_msr_to_save(msr))
> +	if (host_initiated && !*data && kvm_is_advertised_msr(msr))
>   		return 0;
>   
>   	if (!ignore_msrs) {

Reviewed-by: Weijiang Yang <weijiang.yang@intel.com>