Received-SPF: pass (google.com: domain of linux-kernel+bounces-159674-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d0b8e551-6330-4b1d-98bc-ef1b0e41fbb4@linux.ibm.com>
Date: Fri, 26 Apr 2024 10:04:32 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v6 07/11] net/smc: register loopback-ism into
 SMC-D device list
Content-Language: en-GB
To: Alexandra Winter <wintera@linux.ibm.com>,
        Wen Gu
 <guwen@linux.alibaba.com>, twinkler@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, jaka@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com,
        tonylu@linux.alibaba.com, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org
References: <20240414040304.54255-1-guwen@linux.alibaba.com>
 <20240414040304.54255-8-guwen@linux.alibaba.com>
 <ef936c58-e87c-4078-a4dc-ed7313dba2a3@linux.ibm.com>
 <23cff564-a65c-4db6-a386-2a7e56be84c8@linux.ibm.com>
From: Wenjia Zhang <wenjia@linux.ibm.com>
In-Reply-To: <23cff564-a65c-4db6-a386-2a7e56be84c8@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0


On 25.04.24 15:29, Alexandra Winter wrote:
> 
> 
> On 25.04.24 13:29, Wenjia Zhang wrote:
>>> +    if (!smcd->pnetid[0]) {
>>> +        fentry = list_first_entry_or_null(&smcd_dev_list.list,
>>> +                          struct smcd_dev, list);
>>> +        if (fentry && smc_ism_is_loopback(fentry))
>>> +            list_add(&smcd->list, &fentry->list);
>>> +        else
>>> +            list_add(&smcd->list, &smcd_dev_list.list);
>>> +    } else {
>>>            list_add_tail(&smcd->list, &smcd_dev_list.list);
>>> -    else
>>> -        list_add(&smcd->list, &smcd_dev_list.list);
>>> +    }
>>
>> Nit: here the pair of curly brackets are unnecessary.
> 
> Actually
> https://www.kernel.org/doc/html/latest/process/coding-style.html#codingstyle
> tells you to use those braces.
Thanks, @Alexandra!
Then @Wen, forget my comments on this pls!