Received-SPF: pass (google.com: domain of linux-kernel+bounces-159720-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Slark Xiao <slark_xiao@163.com>,
        "loic.poulain@linaro.org"
	<loic.poulain@linaro.org>,
        "ryazanov.s.a@gmail.com" <ryazanov.s.a@gmail.com>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: [PATCH net] net: wwan: Add net device name for error message print
Thread-Topic: [PATCH net] net: wwan: Add net device name for error message
 print
Thread-Index: AQHal7VPPuJz502WMUWsNz7J4sAgag==
Date: Fri, 26 Apr 2024 08:39:54 +0000
Message-ID: 
 <PH0PR18MB447473BBD688DC4771435822DE162@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240426080733.819633-1-slark_xiao@163.com>
In-Reply-To: <20240426080733.819633-1-slark_xiao@163.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?TB69PAsMzhz8uUZZAawDUQiQCMFhhRL+vThkc369GWPu+0EGlloI8i+7MKhf?=
 =?us-ascii?Q?UzUekuSYI4SELBYPtkJSKp+IqKQwBVnkg34ukaYkdfGSoNwSB1ZnGqwFqYLD?=
 =?us-ascii?Q?OvG0P5DZtn457V00N62leGV1zmlP+5WOs817nQhsXkeWznjwVf4Y1qxB+nfa?=
 =?us-ascii?Q?hxVbzbWxDAqCRJu4qCGeGvrn3JR3dBwFGSpIY2cOMuV9aQJsWdxXEZfALvE0?=
 =?us-ascii?Q?j8csEl3e0FY/FMUfwcuaFDTvuUsOzLFUXEKpkAMR0M12WjbxMrLkjDsDMyoI?=
 =?us-ascii?Q?6D903yIqypBL5buqZ5BFaqMKY1wvMNm4CsV/VlbsK5GlIT2QCrNkc+ULhU6S?=
 =?us-ascii?Q?88dESfsNWJRgoXG2X3Im/U7k+M8wKHGp4rTuOa23R5S9AW3sacV2SUARavr7?=
 =?us-ascii?Q?xKxeQ4Qz0DOu959eovuxPjbJtFEB73FJiFq4sMuSa2Ky59liT/7zwxIYe2YK?=
 =?us-ascii?Q?oaAcyGu26CSaXkqsBUDJ4IVzZIf+SPcFPjw9ZndBoS8i9zTJwrkeO3AkXUmo?=
 =?us-ascii?Q?/9z/n0PU+sE4j6Mdk4Hp205/T5Fs65HF/iMQHLNXRzeBIqXps19DhQPg8m3z?=
 =?us-ascii?Q?luSeIpGhOUE8HpeclWkqG4EeiB6yf5gN/eTUDTwC0PsMmDT4MW23YnYHI9S1?=
 =?us-ascii?Q?O9kR2nklxd75UOxDyAvoh+EgTbwS6s402UWck1X1xRW9TRGJV2C+3oP+zo8M?=
 =?us-ascii?Q?5BzHvNpfX0IJGXexRunbpMEmGDVi53pEhKx4/JmVcp6rzksTy+kFAaL89LPP?=
 =?us-ascii?Q?84fohlHZSUcAja6cnIEy1orKWMWyzp/vHdGK/OVPIl/tUancmXiYeFGfXg7I?=
 =?us-ascii?Q?l0ajHtbmGwAjtAw5+e98Y7tw91fmH69bEyhZdmAj2e89KPKgNNZXplsRsOUp?=
 =?us-ascii?Q?eIDyiSgPRMzwRgcJSoTu8wpo56J8qU+hu1b0xuh4S8TREj6ovFQxSxTSnFz1?=
 =?us-ascii?Q?jCuaS7UPexH8vT4J+i9PsoBlgCQ721Dhv2Dlk/XtGdlY1XWC/RRoQdGYlZI+?=
 =?us-ascii?Q?kq1y1jcDc3p0UFyQSLeteI7VAUvRIYxVjY0vDz6WpZlocrzeSHmms+2+RJY2?=
 =?us-ascii?Q?jw7QIVmrAJ4m/jUDz6cUpwQ/n7r278EHqCEgJFofZ67P9m+7HzmsRlUMGxzh?=
 =?us-ascii?Q?4nj09vhA6R7zHmwQCDLEImGrIKsR1aF9l+Vz9vsiwgbbQJQwtzwOPnvuY53U?=
 =?us-ascii?Q?5hX7NMThFBHJegFWJLbEe1bbJaBnEgn4O6BIvgqrlcJgv7f6bBNIs9jnAMwF?=
 =?us-ascii?Q?E/k2e6NAklwsoYl91pcT7QBJ6wOR9oIGQ7TGP/zW4OGN1acsek0JaO3qD5UQ?=
 =?us-ascii?Q?WBwJMYNTVPvfoa/KkPDHJoUGCx8oc2Lp6mi08ZC05MtmPOZUsJN0CKXhyjGI?=
 =?us-ascii?Q?o/hRKwe3JjR9rJbOeB+ceQ7D/StXHSv7O/WXmadCUkZiwrefLvsxRQVXKEja?=
 =?us-ascii?Q?0vlZGMLNkQ4pK7ZWFTuijCN5iTxXp+MRK+qt3BSyKgVL99o1nY+thAEazafX?=
 =?us-ascii?Q?sejyety/nVNIqsCxFxwQB0opeHOmUxJQOzCEAGxVtbBSR1hzfZoi1ncDHO6v?=
 =?us-ascii?Q?aNBzr/0kEsJKsJW+E/c=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 837e5f9c-5858-4c9c-eb7c-08dc65cc725b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2024 08:39:54.5900
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RHT5w7ktfip2Zehe3j77cGSyyLeZ0GbE+oYPtNGst0jAEuagaYl800wGTFBLL2KK/gSoN22xUHcCcWcdZCVGZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB5914
X-Proofpoint-GUID: gnEiDZnif9HKPV1lo0QXTQbT0cuCCGVt
X-Proofpoint-ORIG-GUID: gnEiDZnif9HKPV1lo0QXTQbT0cuCCGVt
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-26_07,2024-04-26_01,2023-05-22_02


> In my local, I got an error print in dmesg like below:
> "sequence number glitch prev=3D487 curr=3D0"
> After checking, it belongs to mhi_wwan_mbim.c. Refer to the usage of this
> API in other files, I think we should add net device name print before
> message context.
>=20
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---
>  drivers/net/wwan/mhi_wwan_mbim.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c
> b/drivers/net/wwan/mhi_wwan_mbim.c
> index 3f72ae943b29..6cefee25efc4 100644
> --- a/drivers/net/wwan/mhi_wwan_mbim.c
> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> @@ -186,14 +186,14 @@ static int mbim_rx_verify_nth16(struct
> mhi_mbim_context *mbim, struct sk_buff *s
>=20
>  	if (skb->len < sizeof(struct usb_cdc_ncm_nth16) +
>  			sizeof(struct usb_cdc_ncm_ndp16)) {
> -		net_err_ratelimited("frame too short\n");
> +		net_err_ratelimited("mbim: frame too short\n");
>  		return -EINVAL;
>  	}
>=20
>  	nth16 =3D (struct usb_cdc_ncm_nth16 *)skb->data;
>=20
>  	if (nth16->dwSignature !=3D
> cpu_to_le32(USB_CDC_NCM_NTH16_SIGN)) {
> -		net_err_ratelimited("invalid NTH16 signature <%#010x>\n",
> +		net_err_ratelimited("mbim: invalid NTH16 signature
> <%#010x>\n",
>  				    le32_to_cpu(nth16->dwSignature));
>  		return -EINVAL;
>  	}
> @@ -201,7 +201,7 @@ static int mbim_rx_verify_nth16(struct
> mhi_mbim_context *mbim, struct sk_buff *s
>  	/* No limit on the block length, except the size of the data pkt */
>  	len =3D le16_to_cpu(nth16->wBlockLength);
>  	if (len > skb->len) {
> -		net_err_ratelimited("NTB does not fit into the skb %u/%u\n",
> +		net_err_ratelimited("mbim: NTB does not fit into the skb
> %u/%u\n",
>  				    len, skb->len);
>  		return -EINVAL;
>  	}
> @@ -209,7 +209,7 @@ static int mbim_rx_verify_nth16(struct
> mhi_mbim_context *mbim, struct sk_buff *s
>  	if (mbim->rx_seq + 1 !=3D le16_to_cpu(nth16->wSequence) &&
>  	    (mbim->rx_seq || le16_to_cpu(nth16->wSequence)) &&
>  	    !(mbim->rx_seq =3D=3D 0xffff && !le16_to_cpu(nth16->wSequence))) {
> -		net_err_ratelimited("sequence number glitch prev=3D%d
> curr=3D%d\n",
> +		net_err_ratelimited("mbim: sequence number glitch prev=3D%d
> curr=3D%d\n",
>  				    mbim->rx_seq, le16_to_cpu(nth16-
> >wSequence));
>  	}
>  	mbim->rx_seq =3D le16_to_cpu(nth16->wSequence); @@ -222,7 +222,7
> @@ static int mbim_rx_verify_ndp16(struct sk_buff *skb, struct
> usb_cdc_ncm_ndp16 *n
>  	int ret;
>=20
>  	if (le16_to_cpu(ndp16->wLength) <
> USB_CDC_NCM_NDP16_LENGTH_MIN) {
> -		net_err_ratelimited("invalid DPT16 length <%u>\n",
> +		net_err_ratelimited("mbim: invalid DPT16 length <%u>\n",
>  				    le16_to_cpu(ndp16->wLength));
>  		return -EINVAL;
>  	}
> @@ -233,7 +233,7 @@ static int mbim_rx_verify_ndp16(struct sk_buff *skb,
> struct usb_cdc_ncm_ndp16 *n
>=20
>  	if (sizeof(struct usb_cdc_ncm_ndp16) +
>  	     ret * sizeof(struct usb_cdc_ncm_dpe16) > skb->len) {
> -		net_err_ratelimited("Invalid nframes =3D %d\n", ret);
> +		net_err_ratelimited("mbim: Invalid nframes =3D %d\n", ret);
>  		return -EINVAL;
>  	}
>=20
> --
> 2.25.1
>=20
Nit: since this patch submitted to "net" , add fixes-tag

Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>