Received-SPF: pass (google.com: domain of linux-kernel+bounces-159757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240425092859.3370297-1-glider@google.com> <20240425133121.efd1f9da094be454a6366cf2@linux-foundation.org>
In-Reply-To: <20240425133121.efd1f9da094be454a6366cf2@linux-foundation.org>
From: Alexander Potapenko <glider@google.com>
Date: Fri, 26 Apr 2024 11:09:06 +0200
Message-ID: <CAG_fn=VumGCGWKf7M7HWU5nKDHAcksqjYeBq0hXVd_k=anmn0A@mail.gmail.com>
Subject: Re: [PATCH] kmsan: compiler_types: declare __no_sanitize_or_inline
To: Andrew Morton <akpm@linux-foundation.org>
Cc: elver@google.com, dvyukov@google.com, ojeda@kernel.org, 
	linux-kernel@vger.kernel.org, 
	syzbot+355c5bb8c1445c871ee8@syzkaller.appspotmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 25, 2024 at 10:31=E2=80=AFPM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Thu, 25 Apr 2024 11:28:59 +0200 Alexander Potapenko <glider@google.com=
> wrote:
>
> > It turned out that KMSAN instruments READ_ONCE_NOCHECK(), resulting in
> > false positive reports, because __no_sanitize_or_inline enforced inlini=
ng.
> >
> > Properly declare __no_sanitize_or_inline under __SANITIZE_MEMORY__,
> > so that it does not inline the annotated function.

As Marco noted above, we may want to rephrase it as:

  Properly declare __no_sanitize_or_inline under __SANITIZE_MEMORY__,
  so that it does not __always_inline the annotated function.

Let me know if I need to send a v2.

> > Reported-by: syzbot+355c5bb8c1445c871ee8@syzkaller.appspotmail.com
>
> I'll add
>
> Link: https://lkml.kernel.org/r/000000000000826ac1061675b0e3@google.com
>
> And I think a cc:stable is justifiable.

Agreed.

> A Fixes: target would be nice?

Hmm, the introduction of READ_ONCE_NOCHECK predates KMSAN.
We could do:
  Fixes: 5de0ce85f5a4d ("kmsan: mark noinstr as __no_sanitize_memory")

, because that commit should have introduced __no_sanitize_or_inline for KM=
SAN.