Date: Sun, 27 Jan 2008 23:42:59 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c -
	take 2
Message-ID: <20080127224258.GA22018@elte.hu>
References: <20080127231527.2ea40804@paolo-desktop> <479D067E.3010100@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <479D067E.3010100@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 28


* Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:

> Looks like it would be better to proceed in the following manner:
> 
> 1) remove dead code (no md5 change);
> 2) reformat the lines to use tabs, not spaces (no md5 change);
> 3) address the "else-braces" and "single statement block" errors
>    (no md5 change);
> 4) remove all unnecessary spaces (no md5 change);
> 5) add the KERN_ macros (md5 will change).
> 6) address remaining checkpatch complaints (no md5 change wrt #5
>    above).
> 
> Each item above might get into a separate patch.

agreed, that looks like a sensible splitup for such larger cleanup 
patches.

(also, a debug switch that disabled the FPU on modern CPUs and which 
forced math-emu would be nice as well.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/