Received: by 2002:ab2:3c46:0:b0:1f5:f2ab:c469 with SMTP id x6csp160043lqf; Fri, 26 Apr 2024 02:52:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUlc0qd6tignWSw4D4UN6U5MOtFKylCljlyKgLB6A1eIiBHWjSULA1+7akxz2ywpFtbDtgp2t9aiNSoxPYnodHccdCHuniafMrMkIx08Q== X-Google-Smtp-Source: AGHT+IEO1IRfXMur4BG7Pfpm2vU3g5u8ZmRFm46/+exd2kGabsPFPCy8WjyiJ3kg0M7n3ZYziLgX X-Received: by 2002:a05:6512:3144:b0:51b:1e76:4e9c with SMTP id s4-20020a056512314400b0051b1e764e9cmr1298552lfi.29.1714125153711; Fri, 26 Apr 2024 02:52:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714125153; cv=pass; d=google.com; s=arc-20160816; b=gypkXrD5n940DRkmnpksWzd/kPP+0eqkoE7qQwCWfFJQi6lI7UJ87wNqVFAZBGC9cO +sId7lVuYkFPs4TX2PY1CX04fGZNrss8ofUoOno4x5V04CztF/pqvfBcRwj+hLp7Uf+D AIW9y0sdKVkH+TpJb7Ty6OPPmkrXJyvFBZdpNt7LwMTtp8BXZKFJy+peC6OTaccAlw1z qR+rLVXqkNAF8bP7MsgK3woeVa+3SbMJM9Feo39lUBcJ+82p7WJ4TJbl2d9REVRINrMq 4ZPOEPadd+WEDHcKcVJBl8xISqpQAH3WC37PKW0tVKOPwFR9POme2ghmV13X8I62z90y Yvvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=Jm6PL9Z2zz8L7yBYNxpGkwSDbMydJQIDEId4e0qQv3w=; fh=qeP8ZoGn1GkvsEvYxhhNZYHClgemK2rquI3Rq6n38mo=; b=izme7O2HHnAGb3Fz6qd5OC5AQfIRuCQinen8y1Enj6P99/XB2VZmMnU2SmbBHGZsLj XrubqlZgyqyWgb+dWkEFz0kF+poeE9Kx+gJgSne1glO48L+etbzaZJraefe9P8N1iJV8 z8bbVSxZALQbAWsYSAq9BLMTMUatT6uqQ3lrsTY55vJvcgjDpSNH22+MVVdB5rUoz+Qe u44QR5by69ngKsmejehZte+Uo833TRJSU1xl7UkLHKuDphRsXW+lk5TF8WE11cdDEWoT 251GLyp8c4nreLYe3h7LoepZHPFjQWUiIso5F4awJcrno1nOZU90VRLc61z5mQ7o3dUf HeoA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=N7lILEOP; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-159819-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159819-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z2-20020a50eb42000000b005723ad3e130si2499078edp.539.2024.04.26.02.52.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 02:52:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-159819-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=N7lILEOP; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-159819-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159819-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6ED651F2205B for ; Fri, 26 Apr 2024 09:52:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4991613FD8B; Fri, 26 Apr 2024 09:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="N7lILEOP" Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A0513FD69 for ; Fri, 26 Apr 2024 09:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714125141; cv=none; b=M9JUucJgJSWJy95jZpAG0jvdN9EmoA7Pn969dWifuU/deDXRxPc1qYXc3vw1aI4OzpEZUP+jILQFnYGmu4HINaUsvtYg/FK641KDrpISuCneIZHfWLJw7R0nHbjXgomc6msfURO3QjcY5OhY3LYR6fG+sNoC17yAAEVt2zzK+MM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714125141; c=relaxed/simple; bh=Jm6PL9Z2zz8L7yBYNxpGkwSDbMydJQIDEId4e0qQv3w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KbiOjuIHGVwpEHV0TyrgaC8s8dBkJG6nKA0epQLD5F6XnDoSbD2EtfCRPxEpqgaIWKBngqujE9BhPU/qE3r+ZJWmh2uw9W4khNs7IEmHD9nHWUpQkDkqlB2544UJPu+fqQKZnSAtDg1+2kxS5rj2EkqWjDM/yushfBPkDHII+DI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=N7lILEOP; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=Jm6P L9Z2zz8L7yBYNxpGkwSDbMydJQIDEId4e0qQv3w=; b=N7lILEOP/oDCwlt+wFOW 9pDqq5xnixKVLXlkcSc7ZDaNqPhl+zR+BSTQKc4QPScaZRox2JLvuHYCg3R8/cv2 lSRsL78sPcmWR4ScwzDypIGssjqrIqOR5SQVEcCoxy8SUNBD3s7dJjPth8m6cKCl 4s0CFwHL0yNXgal7ZyZBjDbQ+cCHqbPUfTi5+aMOWmAq6nEEDLIoOAE4uHhRISVX 9oj342cK6Yliuzq+90brygoXvrrSCeKjT2DJk3gEabRvds8c/VxZnY2K1KW+RMHI bhoBfoNqEcWaPt9FahN8U6637fDGEXOOH+P6w+2GcW3dHLsHQXQ70m4rzGAeyuOM BQ== Received: (qmail 1267830 invoked from network); 26 Apr 2024 11:52:13 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 26 Apr 2024 11:52:13 +0200 X-UD-Smtp-Session: l3s3148p1@LdSp2/wWgpQujnvp Date: Fri, 26 Apr 2024 11:52:13 +0200 From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Baruch Siach , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: smbus: fix NULL function pointer dereference Message-ID: <20240426095213.pgk5tfe35kv6ppwp@ninjato> Mail-Followup-To: Wolfram Sang , linux-renesas-soc@vger.kernel.org, Baruch Siach , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240426064408.7372-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xht6wkuqmbe24lqy" Content-Disposition: inline In-Reply-To: <20240426064408.7372-1-wsa+renesas@sang-engineering.com> --xht6wkuqmbe24lqy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 26, 2024 at 08:44:08AM +0200, Wolfram Sang wrote: > Brauch reported an OOPS when using the designware controller as target > only. Target-only modes break the assumption of one transfer function > always being available. Fix this by always checking the pointer in > __i2c_transfer. >=20 > Reported-by: Baruch Siach > Closes: https://lore.kernel.org/r/4269631780e5ba789cf1ae391eec1b959def7d9= 9.1712761976.git.baruch@tkos.co.il > Fixes: 4b1acc43331d ("i2c: core changes for slave support") > Signed-off-by: Wolfram Sang Fixed the name typo and applied to for-current, thanks! --xht6wkuqmbe24lqy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmYreUgACgkQFA3kzBSg KbZaLA/+JjcWZKSCI4lls86Wf67FtVWK7t1bbC/I11yecqS/bs9ypx1kiwOJo7O1 0JVybH4tSOku8x3CP6M0WaIxGWbHfEBPAAX2g9lx9+izvun4xGaLGeRkViesjKnG nGOx6LyvTmZh1j6rrGis9gmbh4CWBYszryn39VCrVslmlhqaLVYW8O7NluVEakFE ylNdZ+BPPwaePCU3ptUsSdubajzqgLjWpTWxoAhloUWkU08b5Aj8bfA3fXRybEsg hAVVg/5Y7sBgljqps5F+7xFf1oBDWVWcKvvidA7Ifj1dBTmRv9HomDhxbQ/2G7RV eQeb+v0UlPXfvaJI6EY3JdQaCpbJNTzsGKk5GFbetXpmwt/7T4mmlH5fvXdGMdn9 hpmB5Ottzfi/LfUgWfdLb3tHJKUAfKb+u2rdcOKtFVp4xMyWKZL49gpTYLYosJw4 zEkOBCQ4ANfqsZ+ZBgIlfx18NV5vdDLt2EKqjKM1hVtrzqd8TGKbgfJHpo1Ihsrp C55LUsZYRIImeJSzaMPwMhU0Mk5mtBLlX9JzCd6nSUO/DKJ48W6Zz+PRsbY3l//U 9Ol6c3+doo0NiMJwyRXmu6mMYx8vQj2OIKcTqyIdozwEWqVEwJjolT8y+xweXDus X4VszIpdA+uejbKUnWOvJ1gLLh+Xoi5WkpjKvXvTkpPoLhsyPpg= =HZIj -----END PGP SIGNATURE----- --xht6wkuqmbe24lqy--